From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 364FC379EE7 for ; Tue, 28 Apr 2026 15:00:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777388441; cv=none; b=gEYFlmXQGUj5PbNdtxIVgpnWyo8hebCUl2g/QBgR/vuxwme2ddTUZ2vKE0U2eZZVptlsxkTGC/OSyFUNn1B94FQMD8py5yWmMMjZP2UnwnupAfLTicZkQGtNeki3riKJ3xKot+4b4MFpvRvb0KS3T3Xh6WZP8LgtWKkgYIjk6pw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777388441; c=relaxed/simple; bh=fJtlHGQ/f2r7tKlFA+n770d6vXYveowm+uvygjrL9U0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=V5TLsB8pOwjsxKCEt+qP1Yog8J5S5WIEvzdOJTqtJaGFmsBBXBT45vUk+J432nNsGSZKKGSgl1wf2u2m6rhCGsM+TNTLlgL8D/iXdk0uP5SF43UqP+RS2Wp4iJj7x9p845q3rBtp6Zldss6ZWNPNGyq/BBhqrwM1cD7rOAs9vrE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=VjWsOMjG; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="VjWsOMjG" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1FyaRK6gojofPC2z5totpz2z9CLl0bs8EycBXCPHzDc=; b=VjWsOMjG6N9v6n3hgvB6GDcs24 2ZInhOZhAV35USKGQfLooHPBwG0t3tVzIf1yPnTPPyN2XS6PUz1/cXc82nhB7X29t+wBVMEfTuzcO hJe0WZlZQRxfIH+gLzdSvViZfCEkeneIEk8IR6Tfovgev61X2NFMfzGT2S+HKKguBfCMU/aJAO1o3 R9teCCERnM6vbf8vi9Ao0L5Q+i1YXzCVRIZ+q7EqNG3ZgF3gbUTWv+1TOhXniEmxNcDxgBFU5jVEG w2O/lhLVOHFd6aPkxBL5pwYCy44zRqsgZPMihOpkJ2zJVPRii2r8FIV+0VrnaeQ0Om/Hczq/wMw6s OcdWh8Tg==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1wHjvL-006Ky8-0h; Tue, 28 Apr 2026 15:00:31 +0000 Date: Tue, 28 Apr 2026 08:00:27 -0700 From: Breno Leitao To: Tejun Heo Cc: Lai Jiangshan , Andy Shevchenko , Krzysztof Kozlowski , clm@fb.com, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH] workqueue: fix devm_alloc_workqueue() va_list misuse Message-ID: References: <20260427-wq_fix_chris-v1-1-988649834b79@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Debian-User: leitao On Mon, Apr 27, 2026 at 07:29:31AM -1000, Tejun Heo wrote: > Nice catch. Could you fold both noprof entries onto a shared helper? > > static struct workqueue_struct * > alloc_workqueue_va(const char *fmt, unsigned int flags, > int max_active, va_list args) > { > struct workqueue_struct *wq; > > wq = __alloc_workqueue(fmt, flags, max_active, args); > if (wq) > wq_init_lockdep(wq); > return wq; > } > > alloc_workqueue_lockdep_map() can stay on bare __alloc_workqueue() since > it supplies its own lockdep_map. Ack, I will update and respin. Thanks for the review, --breno