From: "Luck, Tony" <tony.luck@intel.com>
To: Babu Moger <babu.moger@amd.com>
Cc: <linux-kernel@vger.kernel.org>,
<linux-tip-commits@vger.kernel.org>,
Reinette Chatre <reinette.chatre@intel.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Chen Yu <yu.c.chen@intel.com>, <x86@kernel.org>
Subject: Re: [tip: x86/urgent] x86/resctrl: Fix SNC detection
Date: Tue, 28 Apr 2026 13:52:53 -0700 [thread overview]
Message-ID: <afEeJS2Ls-i3cWom@agluck-desk3> (raw)
In-Reply-To: <37ac0376-43a3-4283-a3d5-4d57b3bec578@amd.com>
On Tue, Apr 28, 2026 at 03:41:51PM -0500, Babu Moger wrote:
> Hi Tony,
...
> Saw these messages on AMD system(7.1.0-rc1).
>
> sudo dmesg |grep CoD
> [ 6.614667] resctrl: CoD enabled system? Resctrl not supported
>
>
> Might confuse some users. Not a big deal. But we should fix it in next
> version.
Babu,
Indeed yes. Thanks for letting me know.
I think this should fix it. Can you test please?
-Tony
---
diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c b/arch/x86/kernel/cpu/resctrl/monitor.c
index 497cc57ac135..3d72ff5d0c25 100644
--- a/arch/x86/kernel/cpu/resctrl/monitor.c
+++ b/arch/x86/kernel/cpu/resctrl/monitor.c
@@ -374,7 +374,12 @@ static const struct x86_cpu_id snc_cpu_ids[] __initconst = {
static __init int snc_get_config(void)
{
- int ret = topology_num_nodes_per_package();
+ int ret;
+
+ if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL)
+ return 1;
+
+ ret = topology_num_nodes_per_package();
if (ret > 1 && !x86_match_cpu(snc_cpu_ids)) {
pr_warn("CoD enabled system? Resctrl not supported\n");
>
next prev parent reply other threads:[~2026-04-28 20:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 10:55 [PATCH v2 0/5] x86/topo: SNC Divination Peter Zijlstra
2026-03-03 10:55 ` [PATCH v2 1/5] x86/numa: Store extra copy of numa_nodes_parsed Peter Zijlstra
2026-03-04 15:46 ` [tip: x86/urgent] " tip-bot2 for Peter Zijlstra
2026-03-03 10:55 ` [PATCH v2 2/5] x86/topo: Add topology_num_nodes_per_package() Peter Zijlstra
2026-03-04 15:46 ` [tip: x86/urgent] " tip-bot2 for Peter Zijlstra
2026-03-03 10:55 ` [PATCH v2 3/5] x86/topo: Replace x86_has_numa_in_package Peter Zijlstra
2026-03-04 15:46 ` [tip: x86/urgent] " tip-bot2 for Peter Zijlstra
2026-03-03 10:55 ` [PATCH v2 4/5] x86/topo: Fix SNC topology mess Peter Zijlstra
2026-03-03 11:59 ` Ingo Molnar
2026-03-03 14:45 ` Peter Zijlstra
2026-03-04 15:46 ` [tip: x86/urgent] " tip-bot2 for Peter Zijlstra
2026-03-03 10:55 ` [PATCH v2 5/5] x86/resctrl: Fix SNC detection Peter Zijlstra
2026-03-04 15:46 ` [tip: x86/urgent] " tip-bot2 for Tony Luck
2026-04-28 20:41 ` Babu Moger
2026-04-28 20:52 ` Luck, Tony [this message]
2026-04-28 23:09 ` Moger, Babu
2026-03-03 12:01 ` [PATCH v2 0/5] x86/topo: SNC Divination Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afEeJS2Ls-i3cWom@agluck-desk3 \
--to=tony.luck@intel.com \
--cc=babu.moger@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=reinette.chatre@intel.com \
--cc=rui.zhang@intel.com \
--cc=x86@kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox