From: Mark Brown <broonie@kernel.org>
To: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Yixun Lan <dlan@kernel.org>,
Jinmei Wei <weijinmei@linux.spacemit.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-sound@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/7] ASoC: spacemit: fix RX DMA params not set when TX is running
Date: Wed, 29 Apr 2026 11:28:26 +0900 [thread overview]
Message-ID: <afFsyiSHrVBapQ9V@sirena.co.uk> (raw)
In-Reply-To: <20260429-k3-i2s-v1-1-2fe99db11ecb@linux.spacemit.com>
[-- Attachment #1: Type: text/plain, Size: 297 bytes --]
On Wed, Apr 29, 2026 at 09:38:46AM +0800, Troy Mitchell wrote:
> + val = readl(i2s->base + SSCR);
> + if (val & SSCR_SSE)
> + return 0;
> +
> val = readl(i2s->base + SSCR);
> val &= ~SSCR_DW_32BYTE;
> val |= data_width;
Very minor optimisation but those two SSCR reads could be combined.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-04-29 2:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 1:38 [PATCH 0/7] ASoC: spacemit: bug fixes, refactoring, and K3 SoC support Troy Mitchell
2026-04-29 1:38 ` [PATCH 1/7] ASoC: spacemit: fix RX DMA params not set when TX is running Troy Mitchell
2026-04-29 2:28 ` Mark Brown [this message]
2026-04-29 7:56 ` Troy Mitchell
2026-04-29 2:35 ` Mark Brown
2026-04-29 8:03 ` Troy Mitchell
2026-04-29 1:38 ` [PATCH 2/7] ASoC: spacemit: move hw constraints from hw_params to startup Troy Mitchell
2026-04-29 1:38 ` [PATCH 3/7] ASoC: spacemit: adjust FIFO trigger threshold to half FIFO size Troy Mitchell
2026-04-29 1:38 ` [PATCH 4/7] ASoC: dt-bindings: add SpacemiT K3 SoC compatible Troy Mitchell
2026-05-06 1:40 ` Rob Herring (Arm)
2026-04-29 1:38 ` [PATCH 5/7] ASoC: dt-bindings: add fixed-sample-rate property for SpacemiT K1/K3 Troy Mitchell
2026-04-29 2:18 ` Mark Brown
2026-04-29 8:06 ` Troy Mitchell
2026-04-29 1:38 ` [PATCH 6/7] ASoC: spacemit: add fixed-sample-rate constraint support Troy Mitchell
2026-04-29 1:38 ` [PATCH 7/7] ASoC: spacemit: add K3 SoC support with additional clocks Troy Mitchell
2026-04-29 2:32 ` [PATCH 0/7] ASoC: spacemit: bug fixes, refactoring, and K3 SoC support Mark Brown
2026-04-29 7:58 ` Troy Mitchell
2026-04-29 2:41 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afFsyiSHrVBapQ9V@sirena.co.uk \
--to=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=tiwai@suse.com \
--cc=troy.mitchell@linux.spacemit.com \
--cc=weijinmei@linux.spacemit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox