From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2385339BFFD for ; Wed, 29 Apr 2026 06:48:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777445306; cv=none; b=EB2b1H5uTUBYr6h1STDIIusRJhItsdSC2+sGCisKRwbnafQbCjH69vcVhLfC6VYrBSA1AoZOdaAyvX67FVft8vufTXFaK92LsAd2+TPoWlp696jLzoJj85689+8zaeBsl8ZWual1Uakq+DtMd3pnghgkbLsVx5Uyi32ekE9Onq8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777445306; c=relaxed/simple; bh=74yiVA+barDrmw2/b2nNUKKQm1v84lTrbgkdtxA3hzw=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=pWKxVUn+W6DEgt2YZb3EiSWWm+93pnRY4HgWb4k2BPSFB2HviISYmJZK6cXqe7WIEnlboaR5KQwpFzTZ6/uc0sY5lSHDGkrwk6FA6rR02ZtU0PawwUkN5LLtYfU7qBzDeZdCTd2p+C/SJdxbRiAVCE2Ga1nI29cBK0tdCAKJbWc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Gazr7/cz; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Gazr7/cz" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-488b0e1b870so209507945e9.2 for ; Tue, 28 Apr 2026 23:48:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777445302; x=1778050102; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=lDhQuZ2fFicfJqp5+3HbIXCIa2+xN5jtTHPkvfbA9J0=; b=Gazr7/czH233ef4C9mEBOpGxLjLkPZwUhkISYTYvY+1CZFBrEhV/AqEBG+Wnfec5Ty xFUDes3bsfRKouMRjClJLxT6+EiE1pBO179KVhCI2BJoTCNqrNNcUktk9xGV8d/ImYem P2FCN/q4zP9ek8U862wP5ZdIkRMkPPWhGobTjfX5cw2tpFQPCTY8HKdao98qaLKUlGRO ibxvKq82bZOWqYrfZ2MrW7H25wLeWLhptpX7fDPIfa60rHAY917sBcdAfsrrIPtny4PM HtKVNZPiS2Uj8Ix25lodL57ZQev+WrgBazQ15AmwUXOm9JYXBaUlRocmWdDIb8w812kH RxWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777445302; x=1778050102; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lDhQuZ2fFicfJqp5+3HbIXCIa2+xN5jtTHPkvfbA9J0=; b=PN2nnB1XWaEojOISWm2De/VOCXdtinHouaUbAFeyJL8WCz2l3NxnXMwzgldYeeKmpY LZ6qPleh0F5nrh7wBGhXeMH6oSu9dKaSP3XvsrB3eeMxSkMCpxm/izGQVzsZxB9qZL8R vQCHDO1D3u//m48l8gB9BKDnT7KEjrFF6CNJy11Wi1De/l27htic2mgmLWToj+NaL0BW n1O3SQXB0F/8vafUaOQNDD2jjzMLwdrd+HKlWPyctfelYVcuxdoedGylkoS7aQEWBUUd 80rTLE8MNy66TChbKfW+9JYixbXaJmW4J2NzfV7mKZaBsDqJh85nSK66rDEQKsJfKMPt LJgA== X-Forwarded-Encrypted: i=1; AFNElJ+X9UFb8PpG8G1dYAEzbBMZskiwmWR4KVsHIpnZqN/kyp0vYT8F/C7PhA4IzfD2nF7THZTuwNWiTbzUthE=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2j0lWLwGkd2stH1jj/bbI03jYmGpgL8Js7yubF3l2KVK71f+A KFU1+FK0NM2yzJUtlYZIafQ3429v6fN4mIfh9NpiyAPLidd/VOlRFPr4 X-Gm-Gg: AeBDieswHHE5R9scGBC8EoJmqDQAapoHtQwioXt9UtKWCMLlzDH4P6aUbNFiz3bkxLd kb3VZpKJEMvF1vjc80/KsJ9kVrfdxNjtUtHr/DcrwkjAZDoDfVWwm4VMesjgbAorqujN1FHI/m0 JnGBIvXg1W4Ixi3wxzW4tyFpgXzSifzm9emRnZdqr5RhT58Ci3wQD5BRqTgChO7XTYSV/s+rH9n 6NmUTPGjYzFgYEszO963QFDWeiRgBEVEF9YbXgxquIoGyS/Gy4V9bTsI6AJd5hV45OwxauDty7c RyDKHMObcd9L3XtPXEngWi8y0HYUzsrJa0rYzR7x69QPw0ecB0XXbPRgWDOckvvpszRjGCOSNU5 twaaXZdnVTfHJp0w3UOQoMhx9Nv3NGDPJYB4nRGRqY162+0w3+RjMXbTnFXKlK62EDgNuuzSA6O CfUlnepruVxHbfx7jeccWrLX2fkg/7xA== X-Received: by 2002:a05:600c:c091:b0:489:19e9:b139 with SMTP id 5b1f17b1804b1-48a7b5125ffmr30806325e9.1.1777445301640; Tue, 28 Apr 2026 23:48:21 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a7c57b579sm33738925e9.4.2026.04.28.23.48.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2026 23:48:20 -0700 (PDT) Date: Wed, 29 Apr 2026 09:48:17 +0300 From: Dan Carpenter To: Alejandro Lucero Cc: Edward Cree , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Martin Habets , Jiri Pirko , netdev@vger.kernel.org, linux-net-drivers@amd.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH v2 net] sfc: fix error code in efx_devlink_info_running_versions() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding Return -EIO if efx_mcdi_rpc() doesn't return enough space. Fixes: 14743ddd2495 ("sfc: add devlink info support for ef100") Signed-off-by: Dan Carpenter --- v2: Originally I returned -EINVAL but -EIO is the usual error code when 'MC response was too short' --- drivers/net/ethernet/sfc/efx_devlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/sfc/efx_devlink.c b/drivers/net/ethernet/sfc/efx_devlink.c index d842c60dfc10..e5c6f81af48b 100644 --- a/drivers/net/ethernet/sfc/efx_devlink.c +++ b/drivers/net/ethernet/sfc/efx_devlink.c @@ -531,7 +531,7 @@ static int efx_devlink_info_running_versions(struct efx_nic *efx, if (rc || outlength < MC_CMD_GET_VERSION_OUT_LEN) { netif_err(efx, drv, efx->net_dev, "mcdi MC_CMD_GET_VERSION failed\n"); - return rc; + return rc ?: -EIO; } /* Handle previous output */ -- 2.53.0