Re: [PATCH v2] iio: light: stk3310: Deal with the ps interrupt issue in PM

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Wed, Apr 29, 2026 at 02:51:23PM +0800, Miao Li wrote:

> On the Inspur HS326 laptop(which integrated with HiSilicon M900
> processor), if the STK3311-X chip's PS interrupt is configured
> in "Recommended interrupt mode", the interrupt cannot be triggered
> normally after waking from suspend or hibernation.
> 
> In this case, neither disabling and re-enabling the interrupt nor
> resetting the PS threshold register can restore the interrupt to
> normal operation.
> 
> If the interrupt is disabled in suspend() then reset the PS threshold
> register and enable the interrupt in resume(). This resolves the issue.

...

>  	struct mutex lock;
>  	bool als_enabled;
>  	bool ps_enabled;
> +	bool ps_int_enabled;
> +	uint32_t ps_thdl;
> +	uint32_t ps_thdh;

I still think we shouldn't add more {u}intXX_t into the drivers.
Just add a patch on top of this to clean up those types to use
kernel regular ones (uXX/sXX) instead.

>  	uint32_t ps_near_level;
>  	u64 timestamp;
>  	struct regmap *regmap;

I also haven't seen the response on `pahole` run. Is that tool happy with
the proposed layout?

-- 
With Best Regards,
Andy Shevchenko