From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3582139D6C8 for ; Wed, 29 Apr 2026 12:06:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777464398; cv=none; b=qFhLx8BJtw7SU4UKBvT4Gh+GU1Yh7ma9w6C2jRSX5023djsnPnObZ0SIQWunRmwp9+2hizAWdVecvTnDnJoiHDuFbY6QpaaQvxz0E3JjYhomZlnT6vCTDGS/UvTZNI27o1wZ/JRbNr2SGiClIB36pdMtUvxtHGy8QKwFILHE7pk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777464398; c=relaxed/simple; bh=lu/HKzE/lq2G71nT0injQQr3KyjKe8X50ScX5vY0rPQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=n7HODFxjQTpT19rVbcTeKS+RpLmyfxOMaQP0e7cC6MEY1fxmTWAgPx6iUiR8AU61FDlAM8YoZdHDVToSJL4pqz8UeTWc4HuIwWOerlTryFLrYuIchjIX3j3lEEgxuMwgAu4yIgu1T/XlE5r311dFLUfZ29Uaaqucfv1gxu8aok0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HF+mqovo; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HF+mqovo" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-48374014a77so159945695e9.3 for ; Wed, 29 Apr 2026 05:06:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777464396; x=1778069196; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=i92lzohDjsh3NY9nKaFXQJteZVFhTZTO2i0PlWpQq04=; b=HF+mqovo+E/IW4P1TL2QVtHRqcp8amfnI4IR8xtGJGSW6aq/LnQUcgiGBpo0kd2IHb nTmAewWUyE7oKLpFMFFNKZhRhHqdp0QEXS82Eql5kADiOAs3Q9QA8GG8314deMeCCvgr CG9CM/DCm4mLGvvOxgOJTPHiRUMCtba5j4tgMQwXZuHbSFxkgKmYMNaZB6wwDQh1jlNV f1EJMONQkXajkJEIhs3wS9OymoTNDVeGDQ52+WxUY+r2qGFDo1o809za02Ln7Jrt3vo0 bpEAgEua0G8fXYKy5gEarzR1Tk+V1HBdrb6q6DCWFgVXzhRu9svswj86LjsXhPmQcMyW +Sig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777464396; x=1778069196; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i92lzohDjsh3NY9nKaFXQJteZVFhTZTO2i0PlWpQq04=; b=IaGAHPppFbEgIz/ptULIYnd+7l7W5KYrrDB0AV7PTxIBgJymTZjjT/9PRTFeLDT3d1 yRvFcK8RLGEQ8MyWROpkQQSunp7aGjYimDJigLpp0siMvCEWGjbISz3i1KeTtTsJF1QG tqGHqyL5Dk6mLim1o/ts0g8+H2BSYnxSY1UpX4ZiQOMwG0aOdgP9b0H2Ml2tR6/a4ZvO HC+7z1MzoS1eo4PCq2hYwu0AgCmysL8JfBGg2UJ+z89xeHFwqRH8jRT23htbdNnFQoQQ wcB3+0AswiWiGdlHpHwdGSvtznPOaBNIOfolsVNkkKaosAkuW0yZT4NnOoAWRoJhxlpQ MuSg== X-Forwarded-Encrypted: i=1; AFNElJ/dZ/xok/grjLauhcbMkM3dDz9vfkV96XO6g0hrYeOys1KTkSniPDDyHnZgkgWtS8Gj6KhajO3AVPywQ/o=@vger.kernel.org X-Gm-Message-State: AOJu0YzHZ7Eo2c63Rc34oZW0ONdDsn4d0aO7L7BjmYJBdi8cZPTyGqX+ U3fPgO5lrufSAJH+NU1TZ7l4ymQaNJ6m9Xp5naZxDKPRF6qYraAjlLsXBIHRsA== X-Gm-Gg: AeBDiesvP7u9LTFtoC2Wy91KGikNmK10kc6FglwXcXWCEzBfxoR3UhG+eHpbxbnB9mo 6xKez1q2VYmzr+jxiqve+chbshmRFWieJ8Ykr7fL8xwbPgFqRiMCBXRtCzDba7wdC3BcTNep7cU MNVUCP/ySBdwlrSkTUVBTNzbyJ1MU8VZtAmInd4s9bxnTvIUPdhzvy7D7FLz9mJYI4SWe4PO3Yc ithH7cKQJXTJFvG5z/A4EwZRMaYa21webBZq5kbn0BfsW4L7C1PB6hxOV2rs17zHBhUMSr+DjOp 7eOOEXbS0ZJZbSdnEVw/GaRvcq7vV6RdAB8Kx4moOHZTtjW0uQoQm6DiAFdGzn+SjWbipd7ACii an2SQxUezWT7BhtTzCRw6yzzwTDThoL99vNjxnyURh+U6oRdrM4jZRQ2GoxidU4FstFwzch13sf ebv119XE6j2nMmec4tynNJV/o8uBDgTEwsz4DDggH3 X-Received: by 2002:a05:600c:8208:b0:489:1c1f:35f1 with SMTP id 5b1f17b1804b1-48a77ad5f64mr112046495e9.4.1777464395333; Wed, 29 Apr 2026 05:06:35 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a7bc79ab4sm55335745e9.9.2026.04.29.05.06.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 05:06:34 -0700 (PDT) Date: Wed, 29 Apr 2026 15:06:30 +0300 From: Dan Carpenter To: Luka Gejak Cc: Linus Probert , gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH 0/8] staging: rtl8723bs: remove warnings in rtw_btcoex.h Message-ID: References: <12186A7D-522A-4900-9E4A-E2B575930A72@linux.dev> <2097F9CE-F003-4BE1-AEF5-0B30294973FB@linux.dev> <177745958799.1254637.4289009650997698120.b4-reply@b4> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Apr 29, 2026 at 01:34:41PM +0200, Luka Gejak wrote: > On April 29, 2026 12:46:27 PM GMT+02:00, Linus Probert wrote: > >On 2026-04-29 12:24:53+02:00, Luka Gejak wrote: > >> On April 29, 2026 12:18:12 PM GMT+02:00, Luka Gejak wrote: > >> > >> >> This series eliminates all remaining checkpatch warnings in > >> > > >> >LGTM, so for the patch series: > >> > > >> >Reviewed-by: Luka Gejak > >> > > >> >Best regards, > >> >Luka Gejak > >> > >> One note: > >> For the future cleanup series, feel free to squash identical logical > >> changes into a single patch to keep the commit history concise. It's > >> up to Greg if he wants v2 but logic is sound as is. > >> Best regards, > >> Luka Gejak > > > >I will make a note of that. In this case what do you consider an > >identical logical change? What would you suggest that I squash? > > > >Br, > >Linus > > > > A logical change refers to the type of cleanup being done. In your > series, patches 3-8 all do the exact same thing: fix CamelCase names > for functions defined in rtw_btcoex.h. Instead of 6 separate commits, > those could be squashed into a single patch. But as I already said it > is up to Greg if he wants v2 or if he wants to keep v1 as is. Either > way code itself is good. Greg has said in the past he prefers them all as separate changes the way this patchset does it. He recently asked somone to split up a typedef patch into one typedef per patch. regards, dan carpenter