From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 654CB3E51F4 for ; Wed, 29 Apr 2026 10:31:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777458673; cv=none; b=aJGDHdSOUdrgDN2OXekHV1gRnm83hjj/+Wc48lPCUv33i+TkCHPn4Xc7iTCZ6SnLAt3/ia9lieS8ehi5RkCFN5iB97LD4IwaP9c4wlDebOZJOS1tEmeA7rufakWKq4eizZwPTXvRlznY+hIFYmK2Ib58hU0dg5aOqUw0+HOP5GY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777458673; c=relaxed/simple; bh=IsPYo5A1NKgvPCB5OTEUwXERR7zAmjTkNZR4+UsSSBU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IHEXvEPeHLHA0ZrCUO/0tB15Z2jVLwZ0WuYkdvq6kveCmykFNvUYUkLiVjbDAxkp3mEb3seuk/ppC1av6nO5fbqSuQ3bjG31hXT2GU3Qs/cYbP8RBCuGpN94lyGdocHD75ka8VD79D/pct4EcXlg/rCE5YtsH3d2/GExYN1c0mY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eGGXGRcy; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eGGXGRcy" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4891e5b9c1fso108374985e9.2 for ; Wed, 29 Apr 2026 03:31:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777458669; x=1778063469; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2n5GHFY1IUCVIi1ZttxoD6PyKrxGhAIV1l0a9WHxBdg=; b=eGGXGRcyUpb8mpfFZHKsjFBQFzknnVKs9G4+uEZhUmXvAPeLUaqApncfo2YZfqjrmj RyWntMDdcVctQCWdgUF92fHZunP/VuWMkZ5F+wlwJnJqeAdvSZ7vVMiZa4kzUlgxtjxT ilQrKQeZXF9SKrQr3bXX73IOe7FJpYByR0LBIp3JeP73tm6+8+TsEYmC+DpukeZqB4sz IBARE7UaJhhDeRPFN1idCxixuNSAYYsjpswtyz50ubMXroEIF1coe9f4+7elK6aEeJLo UDWsnI3jxc9ZVOlZ93KbSBtNyYFOmvlXf3k2lIDHV10WjpU0OEIGn9JhxBWWFhr+aqXy IZxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777458669; x=1778063469; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2n5GHFY1IUCVIi1ZttxoD6PyKrxGhAIV1l0a9WHxBdg=; b=JZpZCjhEW4CuKFaFOtkN63DIw2N2QDIuQ7ybjCEc1rPpYEJnY6Ia0PKUorKf8agTJC 62dLDW5RGDy/0WS//brKewnwzhO/pNGzgyGhUtl/luI3x+qN1sxVigVOJSPBCVjJgkhW bl30TuMbSyOKeXxpKbYQ+2ZqAWeLYBehdjmG1NCgucRrTJxvJE9SNJm3CoVfi2b5SMv/ LuQbtI5awx+0yurkDYX0L1k8IyG1mEJ5Wwo8mLxwcZqoKNMKXRsf0RVPQSc7YyzqPiK5 r2KwqDMi5wdeAR9TEg6ccqPP2s6iNDS35heFP7n47BnTrek221Vdm7WV43duxQq0sSPR ncrg== X-Forwarded-Encrypted: i=1; AFNElJ+0SdNegXfUHfdbX+Qfkg8rXZQlCbzqLXPTKyZ4Ej0EVZgLf1wSb00Gc2+RzSNvFzpV9C2BmFLAs9g31G4=@vger.kernel.org X-Gm-Message-State: AOJu0YyaXbXuEGsxwPZsXWECteYEbkKaHN3GFGnnAARM+7MiYziM8X/3 XNw8g1ZpsPAVEfPhfE9enTltKZLzyP8c5l4IcsPlH1Aei0/kdEfqoh3Y X-Gm-Gg: AeBDiety4Y8AYV0pDzuisD8/e5WBcQATXSymyw4KueBRHwObQgArpwJf6esdBKbpAxL GzeFKTxFG054tnwAMXvzbdJrM0lgrzaBs0jId3cwISHYtW0ncTuVXjGYTkpVhydd315/z2cnPiI WDfoEfif7ajeR+k5yB2H7vGYNS4s4CNVUQLrb1MhVGjDRHRj4uK5+Slv31VNWRfQBpHuqZX2Bf/ dozoOFbZ2g/lPG6c6FkMvU/3OjYytXCg2VN/SH8CsLKFwTHHJ/va/OfGm40jJWNKtdo0sUsC0wc G7GNWmq8RkCt/9a2iY3BL3N2vKtR0tEpPZBkpFJ+b05unpcM1O0oG8BkBPxsqwnYvsXFNw8gJfe 4xDDrtxSH8sSH2AumIknMoh3Gi7GYr7vzI/ih2zv7cbRLhv7E4dJdL6LtmwThN72f5+IOhTeyrI dh1m7pG13KeMmSv2WZSxEi6rlh3loQJg== X-Received: by 2002:a05:600c:3b13:b0:488:c40b:c8a4 with SMTP id 5b1f17b1804b1-48a77add9cemr108962985e9.1.1777458669022; Wed, 29 Apr 2026 03:31:09 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a7c2ddc65sm23523735e9.4.2026.04.29.03.31.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 03:31:08 -0700 (PDT) Date: Wed, 29 Apr 2026 13:31:04 +0300 From: Dan Carpenter To: Ricardo Ribalda Cc: Mauro Carvalho Chehab , Laurent Pinchart , Sakari Ailus , Hans Verkuil , Nas Chung , Jackson Lee , Bingbu Cao , Tianshu Qiu , Greg Kroah-Hartman , Keke Li , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH 0/6] media: Fix new smatch warnings Message-ID: References: <20260428-smatch-7-1-v1-0-46890dffb611@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="PCA+ff0wVcep1+Lo" Content-Disposition: inline In-Reply-To: --PCA+ff0wVcep1+Lo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Apr 28, 2026 at 03:58:08PM +0200, Ricardo Ribalda wrote: > > The only one that deserves a complain is this one: > https://lore.kernel.org/linux-media/CANiDSCtm4Nh4Ub4rbEBvpjV8GXT9VQ5eFXZTHn=Wy=0RpR=3JA@mail.gmail.com/T/#m650723c33ec0318d8f32f1a6cc74c74a952ae11a Thanks. I've written a fix for this. Let me test it tonight and I'll push later. I've attached the validation/ test so you can look at the new ouput. ./smatch sm_mask1.c regards, dan carpenter --PCA+ff0wVcep1+Lo Content-Type: text/x-csrc; charset=us-ascii Content-Disposition: attachment; filename="sm_mask1.c" #include "check_debug.h" void func(int a, int b, int c, int d, int e) { if (a < 65) return; if (b < 0 || b > 7) return; if (c < 7 || c > 17) return; if (d < 0) return; e &= 0xf0; __smatch_implied(a); __smatch_implied(a & ~7); __smatch_implied(~7 & a); __smatch_implied(b & ~7); __smatch_implied(c & ~7); __smatch_implied(d & 0xff); __smatch_implied(d & 0xf0); __smatch_implied(d & e); __smatch_implied(d & (unsigned char)a); __smatch_implied(b & (unsigned char)a); __smatch_implied(c & (unsigned char)a); } /* * check-name: smatch: mask #1 * check-command: ./smatch -I.. sm_mask1.c * * check-output-start sm_mask1.c:16 func() implied: a = '65-s32max' sm_mask1.c:17 func() implied: a & ~7 = '64-s32max' sm_mask1.c:18 func() implied: ~7 & a = '64-s32max' sm_mask1.c:19 func() implied: b & ~7 = '0' sm_mask1.c:20 func() implied: c & ~7 = '0,8-16' sm_mask1.c:21 func() implied: d & 255 = '0-255' sm_mask1.c:22 func() implied: d & 240 = '0,16-240' sm_mask1.c:23 func() implied: d & e = '0,16-240' sm_mask1.c:24 func() implied: d & a = '0-255' sm_mask1.c:25 func() implied: b & a = '0-7' sm_mask1.c:26 func() implied: c & a = '0-17' * check-output-end */ --PCA+ff0wVcep1+Lo--