[PATCH v0 08/14] iio: magnetometer: ak8975: Reduce usage of magic lengths of the buffer

Andy Shevchenko
2026-04-27T20:14:30Z

Reduce usage of magic lengths of the supplied buffer by replacing them
with the corresponding sizeof():s.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/iio/magnetometer/ak8975.c | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
index dbaa64c66e4d..7ec1d4848fca 100644
--- a/drivers/iio/magnetometer/ak8975.c
+++ b/drivers/iio/magnetometer/ak8975.c
@@ -490,8 +490,10 @@ static int ak8975_who_i_am(struct i2c_client *client,
* AK8975 | DEVICE_ID | NA
* AK8963 | DEVICE_ID | NA
*/
- ret = i2c_smbus_read_i2c_block_data_or_emulated(
- client, AK09912_REG_WIA1, 2, wia_val);
+ ret = i2c_smbus_read_i2c_block_data_or_emulated(client,
+ AK09912_REG_WIA1,
+ sizeof(wia_val),
+ wia_val);
if (ret < 0) {
dev_err(&client->dev, "Error reading WIA\n");
return ret;
@@ -610,9 +612,10 @@ static int ak8975_setup(struct i2c_client *client)
}

/* Get asa data and store in the device data. */
- ret = i2c_smbus_read_i2c_block_data_or_emulated(
- client, data->def->ctrl_regs[ASA_BASE],
- 3, data->asa);
+ ret = i2c_smbus_read_i2c_block_data_or_emulated(client,
+ data->def->ctrl_regs[ASA_BASE],
+ sizeof(data->asa),
+ data->asa);
if (ret < 0) {
dev_err(&client->dev, "Not able to read asa data\n");
return ret;
@@ -853,7 +856,7 @@ static void ak8975_fill_buffer(struct iio_dev *indio_dev)
*/
ret = i2c_smbus_read_i2c_block_data_or_emulated(client,
def->data_regs[0],
- 3 * sizeof(fval[0]),
+ sizeof(fval),
(u8 *)fval);
if (ret < 0)
goto unlock;
--
2.50.1