Re: [PATCH v0 12/14] iio: magnetometer: ak8975: Unify messages with help of dev_err_probe()

Andy Shevchenko
2026-04-28T09:47:00Z

On Tue, Apr 28, 2026 at 11:21:29AM +0200, Joshua Crofts wrote:
> On Mon, 27 Apr 2026 at 22:14, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:

...

> > + if (ret)
> > + return dev_err_probe(dev, ret, "%s initialization fails\n", name);
>
> Minor typo, better to have "initialization failed", but that was already
> in the original codebase.
>
> > + if (ret)
> > + return dev_err_probe(dev, ret, "device register failed\n");
>
> Same here, "failed to register device" would probably be better imo.

Hmm... Not sure about these. I would leave as is and do a separate change.
(In principle I agree that messages may be improved.)

--
With Best Regards,
Andy Shevchenko