Re: [PATCH v0 14/14] iio: magnetometer: ak8975: Make use of the macros from bits.h

Andy Shevchenko
2026-04-28T07:54:24Z

On Tue, Apr 28, 2026 at 09:23:28AM +0200, Joshua Crofts wrote:
> On Mon, 27 Apr 2026 at 22:14, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > Make use of BIT() and GENMASK() where it makes sense.

...

> > #define AK8975_REG_ST1_DRDY_SHIFT 0
>
> Might as well remove these types of macros, as they are
> otherwise unused in the code after this patch. Either that
> or incorporate them into the BIT() and GENMASK()
> macros to prevent magic numbers.

Good catch! Please, adjust this patch accordingly in your local branch before
sending out.

--
With Best Regards,
Andy Shevchenko