Re: [PATCH v0 00/14] iio: magnetometer: ak8975: Additional changes to the driver

Joshua Crofts
2026-05-04T09:13:49Z

On Tue, 28 Apr 2026 at 18:35, Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Mon, 27 Apr 2026 22:09:45 +0200
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> > This series is an attempt to make the driver less a rabbit hole.
> > It's a continuation of what Joshua Crofts started doing. Hence
> > it is based on his work and first three "patches" here are supposed
> > to be folded to his series accordingly.
> >
> > I have compile-tested them, but I haven't done full double check of
> > the correctness from functional point of view. Joshua, please do that
> > before incorporating into your series. Yes, my patches are assumed to
> > become the part of Joshua's whatever next version of the series, that's
> > why mine is marked as v0.
> >
> > Should not be taken directly by the maintainers, but any comments, review
> > are highly appreciated.
> >
> A few brief comments but mostly looks good in isolation. I'll wait
> for the fused set with the fixups applied to take a closer look.
>
> Thanks Andy
>
> J
> > Andy Shevchenko (14):
> > drivers/iio/magnetometer/ak8975.c: fixup for the IWYU change
> > drivers/iio/magnetometer/ak8975.c: fixup for the errno fix
> > drivers/iio/magnetometer/ak8975.c: fixup for the iopoll.h conversion
> > iio: magnetometer: ak8975: Inline timeout constants
> > iio: magnetometer: ak8975: Avoid using temporary variable
> > iio: magnetometer: ak8975: Drop duplicate NULL check
> > iio: magnetometer: ak8975: remove duplicate error message
> > iio: magnetometer: ak8975: Reduce usage of magic lengths of the buffer
> > iio: magnetometer: ak8975: Unify return code variable name
> > iio: magnetometer: ak8975: switch to using managed resources
> > iio: magnetometer: ak8975: Consistently use 'data' parameter
> > iio: magnetometer: ak8975: Unify messages with help of dev_err_probe()
> > iio: magnetometer: ak8975: Use temporary variable for struct device
> > iio: magnetometer: ak8975: Make use of the macros from bits.h
> >
> > drivers/iio/magnetometer/ak8975.c | 253 +++++++++++++-----------------
> > 1 file changed, 112 insertions(+), 141 deletions(-)
> >

Given the relatively big backlog of email in the list, should I wait a
bit longer
sending the combined series?

--
Kind regards

CJD