From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AAF637F00D for ; Wed, 29 Apr 2026 15:41:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777477314; cv=none; b=NByNc26Y5ycVDoC+gMEFEmlBfkOXsgRFvD/fWeR69Krgis+sWtK9bVD1qZ2bK5quXe8RuobJfd+t/NDHvUek2jUmWIrq/afPZAlErrtUZartaHAxnibQlFQwd6KWr5zWWtf/+wzQfRaNnnPVrSCZMxFKr+6KrPccLEIDcOsRS+A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777477314; c=relaxed/simple; bh=ptDOA8oXfBcLNX1p/12OZLzqrk1BS6t5onLGu8IEt8M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=P6x1bC33gZAYwdPTMG0D24vW1fpMnKlP1qQBvPq6/3HTJBTVkEzB3D0y3kIbffZQ7tRYig2/xD+J+UFH2ilynieAVa2ulTU073N1zFXs/gzy+p+Bh+816YUUNneY6MLpINjdWZ2LQzIP8UG7j8D7GOQrwH81efPx7ZllI0g9YrQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=x/27T86g; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="x/27T86g" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2ad21f437eeso7799285ad.0 for ; Wed, 29 Apr 2026 08:41:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777477311; x=1778082111; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=h8L+nXE7L85P9lNyL2I2gs9CTUVcJOwgVrd7ZFlSaCE=; b=x/27T86gUyqmFKiprX3Eig42Q7FCCl2TkTqFhm0EveKwg9ZNtlWgGtuOdD71R4J+Ad g78mNZ31VSgKne6xap4Qepafn42S5ilLNua7qxaSqlGILcW3T+z2bQ8Onr+lKHKaqLUz cznRYN1QngzriWUdnBiD6d5nrtXBdky30GuxtsXzD0yTGqYvnmw9pfeFqbqnGUBA1QMZ noNSnrmA4VbtXWXRnOq84eXCnzAzVCCDrq8P1m8cjOrlfTBU+9M1Wrm2LXmz0AleFyYA uFjd5HdDCgfQRMFWCsTRbWjmvinnIJvlHiTzSX46+ofmFs9Rv82jxzsk7zpV8m4ZSYkC jUHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777477311; x=1778082111; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h8L+nXE7L85P9lNyL2I2gs9CTUVcJOwgVrd7ZFlSaCE=; b=IvrlwMe2rSvOS+E+G2D+e2Rtgkbec9Hpqgni6TXHfhhMgy3ZE8fY05ceepG/KkKAoA 80yjLSGSOsei6ZXT3Re8bXJKD9zjqLKSyPbvZjcPQv5U/0/ZYAgjCcEmgZtL4pTDnaVg lMPoFjka0yRX3JKPHeHGWndG2ZObWcYyrNRNc+JVW2ywBVFo0atO5PUf3TWBE6L6G3Gn X4phY+MCGl8uKGBNI7fdlxokmUsZCNnjaAZHSn+9oUoH05acb1o3EDiwD0oIypBVwwx3 Z1oXw9/D/KGK81NOnqjHvTzGbzlMMeEuyFUL7AkF6MNf9BYJq6ZnwmdA+GGzXUuN+VGG KdcA== X-Forwarded-Encrypted: i=1; AFNElJ+sPZLa0w30QmGoAFQ9QLljmdJ4ExLSUpQGUOSv1FHkvkLzYbZhm7p4AEPG02OzkUVnvgm4OHFqqSfJ+Kk=@vger.kernel.org X-Gm-Message-State: AOJu0YzVRpPVsntSLwPy4gNXaEn4suTBcy5sCqzk8A2cDvoc4GRawEf6 mQfgOsGZWowzzoHzsyn+Mz/bFUxXG3zIYBw7pfC0KkNR4jk0R0sPY9GQfiUSLfr6F3Q= X-Gm-Gg: AeBDieuMJlO2yS8919SHRS5OQu/D3nod20lcHoqltVoOu8G5xMtBvJ8otaOOAJe2QD3 b3qVFkgl3lgrZSIgcAYSh5jHVClauwaPl+JYLtuBLK5HaptMscZvh09PdqL+L97KxdUp7DDn5QI 79ZatnpFs5bWpFOwrjBdda2L5XiiY6XbO2TC1wSnirMye2GVCHCWp0BM3BTYXA4GCb36G+OJY8o y5vspmN7IzZX6tAv8RhApzCsBxF5WtkJ9Bhg9b5ngnZwmW5P3WT3tPw5oWWMIIwszdVuHPGQ/Zt cbC6OeQ32nZkDGpGYAAcbZUWZm/CHBYQJ1ESgu+wt9bj9D0Edi6WIyw/tha8AmFRx5NWspzgXuV LD+gDobGtUepticInoYZxH1w6HpOMqogZCW0lEzzrAYzbHDF2ttDSJENPxY5d0D/y0l87EbZLUj KA4G351PQtAOwOZwErUbFFIP6rCn07CDzRrRFQZA== X-Received: by 2002:a17:903:2410:b0:2b4:68c9:302a with SMTP id d9443c01a7336-2b9882388cdmr33673325ad.17.1777477310614; Wed, 29 Apr 2026 08:41:50 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:8131:aef0:bb67:5559]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b98899055fsm27045325ad.80.2026.04.29.08.41.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 08:41:50 -0700 (PDT) Date: Wed, 29 Apr 2026 09:41:46 -0600 From: Mathieu Poirier To: Shenwei Wang Cc: Andrew Lunn , "Padhi, Beleswar" , Linus Walleij , Bartosz Golaszewski , Jonathan Corbet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Frank Li , Sascha Hauer , Shuah Khan , "linux-gpio@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Pengutronix Kernel Team , Fabio Estevam , Peng Fan , "devicetree@vger.kernel.org" , "linux-remoteproc@vger.kernel.org" , "imx@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , dl-linux-imx , Bartosz Golaszewski Subject: Re: [PATCH v13 3/4] gpio: rpmsg: add generic rpmsg GPIO driver Message-ID: References: <20260422212849.1240591-1-shenwei.wang@nxp.com> <20260422212849.1240591-4-shenwei.wang@nxp.com> <22fb5fac-2568-42be-a7e3-7e89d0017eb3@ti.com> <6412a758-4560-4cf1-a0d0-5b24d1a715f1@lunn.ch> <6e01e114-e336-4744-b6b4-563ec42e321b@lunn.ch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Apr 28, 2026 at 03:24:59PM +0000, Shenwei Wang wrote: > > > > -----Original Message----- > > From: Andrew Lunn > > Sent: Monday, April 27, 2026 3:49 PM > > To: Shenwei Wang > > Cc: Padhi, Beleswar ; Linus Walleij ; > > Bartosz Golaszewski ; Jonathan Corbet ; > > Rob Herring ; Krzysztof Kozlowski ; > > Conor Dooley ; Bjorn Andersson > > ; Mathieu Poirier ; Frank Li > > ; Sascha Hauer ; Shuah Khan > > ; linux-gpio@vger.kernel.org; linux- > > doc@vger.kernel.org; linux-kernel@vger.kernel.org; Pengutronix Kernel Team > > ; Fabio Estevam ; Peng Fan > > ; devicetree@vger.kernel.org; linux- > > remoteproc@vger.kernel.org; imx@lists.linux.dev; linux-arm- > > kernel@lists.infradead.org; dl-linux-imx ; Bartosz > > Golaszewski > > Subject: [EXT] Re: [PATCH v13 3/4] gpio: rpmsg: add generic rpmsg GPIO driver > > > > struct virtio_gpio_response { > > > > __u8 status; > > > > __u8 value; > > > > }; > > > > > It is the same message format. Please see the message definition > > (GET_DIRECTION) below: > > > > > + +-----+-----+-----+-----+-----+----+ > > > + |0x00 |0x01 |0x02 |0x03 |0x04 |0x05| > > > + | 1 | 2 |port |line | err | dir| > > > + +-----+-----+-----+-----+-----+----+ > > > > Sorry, but i don't see how two u8 vs six u8 are the same message format. > > > > Some changes to the message format are necessary. > > Virtio uses two communication channels (virtqueues): one for requests and replies, and a second one for events. > In contrast, rpmsg provides only a single communication channel, so a type field is required to distinguish between > different kinds of messages. > > Since rpmsg replies and events share the same message format, an additional line is introduced to handle both cases. > > Finally, rpmsg supports multiple GPIO controllers, so a port field is added to uniquely identify the target controller. I have commented on this before - RPMSG is already providing multiplexing capability by way of endpoints. There is no need for a port field. One endpoint, one GPIO controller. > > Shenwei > > > Andrew