From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: rodrigo.alencar@analog.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Stefan Popa <stefan.popa@analog.com>,
Jonathan Cameron <jic23@cam.ac.uk>,
Greg Kroah-Hartman <gregkh@suse.de>,
Michael Auchter <michael.auchter@ni.com>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
David Lechner <dlechner@baylibre.com>,
Andy Shevchenko <andy@kernel.org>
Subject: Re: [PATCH v4 06/13] iio: dac: ad5686: refactor include headers
Date: Wed, 29 Apr 2026 21:19:02 +0300 [thread overview]
Message-ID: <afJLlpsU17Pmp0uH@ashevche-desk.local> (raw)
In-Reply-To: <CALoEA-yBU_pwiOFQx89-Gcgmtz_KtuxJJvph7uKPHKJNihDS8Q@mail.gmail.com>
On Wed, Apr 29, 2026 at 04:38:02PM +0200, Joshua Crofts wrote:
> On Wed, 29 Apr 2026 at 16:14, Andy Shevchenko
> <andriy.shevchenko@intel.com> wrote:
> > I haven't checked this deeply, but I hope at some point we will have
> > more or less usable state of `iwyu` tool that may do this automatically.
> > At least current result looks better than the original.
> >
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
> I did find a "filter" file of sorts for IWYU that Jonathan had on the
> mailing list.
> It does a good job of omitting reports of very low level headers but at the
> same time IWYU still tells you to include things like <linux/stddef.h> and
> remove anything <asm/*> from your includes. Perhaps it needs more
> tweaking?
You need to check that manually and then decide if we need more amendments
either in the patch or in the `iwyu` "filter" file or in both. In case of
filter file changes, please share them to Jonathan and mailing list, so other
people can adjust their work in case they use the tool.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-29 18:19 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 13:07 [PATCH v4 00/13] Fixes and cleanups for the AD5686 IIO driver Rodrigo Alencar via B4 Relay
2026-04-29 13:07 ` [PATCH v4 01/13] iio: dac: ad5686: fix ref bit initialization for single-channel parts Rodrigo Alencar via B4 Relay
2026-04-29 13:07 ` [PATCH v4 02/13] iio: dac: ad5686: fix input raw value check Rodrigo Alencar via B4 Relay
2026-04-29 13:07 ` [PATCH v4 03/13] iio: dac: ad5686: acquire lock when doing powerdown control Rodrigo Alencar via B4 Relay
2026-04-29 13:07 ` [PATCH v4 04/13] iio: dac: ad5686: fix powerdown control on dual-channel devices Rodrigo Alencar via B4 Relay
2026-04-29 14:03 ` Andy Shevchenko
2026-04-29 14:21 ` Rodrigo Alencar
2026-04-29 13:07 ` [PATCH v4 05/13] iio: dac: ad5686: fix overlapping DMA buffers in I2C read Rodrigo Alencar via B4 Relay
2026-04-29 13:12 ` Rodrigo Alencar
2026-04-29 13:50 ` Andy Shevchenko
2026-04-29 17:11 ` Jonathan Cameron
2026-04-29 14:07 ` Andy Shevchenko
2026-04-29 17:38 ` Jonathan Cameron
2026-04-29 13:07 ` [PATCH v4 06/13] iio: dac: ad5686: refactor include headers Rodrigo Alencar via B4 Relay
2026-04-29 14:09 ` Andy Shevchenko
2026-04-29 14:38 ` Joshua Crofts
2026-04-29 17:41 ` Jonathan Cameron
2026-04-29 18:19 ` Andy Shevchenko [this message]
2026-04-30 9:18 ` Joshua Crofts
2026-04-30 11:47 ` Andy Shevchenko
2026-05-05 10:55 ` Jonathan Cameron
2026-05-05 12:46 ` Andy Shevchenko
2026-04-29 13:07 ` [PATCH v4 07/13] iio: dac: ad5686: remove redundant register definition Rodrigo Alencar via B4 Relay
2026-04-29 13:07 ` [PATCH v4 08/13] iio: dac: ad5686: drop enum id Rodrigo Alencar via B4 Relay
2026-04-29 13:07 ` [PATCH v4 09/13] iio: dac: ad5686: add of_match table to the spi driver Rodrigo Alencar via B4 Relay
2026-04-29 13:07 ` [PATCH v4 10/13] iio: dac: ad5686: remove powerdown mask magic number Rodrigo Alencar via B4 Relay
2026-04-29 14:19 ` Andy Shevchenko
2026-04-29 13:07 ` [PATCH v4 11/13] iio: dac: ad5686: add control_sync() for single-channel devices Rodrigo Alencar via B4 Relay
2026-04-29 13:07 ` [PATCH v4 12/13] iio: dac: ad5686: cleanup doc header of local structs Rodrigo Alencar via B4 Relay
2026-04-29 13:07 ` [PATCH v4 13/13] iio: dac: ad5686: create bus ops struct Rodrigo Alencar via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afJLlpsU17Pmp0uH@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@suse.de \
--cc=jic23@cam.ac.uk \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.auchter@ni.com \
--cc=rodrigo.alencar@analog.com \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox