From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: Piyush Patle <piyushpatle228@gmail.com>,
ak@it-klinger.de, jic23@kernel.org, dlechner@baylibre.com,
nuno.sa@analog.com, andy@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 08/11] iio: adc: hx711: localize loop iterators in hx711_read
Date: Wed, 29 Apr 2026 21:51:04 +0300 [thread overview]
Message-ID: <afJTGNyemUtqxvDD@ashevche-desk.local> (raw)
In-Reply-To: <CALoEA-wjVgbCFAKJ7TNHLWWYKYdFDBMsvs7MH1LhWepVhLBg4Q@mail.gmail.com>
On Wed, Apr 29, 2026 at 05:01:35PM +0200, Joshua Crofts wrote:
> On Wed, 29 Apr 2026 at 07:48, Piyush Patle <piyushpatle228@gmail.com> wrote:
...
> > - for (i = 0; i < 24; i++) {
> > + for (unsigned int i = 0; i < 24; i++) {
>
> Might be a nitpick, but wouldn't it be better to have a macro or a local
> variable for the 24?
If so, should be a separate change. For now I don't mind to have it like this.
...
> > - for (i = 0; i < trailing_pulses; i++)
> > + for (unsigned int i = 0; i < trailing_pulses; i++)
>
> Why is the index unsigned when trailing_pulses is signed (this goes
> for the for loop above as well)?
It's probably me who suggested the unsigned variant. But I agree, better to
follow the type of the (upper) limit.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-29 18:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 5:45 [PATCH v5 0/11] iio: adc: hx711: add HX710B support Piyush Patle
2026-04-29 5:45 ` [PATCH v5 01/11] dt-bindings: iio: adc: hx711: clean up existing binding text Piyush Patle
2026-04-29 5:45 ` [PATCH v5 02/11] dt-bindings: iio: adc: hx711: add VSUP supply property Piyush Patle
2026-04-29 5:45 ` [PATCH v5 03/11] dt-bindings: iio: adc: hx711: add RATE GPIO property Piyush Patle
2026-04-29 5:45 ` [PATCH v5 04/11] dt-bindings: iio: adc: hx711: add HX710B support Piyush Patle
2026-04-29 5:45 ` [PATCH v5 05/11] iio: adc: hx711: move scale computation to per-device storage Piyush Patle
2026-04-29 18:41 ` Andy Shevchenko
2026-04-29 5:45 ` [PATCH v5 06/11] iio: adc: hx711: introduce hx711_chip_info structure Piyush Patle
2026-04-29 18:44 ` Andy Shevchenko
2026-04-29 5:45 ` [PATCH v5 07/11] iio: adc: hx711: pass trailing pulse count into hx711_read Piyush Patle
2026-04-29 18:53 ` Andy Shevchenko
2026-04-29 5:45 ` [PATCH v5 08/11] iio: adc: hx711: localize loop iterators in hx711_read Piyush Patle
2026-04-29 15:01 ` Joshua Crofts
2026-04-29 18:51 ` Andy Shevchenko [this message]
2026-04-29 18:49 ` Andy Shevchenko
2026-04-29 5:45 ` [PATCH v5 09/11] iio: adc: hx711: pass iio_chan_spec to hx711_reset_read Piyush Patle
2026-04-29 18:54 ` Andy Shevchenko
2026-04-29 5:45 ` [PATCH v5 10/11] iio: adc: hx711: split hx711_reset variable assignment Piyush Patle
2026-04-29 18:55 ` Andy Shevchenko
2026-04-29 5:45 ` [PATCH v5 11/11] iio: adc: hx711: add support for HX710B Piyush Patle
2026-04-29 19:06 ` Andy Shevchenko
2026-05-04 15:56 ` Jonathan Cameron
2026-04-29 19:08 ` [PATCH v5 0/11] iio: adc: hx711: add HX710B support Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afJTGNyemUtqxvDD@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=ak@it-klinger.de \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=piyushpatle228@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox