Re: [PATCH v5 0/11] iio: adc: hx711: add HX710B support

Andy Shevchenko
2026-04-29T19:08:42Z

On Wed, Apr 29, 2026 at 11:15:33AM +0530, Piyush Patle wrote:
> Add support for the AVIA HX710B ADC, a HX711-compatible converter with
> the same GPIO interface but a different channel-selection model and a
> fixed gain of 128.
>
> Compared to v4, this series is split more finely to match the review
> boundaries requested during review rather than because the feature
> itself grew materially:
>
> - the DT binding work is now split into cleanup of the existing HX711
> binding, HX711-only VSUP documentation, HX711-only RATE GPIO
> documentation, and the HX710B binding addition
> - the driver refactoring is now split further so the trailing-pulse
> parameterization, loop-iterator cleanup, and hx711_reset() declaration
> cleanup all stand alone
> - the Kconfig help text, file header, and MODULE_DESCRIPTION updates now
> sit adjacent to the final HX710B support patch instead of appearing in
> the middle of the refactor sequence
>
> The resulting series is longer than v4, but each patch is narrower and
> maps more directly to the requested review boundaries.
>
> Tested on PocketBeagle2 with an HX710B breakout module. The device
> probed successfully, all three channels returned stable raw readings,
> and alternating reads confirmed channel switching between the
> differential input and the DVDD-AVDD supply monitor path.
>
> Build-tested with:
> - make -s W=1 drivers/iio/adc/hx711.o
> - make -s dt_binding_check \
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml
> - pahole -C hx711_chip_info drivers/iio/adc/hx711.o
>
> pahole reports hx711_chip_info as 40 bytes with no internal holes. The
> remaining 7 bytes are tail padding from 8-byte pointer alignment.

This is almost ready-to-push series. I have a few nit-picks here and there,
most important ones are the patch organisation (splitting) and the question
about new entries in the buffer structure.

I believe next version will be final (but wait until we settle down on the
opens).

--
With Best Regards,
Andy Shevchenko