Re: [PATCH v3 5/8] iio: light: si1133: use guard(mutex)() macro

Joshua Crofts
2026-04-30T07:55:20Z

On Wed, 29 Apr 2026 at 21:20, Andy Shevchenko
<andriy.shevchenko@intel.com> wrote:
>
> On Wed, Apr 29, 2026 at 05:04:53PM +0200, Joshua Crofts via B4 Relay wrote:
>
> > Remove mutex_lock()/mutex_unlock() and goto instances and add
> > guard(mutex)() macro to modernize driver and improve mutex handling.
>
> ...
>
> > if (!wait_for_completion_timeout(&data->completion,
> > + msecs_to_jiffies(SI1133_COMPLETION_TIMEOUT_MS)))
> > + return -ETIMEDOUT;
>
> I believe Jonathan gave you a green light for loner line and properly indented.
>
> if (!wait_for_completion_timeout(&data->completion,
> msecs_to_jiffies(SI1133_COMPLETION_TIMEOUT_MS)))
>
> It fits 100 and hence doesn't trigger a warning in checkpatch (in default mode).

Yeah, it's more of a problem of me not putting patch 6 before this one.

--
Kind regards

CJD