Re: [PATCH v3 3/8] iio: light: si1133: add missing include headers

Andy Shevchenko
2026-04-29T19:16:52Z

On Wed, Apr 29, 2026 at 05:04:51PM +0200, Joshua Crofts via B4 Relay wrote:

> Add missing include headers to prevent compilation relying on transient
> dependencies (array_size.h, bitops.h, completion.h, dev_printk.h, err.h,
> irqreturn.h, jiffies.h, math.h, mutex.h, types.h).

...

> +#include <linux/array_size.h>
> +#include <linux/bitops.h>
> +#include <linux/completion.h>
> #include <linux/delay.h>
> +#include <linux/dev_printk.h>
> +#include <linux/err.h>
> #include <linux/i2c.h>
> #include <linux/interrupt.h>

> +#include <linux/irqreturn.h>

Assumed by interrupt.h

> +#include <linux/jiffies.h>
> +#include <linux/math.h>

Also mod_devicetable.h
*Yes, most of the SPI/I²C drivers do not do that, I know.

> #include <linux/module.h>

> +#include <linux/mutex.h>
> #include <linux/regmap.h>
> +#include <linux/types.h>

--
With Best Regards,
Andy Shevchenko