Re: [PATCH v3 5/8] iio: light: si1133: use guard(mutex)() macro

Andy Shevchenko
2026-04-29T19:20:03Z

On Wed, Apr 29, 2026 at 05:04:53PM +0200, Joshua Crofts via B4 Relay wrote:

> Remove mutex_lock()/mutex_unlock() and goto instances and add
> guard(mutex)() macro to modernize driver and improve mutex handling.

...

> if (!wait_for_completion_timeout(&data->completion,
> + msecs_to_jiffies(SI1133_COMPLETION_TIMEOUT_MS)))
> + return -ETIMEDOUT;

I believe Jonathan gave you a green light for loner line and properly indented.

if (!wait_for_completion_timeout(&data->completion,
msecs_to_jiffies(SI1133_COMPLETION_TIMEOUT_MS)))

It fits 100 and hence doesn't trigger a warning in checkpatch (in default mode).

--
With Best Regards,
Andy Shevchenko