Re: [PATCH v2] ASoC: tegra: Add per-stream Mixer Fade controls

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1038 bytes --]

On Thu, Apr 30, 2026 at 03:12:08PM +0530, Sheetal . wrote:
> On 30-04-2026 11:29, Mark Brown wrote:
> > On Wed, Apr 29, 2026 at 07:06:03AM +0000, Sheetal wrote:

> > Also is there any overhead to having the sample counting enabled?  This
> > is the only thing that turns it off AFAICT so if userspace doesn't look
> > at the control we'll just leave it running indefinitely.  Perhaps a
> > timer to disable might be useful?  It's generally a bit odd that we have
> > a write to the hardware in a get().

> Rather than a timer (which would require sample rate tracking to convert the
> sample-based duration to wall-clock time), sample count will be disabled
> before re-enabling it in the put callback, ensuring the counter restarts
> from zero for each new fade. Does that sound reasonable, or would you prefer
> a different approach?

It depends on how important it is to do the disable - if there's no
real need to do it until the next fade that's fine, if there's some cost
to having it run then you might need something more active.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]