From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, yung-chuan.liao@linux.intel.com,
pierre-louis.bossart@linux.dev, peter.ujfalusi@linux.intel.com,
niranjan.hy@ti.com, kevin-lu@ti.com, baojun.xu@ti.com,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com
Subject: Re: [PATCH v2 2/3] ASoC: SDCA: Remove sdca_function_data duplication
Date: Thu, 30 Apr 2026 13:03:06 +0100 [thread overview]
Message-ID: <afNE+oHIuS4vhufG@opensource.cirrus.com> (raw)
In-Reply-To: <afM1ImzBB5lsueUa@sirena.co.uk>
On Thu, Apr 30, 2026 at 07:55:30PM +0900, Mark Brown wrote:
> On Thu, Apr 30, 2026 at 11:21:19AM +0100, Charles Keepax wrote:
>
> > /* Parse the function */
> > - ret = sdca_parse_function(dev, peripheral,
> > - &peripheral->sdca_data.function[i],
> > - function_data);
> > + ret = sdca_parse_function(dev, peripheral, function_data);
>
> What sets up function_data->desc here?
Ah shoot, thanks again Mark. Sorry about that I will do a new
spin and try to be a little more careful. Overlooked that this
driver doesn't call sdca_dev_register_functions().
Thanks,
Charles
next prev parent reply other threads:[~2026-04-30 12:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 10:21 [PATCH v2 0/3] Improve SDCA support for duplicated features Charles Keepax
2026-04-30 10:21 ` [PATCH v2 1/3] ASoC: SDCA: Add correct masks whilst reporting SDCA jack status Charles Keepax
2026-04-30 10:21 ` [PATCH v2 2/3] ASoC: SDCA: Remove sdca_function_data duplication Charles Keepax
2026-04-30 10:55 ` Mark Brown
2026-04-30 12:03 ` Charles Keepax [this message]
2026-04-30 10:21 ` [PATCH v2 3/3] ASoC: SDCA: Support devices with multiple functions of identical type Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afNE+oHIuS4vhufG@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=kevin-lu@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=niranjan.hy@ti.com \
--cc=patches@opensource.cirrus.com \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox