From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42FDB410D24 for ; Thu, 30 Apr 2026 13:04:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777554286; cv=none; b=ooGmFw8AazUQYbF3XyZ4JBYnCoi4O2jfHIAbRfFzyCiX+9jcWN8rKFjSWX2CVC0WowpUP422YBKnhuzaN84MaWG/5DtB8QR8lvRFc04LD3jik4w1MQcBGFP1wblP2uF4Hzq2LmsRfBEwgdfWbN3+V3lUjWRo+JNlZ3jZMdQ7mZo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777554286; c=relaxed/simple; bh=b/mU9pLCueemnrynx1ZTyDRvhhGAyWh1g7r2YTe7aAo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UWPwULpw8Rvd5WPHqOm5ues63BPCgVvDtCwVjTbxApyi3ucAjAlHsZYASIYcgxw/eVbeknT//gJRRGCZAMTvT4k2CWoAqriYrgvaQw3uUM+bO2huSwe36yNcgBa1U4M9S6LeKx5C8uUTpFGAYdhW0bAGNkdpXG9h2P4FWgXBoKI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Ah/13FGB; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Ah/13FGB" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4890d945eb4so12350245e9.0 for ; Thu, 30 Apr 2026 06:04:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1777554284; x=1778159084; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1EfeWATGG5daetRgYzHsxFq0y2r373pWgwQp49kZAEc=; b=Ah/13FGBZoU3lCiCBGOcANAfNy5QFfY4ZrZ80tcLGjm/rZ0XBb4NE7BhmXi5BdXu0D 6bdMzV/QOWqCgIePKCuLsA5zaSjyy9q7yPC9a3iEd5JhLy2dME5ETsGhmKgjycgIo6Q0 ffXbd7ZCxzdJw3jYlacQ78tZQIBrz76PuygygSvIP5zZ/gzo9QJu9dx5apJzqyaf5m0/ E7dCZiElXuSEXz1ALi028HJdz5fHt9Nv8QaIcWAImgDeCaLvd0VXEX6rQHoudMvxFnfJ ZCjGBMvwIaMLc3o73F0gUXtpbRJayxHrrXzgNboHItoX+5o2WsOGKgN1K4dqvhuNN+MG NqFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777554284; x=1778159084; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1EfeWATGG5daetRgYzHsxFq0y2r373pWgwQp49kZAEc=; b=Lv6qzI7GqLF7APJmE6FOc46upSaEZvw7YZxX5vSGa7q6UzWW3K0ewLfEz0+jokaDKK 908mIo2tHlGaMHeqT+ebKNXf327I/8J8QqRmLbQm64SRIgrCDgJ4kSD1sAnQqtTDySY9 dFlJ4mY7HNh9/sPj3vtkZmfNFav2tba44HkJCOgGNumZpFE6BqpJ+pkmUn6coFCaIc/v fEAJQuDfrtM49btOBxXv/dOD7VhLqa0DW+/v/jUm4t8AKKO/ttZMdu5fLcKBxWBjjrCe o0IO595Pn57o7DFIVhaRqO7L5vozVCWOdrc/HIPNUXj3ggJuyXaDjOZorLYoA7c2ppV3 8euA== X-Forwarded-Encrypted: i=1; AFNElJ+HJQuJ2jLSbTTpF1uroS4las34461T9lC7b+QDPii+e4kr3BNzoNyYrjNEBL3y1DOZIVMdK+C/8VodjzA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0l131PtwfBYAEwbyEeL5wywc8uGolvfkW88QYzvUVUxLzztIZ xOESi2yJrk8CosZFgz06JEq+Jz/FUuk1BaMJgiGPESBJIHnQbGq1wbyf2gfB7vIOSnk= X-Gm-Gg: AeBDietIIW6xOzCB7E/OoX5wD6MJeTFKl1KK7XRb6CXWndO3EXzk7OQb5dokFfkaMXg o/uvtjxM3BYVInUgR4t9jifxk8a36YIPA02Ypxh/45Z6PDuj7X2sJc3UbEFBXTeGJWYC54e+l5k QUEYdUXrbNJ6AxEKM4Zz8ajz5C3Ej3e/u7IrhdqUiqiLptzS6KC88/Vb/IWACaUzDTdnN72/JpP Ct4XuC6cRPsr0m7eKjHS5Jo/JCvmDVSUengaLnUe5MWM2iEHXfwMM5M+BcqzjM/mE5UjAhQ9CgO 9oPg12zrPqgUQGzx8JbBqVVcq9L4CJByWWqqWAIj7Ko1xGSDOEtveIUlhmgnLGZ/yavsTf3A76e YrLpTyDjPOLQeiua20M9FkRi80O9EvPxGQ6PEQLhU/2VekaN3tFvQys0E3XVPACkGkY6ROREK4O XnclUYen1sr8FeY4kFKOrt8wRmu04GHDsQb+WmsaICC2DxUS8= X-Received: by 2002:a05:600c:548d:b0:48a:534a:eed8 with SMTP id 5b1f17b1804b1-48a85e17294mr36683365e9.1.1777554283392; Thu, 30 Apr 2026 06:04:43 -0700 (PDT) Received: from localhost (109-81-16-145.rct.o2.cz. [109.81.16.145]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a7b92a0cfsm44017245e9.10.2026.04.30.06.04.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2026 06:04:42 -0700 (PDT) Date: Thu, 30 Apr 2026 15:04:41 +0200 From: Michal Hocko To: Nyunwoo Kim Cc: David Rientjes , Shakeel Butt , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/oom_kill: Insert newline for better readability Message-ID: References: <20260430125321.5679-1-knw0507@naver.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260430125321.5679-1-knw0507@naver.com> On Thu 30-04-26 21:53:21, Nyunwoo Kim wrote: > Insert a newline in check_panic_on_oom() for better readability. > > Signed-off-by: Nyunwoo Kim > --- > This is my first patch and I am using it as practice to learn kernel > development. If this has wasted your time, I apologize; it was unintentional. > Thank you for your consideration. Patches like this are not adding any real value. While aiming for a better readable code is a nobel goal I would recommend adding clean ups like this one to other changes/patches that are improving the code (either fixing existing bugs or making the overall code much better). Thanks for trying and keep looking for something that might improve the code. > > mm/oom_kill.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 5c6c95c169ee..86a08deaa697 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -1076,6 +1076,7 @@ static void check_panic_on_oom(struct oom_control *oc) > { > if (likely(!sysctl_panic_on_oom)) > return; > + > if (sysctl_panic_on_oom != 2) { > /* > * panic_on_oom == 1 only affects CONSTRAINT_NONE, the kernel > @@ -1085,9 +1086,11 @@ static void check_panic_on_oom(struct oom_control *oc) > if (oc->constraint != CONSTRAINT_NONE) > return; > } > + > /* Do not panic for oom kills triggered by sysrq */ > if (is_sysrq_oom(oc)) > return; > + > dump_header(oc); > panic("Out of memory: %s panic_on_oom is enabled\n", > sysctl_panic_on_oom == 2 ? "compulsory" : "system-wide"); > -- > 2.25.1 -- Michal Hocko SUSE Labs