From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDC44388E77 for ; Thu, 30 Apr 2026 20:00:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777579243; cv=none; b=BVerdvSGo+6r6JJWB53EsNpHVH/MQcNI9sOM1BAqesidYxdtRA41AqUlptOd/vN8H95PAOPNwdoD+jFvcch9DGvZbCaMXLLi+dvl5xm3MkrJu6Yc1GDBUNkTpKYZgsE5ywwKI+/XNED6nlmSrg4ShabuTSqahdkKAZYV8zB7MPw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777579243; c=relaxed/simple; bh=oqKXKlm6wYMmuyYmNyuWvqeT7CRSh4QUaJek0Uj379E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cirkxcib/x3XxDElJI99d8up1zxfOVWfPekKAg7vr06Y1agbAb1SDLY+1CalUoJqIRCk6WOMjlKe7Ny5R96XxUzULw5uemg35mHoQwXClphGEDBqgRm2enmzvgYJ8pwASxMqZMR3Q/ElIHZjTZ4VF6diBQN0Bi4q6sPn/h2UYmg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=n2vmEcu9; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n2vmEcu9" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4891e86fabeso16658665e9.1 for ; Thu, 30 Apr 2026 13:00:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777579240; x=1778184040; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=v0+yTsXt/PCHfrBu1YrbRJLXz84iGqApbjKG4zjSc2I=; b=n2vmEcu99rDDr1Pk4hom7WcHtR6Z5iy+IWyAi12ssQFCoAvHLl5UzKjEi3/2mk3Ukm z0qW4kOMQab5TqAzDqpWv8WiVHe98BO5ZPG4Ra9oP8z+lS98thTp62sQSn+FHrhcayPA Y/TK6B/OXIIlxwuFtn4eL+HrEixI8OkC8YGSAz5P0/Qs4UYZLjhAo4JH03sheujK/qZS jCkmMwjDH1w4GBjIiQ7+j8EE4ZjVbdn6zFBqJexwFHsvpkuCQIWiW8kLwHhMJ7ZO2TNP B9N+0OdJE93xsYki5capcQiGTCRoH4tWk8Z0WaHvEcZ6VMjX45EgnRkCVDQsCFwiwF91 YPfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777579240; x=1778184040; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v0+yTsXt/PCHfrBu1YrbRJLXz84iGqApbjKG4zjSc2I=; b=PK19BNVsEU4J9NdvF4efA2vWwErH72moN6KavGveJQ/hBSkmy39lRzsKYNLAdyHEl+ g8Jarwng0mVJdwWyIzpFxlclcgJxzdGfOzhX++DIiAe17g6YHRk+by+rn+RZ/8Kwtmq6 vKJlwfoRlSfbOnzBExz6EeG1H8f2f9fmPwxJiCrecJDWZPwOJhQEvifMrtvf+DzPihhs ui82tu4E1GzyD0BwisOVuPjHdiXhRtnc1Abu0b7kSNa+n8sajpEjAH9XWq0ap89ksDz8 z2YlpauA46wKsALY5AqfU5gUhqBfAMSkBbx0aOf+maeL5CPgOl8xQglDOEkynWeG8XOe 8maQ== X-Forwarded-Encrypted: i=1; AFNElJ9Nu7FwKR7YUcQaHiA19t7dkXcnqXzEfbvxHo6UIcSXM43RmvpinywAy7syQOtSD6Bipwxfcx9DlfLOSpE=@vger.kernel.org X-Gm-Message-State: AOJu0Yyol/zTS4QAWJOqQFY+B8LUiqQlFOhp43gHrVO7NWxa6IxSsaJn 1pHSZVmTZ5lJon2o0GzT4F9Ol+eKcan0RlbesJQRGenBJViSxU32EJBa X-Gm-Gg: AeBDieu2x++CfN2D8XRYqUSzu4MgB8xvz7CWEktUrEU7wZ7xRIjasRM9a4N34PIFTpt +uwhWiZFs9iVBLZm1BFqhmi5sDU8Qjn8L1yzcaCqiH4VMhFaFSR8S7MWTl6IwzNVn05ICVearvd ANc1FS2mKEym6+7mh7OhP1DKQn+fEIaG7NaL7yONNWte/vThe7h8aLeY3J1VMtb4BXrMPFTrw03 PgyTnLEMCyfdhC66/zxwDqkyxoQZFPw9JXC6GYjF3EHqcN8Cm64PaZsxLQIok+W+DZRJjnM4oRG iNtHvz5fGh7z3HcJQo+2gARj8w8/8nITHVyUN7M7JzJ/jKvoURPfJ/PqoUID2mglQLB+0MA35p+ EPK1yvj/G1jPTCHSx7pzQNTBtOiAqkRpwGl4XE/sUDbeat6TDdfJUF6plDHsXsco5qSnDf3w8cN VujODVwTHBaVmxNJiAhfAasZI7wcBCRjX8LG5Q83f9V2V58oo0HZ0GTjTG3jng9vnMDEH+ X-Received: by 2002:a05:600c:8b22:b0:485:3a03:ceca with SMTP id 5b1f17b1804b1-48a844582c3mr75430765e9.23.1777579240148; Thu, 30 Apr 2026 13:00:40 -0700 (PDT) Received: from osama ([2a02:908:1b6:8980:55a4:d495:8d6f:1416]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a8ebb3dc1sm3019145e9.14.2026.04.30.13.00.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2026 13:00:39 -0700 (PDT) Date: Thu, 30 Apr 2026 22:00:37 +0200 From: Osama Abdelkader To: Luca Ceresoli Cc: Peter Senna Tschudin , Ian Ray , Martyn Welch , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Archit Taneja , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3 3/3] drm/bridge: megachips: remove bridge when irq request fails Message-ID: References: <20260423200622.325076-1-osama.abdelkader@gmail.com> <20260423200622.325076-3-osama.abdelkader@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hello Luca, On Wed, Apr 29, 2026 at 01:48:33PM +0200, Luca Ceresoli wrote: > On Thu Apr 23, 2026 at 10:06 PM CEST, Osama Abdelkader wrote: > > If devm_request_threaded_irq() fails after drm_bridge_add(), remove the > > bridge before returning. > > > > Keep drm_bridge_add() rather than devm_drm_bridge_add(): registration is > > tied to the STDP4028 device while ge_b850v3_register() may complete from > > either I2C probe; devm would not unwind the bridge if the other client's > > probe fails. > > > > Signed-off-by: Osama Abdelkader > > Fixes: a68ee76f4a28 ("drm/bridge: megachips-stdpxxxx-ge-b850v3-fw: Fix bridge initialization") > > That commit only moved the bug to a slightly different location. The bug > was present even before, since commit fcfa0ddc18ed ("drm/bridge: Drivers > for megachips-stdpxxxx-ge-b850v3-fw (LVDS-DP++)"), so you should update > your Fixes line to point to it. Updated in v4, thanks. > > > > Cc: stable@vger.kernel.org > > --- > > v3: add Fixes and Cc tags > > v2: IRQ failure path only (explicit drm_bridge_remove) > > --- > > .../drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c | 16 ++++++++++------ > > 1 file changed, 10 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c b/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c > > index c9e6505cbd88..2d02cc69f237 100644 > > --- a/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c > > +++ b/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c > > @@ -251,7 +251,6 @@ static void ge_b850v3_lvds_remove(void) > > goto out; > > > > drm_bridge_remove(&ge_b850v3_lvds_ptr->bridge); > > - > > ge_b850v3_lvds_ptr = NULL; > > out: > > mutex_unlock(&ge_b850v3_lvds_dev_mutex); > > @@ -261,6 +260,7 @@ static int ge_b850v3_register(void) > > { > > struct i2c_client *stdp4028_i2c = ge_b850v3_lvds_ptr->stdp4028_i2c; > > struct device *dev = &stdp4028_i2c->dev; > > + int ret; > > > > /* drm bridge initialization */ > > ge_b850v3_lvds_ptr->bridge.ops = DRM_BRIDGE_OP_DETECT | > > @@ -277,11 +277,15 @@ static int ge_b850v3_register(void) > > if (!stdp4028_i2c->irq) > > return 0; > > > > - return devm_request_threaded_irq(&stdp4028_i2c->dev, > > - stdp4028_i2c->irq, NULL, > > - ge_b850v3_lvds_irq_handler, > > - IRQF_TRIGGER_HIGH | IRQF_ONESHOT, > > - "ge-b850v3-lvds-dp", ge_b850v3_lvds_ptr); > > + ret = devm_request_threaded_irq(&stdp4028_i2c->dev, > > + stdp4028_i2c->irq, NULL, > > + ge_b850v3_lvds_irq_handler, > > + IRQF_TRIGGER_HIGH | IRQF_ONESHOT, > > + "ge-b850v3-lvds-dp", ge_b850v3_lvds_ptr); > > + if (ret) > > + drm_bridge_remove(&ge_b850v3_lvds_ptr->bridge); > > Why not just using devm_drm_bridge_add() and keep everything else clean, as > you did in other patches in the series? Because registration is tied to the STDP4028 device while ge_b850v3_register() may complete from either I2C probe; so devm would not unwind the bridge if the other client's probe fails. > > Luca > > -- > Luca Ceresoli, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com