From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12D6B3890E4 for ; Thu, 30 Apr 2026 20:02:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777579329; cv=none; b=X6OfBS2V6YkUqrvjLwkPVC9+6PFy1ddMnjwUFqjQAtjn5Za2EeErl83KYcMQc7oU2l4F3mI0jIA0nMXStJVIkFzm+qaUa1VUlmI6CGXdx2I0lyPfb/C+Szlc12QclFSawjxw1CPKK/unzk5ObiSbeO0gbHftk+pB+BMPSF0Td6o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777579329; c=relaxed/simple; bh=ZHuLHxqB6LjVFXQ9mqBXp/R0a/Y126DJlp/s4KAJlzE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CQaCMofyhsTwHt2B9vQqy0kUy9hGBPwPElSq56Tn8Jse4Va6OXk+gUE2gnAQcKYVZDTFBckLgoRlcs9shjspkruU2sdcVzdZedAYSbgqf8oYmwxXQ9soA1mPUVElYe2Tj5HmTSGhegQHEyrFuSnlhRd8KmUsx2zQnDokplcZN4Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=q5LLQ8Xu; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="q5LLQ8Xu" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-488e1a8ac40so13176105e9.2 for ; Thu, 30 Apr 2026 13:02:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777579326; x=1778184126; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=35CpLK8dF17epUVO+7XXTbPPO+g9vsXIfv1w96oRvMw=; b=q5LLQ8Xu8hpsyAkiXl4fF1q7ZmYXRUVkBnhYSufwzEVvlqivXqGA0hJayffWHdnoqH rUc1STxVyuH1KdqJrxeyVH/7zyz77B84TgrKnDQCvTIfWs9lm83qqD18RetOqiKiltU/ qbIImRLd3J6OxuEoPGfDCYzAu/dIdx+i67ayqlDN7zMIxKU6Xh1b4CGhJ6w+WNuZmEAp D0vfkX2/UH9o6MZMx7RH4CprCqQHggS54RtMEwuB/Tav9sMAJZqnIf9brg4NHniFhKZT yOshRsPSukEPZzbpiA+XR1953HbiyRFLxjsxf41l4VQ7C85iy2S35JM2uEogtknimZ1c xMfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777579326; x=1778184126; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=35CpLK8dF17epUVO+7XXTbPPO+g9vsXIfv1w96oRvMw=; b=ELJJibCqPK19tGlwR9HzLLG63jlBlkwg9Xz0HBBROW1nzpLTtmzp1jCdJmv6B0dwbi jXG7O2qvX5kNsFf0qrq/RiK0CFzIUzMYM1WGKm8SJQavG+Lqt4rgv6HQRe/1ziPLcHal YYCFtJ2zwFgWFVp3DCRwCOAwLlU0c4TTCTb/jxGiq/BlOkZg/XhSbyRbOOwenu5xlkh3 nqYiNBaMuEeyVGofpStQkZMww0tPODcD7Ob65t95KzfftGHB99C403l5vD1d+6q9YHdo ksicVdu7MLjBcliN+hoVkJQXNjfDYGj7JTGHtPOyIh6gEloS8MvkomiLCnP2L2L6LiAq oRDA== X-Forwarded-Encrypted: i=1; AFNElJ9WooaMO1pbhcs77qBfSBP2VCCVU/RJl7JgPDGxRL645xViQAEhguiMEWChgyvG1zm+xnTbRTZ13spUaqA=@vger.kernel.org X-Gm-Message-State: AOJu0YyRSyNUzD4XVqTh/sCxtyhfVf+zpz12qpeAPROxRFr9SIBblHuP 0LA8/qtkioLlu22YluxUcTmBd8rVum1KeqJ6jcAP/t9H3gUUQtk3aOTN X-Gm-Gg: AeBDietAAt5Z+pYuDM0L3nVnEFx9exqaMWkRjznVXJ9cwLmqWc53JU6kcJKFstEeNk6 gSE2epuXrr8wElm/J0VhJ7CO7P1ssvCjinDU10Jk/OMSeBeKzfYIxgLcJOhbW5BwGrNiX+p9hic xilye923Eqw350/ckG5M683I+2oiwVMRse0nBI7cDdeAHz+14AZVviRP79huTjNgFV2KkRmNxN6 MSNi1d2lBEARWT71H7/o5XIeQyUDsUt57UfAG+aQpnF9QsFkYuV9eWxiQTlnOTrN65GDdS/ryTR UICP/UYvHhv133LOZLBtRpu+jkYRG2GyR+EI7ddFNcg94bsVo5I6Tbq/XtSz0XwaCQbN9LyD3mZ 6EypRk/3KCM9nWmUmF8QO6doFDc11G3LGcIOKJs+lHu+c1M+PzHGc9pBYK+zIp4b3RBiUd+iUoq Szd4om48QS4UPwzlGmoVcCww8gmbxu0xokxFE4IxJ+zsmYLc+KfpL35pwm/LxQwcVA0cat X-Received: by 2002:a05:600c:c174:b0:48a:563c:c8e2 with SMTP id 5b1f17b1804b1-48a83d66ba9mr71345655e9.3.1777579326206; Thu, 30 Apr 2026 13:02:06 -0700 (PDT) Received: from osama ([2a02:908:1b6:8980:55a4:d495:8d6f:1416]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a8eb72184sm1003145e9.32.2026.04.30.13.02.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2026 13:02:04 -0700 (PDT) Date: Thu, 30 Apr 2026 22:02:02 +0200 From: Osama Abdelkader To: Luca Ceresoli Cc: Jagan Teki , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Marek Vasut , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3 1/2] drm/bridge: chipone-icn6211: use devm_drm_bridge_add in i2c probe Message-ID: References: <20260423200546.324187-1-osama.abdelkader@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Luca, On Wed, Apr 29, 2026 at 01:40:39PM +0200, Luca Ceresoli wrote: > On Thu Apr 23, 2026 at 10:05 PM CEST, Osama Abdelkader wrote: > > Use devm_drm_bridge_add() so the bridge is released if probe fails after > > registration, and drop drm_bridge_remove() in chipone_i2c_probe. > > > > Signed-off-by: Osama Abdelkader > > Fixes: 8dde6f7452a1 ("drm: bridge: icn6211: Add I2C configuration support") > > Cc: stable@vger.kernel.org > > --- > > v3: split the patch into two, one for i2c probe (bugfix) and one for dsi probe, > > and add Fixes and Cc tags > > v2: devm_drm_bridge_add instead of drm_bridge_add > > --- > > > > drivers/gpu/drm/bridge/chipone-icn6211.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c > > index 5bee10c64265..4d76e1bd5e78 100644 > > --- a/drivers/gpu/drm/bridge/chipone-icn6211.c > > +++ b/drivers/gpu/drm/bridge/chipone-icn6211.c > > @@ -758,12 +758,12 @@ static int chipone_i2c_probe(struct i2c_client *client) > > dev_set_drvdata(dev, icn); > > i2c_set_clientdata(client, icn); > > > > - drm_bridge_add(&icn->bridge); > > - > > - ret = chipone_dsi_host_attach(icn); > > + ret = devm_drm_bridge_add(dev, &icn->bridge); > > if (ret) > > - drm_bridge_remove(&icn->bridge); > > - return ret; > > + return ret; > > + > > + return chipone_dsi_host_attach(icn); > > + > > } > > > > static void chipone_dsi_remove(struct mipi_dsi_device *dsi) > > This patch does not apply. Is it messed up with patch 2/2? > The file was changed on upstream in the meanwhile, so I refreshed my patch. > Luca > > -- > Luca Ceresoli, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com