From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45ACD287503 for ; Thu, 30 Apr 2026 20:03:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777579397; cv=none; b=iNQuOWne+FaC6JyPI11pF+cA2h8J5/u7he0QqFrd00puY+SZ0H7QyVvSgY77iCDXGcCk+PLAJBOmrdqvdvxyT3esXhRzRX1fhTB5Xz1RAhLAfIIoo2stK/5MaHYzfQLkL7iMrqAaPU6/NAl6EYYYaQC7RXCJCr3n+4ssSJj/pVM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777579397; c=relaxed/simple; bh=OMhj4KtBEweiZfCsDoKi9jw+mxeHTJ4lPE2vJZzuD68=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IjzEXXUBteNVJH/O+/bk7vwGvbRYYt1tbqOtcPe3ZXO+Ah3iEkqKtENbz4soELRX0OY6zmf+fXtU9qYkrGIkxkvm+xo7yNjw1Yeyoh2w8y67pzjJk61L5t+Aw4vhdckqbRBmWdG1kHxcPDq8K/XhtT4aCfEG1Se7bhcnd7Blefg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kH+csqPk; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kH+csqPk" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-488a9033b2cso12493585e9.2 for ; Thu, 30 Apr 2026 13:03:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777579395; x=1778184195; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hW4vHMMUnbyMXFRxshaPjNall3Xr6KHgzmKn/VB3uNA=; b=kH+csqPk8ky3o8IlQI+HMGuIazEoMjJkRC/9UEPV17YZ2yhqu0F5jUC5uoAe+MctDO 2cLPx3OeLBSJfTcNZF00NbN+/fyq9Lz9F6f2WuuRHUxb4qqL4u1Ved2387pVeESAzgMb bbHY4GkiHbxhWzWj6oWWZ5I0UCKSzGCzgNqO1HEXoYq7q7dPorNYcpkuvdfqXLyHT7VB J21Y+8k5oASgNv65gHbDT9+1mXfqXuvYdw2opb9uKZ9kMngYiSzpCARzdXr4VoSEY4DM 2aTX7fV2s/1YtJ0dZ+2mqVWcy5ChWZz79Uc3DF34r2TIq6i9myjjmYDP36N56Pl6N849 EXOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777579395; x=1778184195; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hW4vHMMUnbyMXFRxshaPjNall3Xr6KHgzmKn/VB3uNA=; b=E0e6/fm6UhIMFkxWL2DwtJGArJ+Nw2xGqIe9tND95lQCQoceX/K981zHYgapPKCjHt DH6U5CazS4nD/95C+/z845LW6HiyQgd/xC8jx+8jUgznFuENk7x0jUqEsHn+yyB3mWXr cadjoCGUna6EcFzZM2p9BpZPkf4IeGl08bB0paCOT5w81N5XJgnC0kPByZdw8wNqpsBe XqMWnuBG+QDjGAUjjw+mwTu9i5w26Hbl5miu9wzYWFJi/yf6GRFxvukUZSjjPR/m3O2r GdG8kGMpPCvX1ZjMsGvknxWTXYI2M19CaJRX+10LFhxCxE4H0mGGfG4k49uh1RgZ7wYY 5VRw== X-Forwarded-Encrypted: i=1; AFNElJ8mBKOcQr37T+5BeVFH28efE6BAwbMtBy1SEzQGGGDOMPYqULDvwTOqwzeTuKJYP8B3i6ElhPUR2rIh8KM=@vger.kernel.org X-Gm-Message-State: AOJu0YzURdzXFD2qtkRkRvCW7Rr+qtqxlEnP/IMCrTP6VU2xhp6Kc2t2 wqANyrGleTFkFo3ZvlrM/LDZfZSz33DHN3s0irm8JiecKX/r6DmITVYy X-Gm-Gg: AeBDieuMOQJNEH5JQjJXyDNWIqAU2RnTh6ogR6UwYwuejjOo82Y+KqqBdQAr/BM7a6S kNodOxTyiuozDuxJqvnCCk/uXCOsBnUQjiTfUCxdBf7B9JpKMAfmfy1xpod405NI0FFzYVh8FY+ FSh9e+yTPIgmqx0faDnJIpAbcOA8xd/Tzbop1GjOJrEQ2cvy1jRYVFOz6JiDrCs+VqCm9bEYQTU 1UmU0Pzk2m50D4Y20fohO/Vcv3CLE1H1CtLzZgZZZ2vb4mf+y4C8nQQyeIixgvYDfgnMwop9mRv hfPDN2eY9ejyMymWGWXkgx2fFNHrv7HROQnmERzu3I0UYiN1nIH4ktX1xUx/xqo0y8APTlqVWHT +rH61LfcwJ3EnNfZuns6Yuk8NJh5jIWzfHBY2v/ry9j6QrJUBIeOOH0sdNEwVE4XgygmRJBfkxG Wejai6C7uI0eCCBRXLcF6W0A6YTedazInSExRA52pj+lnCXRYMHQXt7nHkTvfy8J9nKTNOQMaB9 wSMoQw= X-Received: by 2002:a05:600c:c118:b0:488:c744:49b with SMTP id 5b1f17b1804b1-48a8eb6b027mr1935865e9.7.1777579394535; Thu, 30 Apr 2026 13:03:14 -0700 (PDT) Received: from osama ([2a02:908:1b6:8980:55a4:d495:8d6f:1416]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a824f9f0dsm82432745e9.15.2026.04.30.13.03.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2026 13:03:13 -0700 (PDT) Date: Thu, 30 Apr 2026 22:03:11 +0200 From: Osama Abdelkader To: Luca Ceresoli Cc: Jagan Teki , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] drm/bridge: chipone-icn6211: use devm_drm_bridge_add in dsi probe Message-ID: References: <20260423200604.324615-1-osama.abdelkader@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hello Luca, On Thu, Apr 30, 2026 at 01:01:16PM +0200, Luca Ceresoli wrote: > Hello Osama, > > On Thu Apr 23, 2026 at 10:06 PM CEST, Osama Abdelkader wrote: > > Use devm_drm_bridge_add() so the bridge is released if probe fails after > > registration, and drop drm_bridge_remove() in chipone_dsi_probe. > > Wait, this patch must drop drm_bridge_remove() in chipone_dsi_remove() too! > Otherwise it'd be introducing an excess put, and consequent use-after-free. > > I have to withdraw my R-by. > > You can amend in v4. > Good catch, added now in v4. Thanks, Osama > Luca > > -- > Luca Ceresoli, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com