From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67461472760 for ; Thu, 30 Apr 2026 17:26:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777569998; cv=none; b=QSOCSgk60vNqVrUilmCFjCWnZYmCHcnsM9LegmbKsI+TCq3BCg85a3vSmyNXX0/W0uTvFuMyhszbhUWnwejwoYYWKQY6g8sYL8dhdcsftvLcsNq2QU8Jj10RIeJB6sH3dOq01I/QRVIwUIjvvg1m8wr52nr8KHBwfeZNPZ1J4uo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777569998; c=relaxed/simple; bh=aJsmVHcB+0lzAQ5pEFNNihNf9jedINKGpsgKI15N/EM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=anaqeO5I0HQTm5mX3J/nj4Fc7vv8C7IFzOPQqblqkHOXY1VEatAATmk7ybI2iBDlGOnIdm9mUEWVhrwEJUodrgWD7pUAfG2NsArZVfk/WDh5Qk8IewPDGKAD62WrjsRzjkmDqIkFYZAvBHhZZCjYoIPgA/dQFvzhX7ZIJkfRs3c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Bzr1z8vH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Bzr1z8vH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD161C2BCB3; Thu, 30 Apr 2026 17:26:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777569997; bh=aJsmVHcB+0lzAQ5pEFNNihNf9jedINKGpsgKI15N/EM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Bzr1z8vH7Y66Zv1HxbG/WVOK8Tecq40Bdxe5K9yE5o1vABirmpyYBQL4PusuwLga6 K8VvXqnr9MCTtLhdG00wvW5iI6ro+R6HPsA4+oPY/+qnSqkg3tEOfp/1Xf9yVj1l1a wBDlWTKCLPuWc9BEARYjmsJQJBWWb0PH83Yn8jI21jvdGIu+TeKJsCikEJW8twxwRG D4tEIM8NcvjMvwoP7orVqnhtqla0T42Y+kNm6CDXNPMsWIhEwbnWyFKTBhV229SS6X nDlUHVmHcNnyU6HbG1pUgyS6pY1DSje/tiOeoAQTMmrJ+KVcsnQSP4f8UR86BXDR1F EVxV/86iRA2vw== Date: Thu, 30 Apr 2026 10:26:36 -0700 From: Drew Fustini To: MoeLeak Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] riscv: dts: thead: Enable WiFi on Lichee Pi 4A Message-ID: References: <20260426055229.950099-1-i@leak.moe> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260426055229.950099-1-i@leak.moe> On Sun, Apr 26, 2026 at 01:52:29PM +0800, MoeLeak wrote: > Signed-off-by: MoeLeak There needs to be proper commit message with a description of why the change is being made. Please run scripts/checkpatch.pl before resending as this would have called out the missing commit message. Also please review Documentation/process/submitting-patches.rst or visit https://docs.kernel.org/process/submitting-patches.html Please include revision number in the patch Subject: and also after the '---' line in the patch so it is easier for a reviewer to know what changed. In addition, the To: and Cc: fields are missing several addresses per MAINTAINERS. Please run scripts/get_maintainer.pl and make sure to include the recommended addresses. For example: ./scripts/get_maintainer.pl -norolestats --separator="," However, I have been using the wonderful b4 script for awhile now and it makes the above much easier: https://b4.docs.kernel.org/en/latest/contributor/overview.html My flow would be something like: b4 prep -n your-patch-topic # create new branch for your patch b4 prep --edit-cover # creates the cover letter b4 prep --auto-to-cc # this adds all the necessary people and lists b4 prep --check # this runs checkpatch b4 send --reflect # emails just yourself to review before sending b4 send # actually posts your patch to the lists You don't have to use it for this patch but keep it in mind as it can prevent mistakes and save a lot time. > --- > .../boot/dts/thead/th1520-lichee-pi-4a.dts | 47 +++++++++++++++++++ > arch/riscv/boot/dts/thead/th1520.dtsi | 11 +++++ > 2 files changed, 58 insertions(+) I think these should be split into two separate patches. The first patch would add the i2c node in th1520.dtsi and the second patch would make the changes to th1520-lichee-pi-4a.dts. Thanks, Drew