From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D6083AEF47 for ; Thu, 30 Apr 2026 20:49:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777582170; cv=none; b=Qum1MkLES4msRh4la73Tax3lz5+YH/ba7yhHX2DEVM4WZatVuRD2exU+Q5339Judd+tO2UyWheUhxsADRfxNUGyVo6DCH7QDiHiaZ36zh58YlMtlcDWUtYX+ytwoD4jtYRSBQ9oCHuz26ZzqF725P1MfT2deYP8dFmA59b9F8yk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777582170; c=relaxed/simple; bh=TriwdijzsiVRf02t1V40GPDZHZ41X/f0QJSAPNy0VeE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qK0s0k/VJxFGQoSQCPIitTfruwOniA86qXzbRkmSXI3NeTsxjBxsovJahC0j6coGXcn/a3makXL+OB7K9h16GwuR9wTxrybWip6/usjvVSKVDUj7zKgDVTv99akrgHlqVk2HbjlxUZSKbU5SESOSfoU+Oc+OF4K4hMPVInHPids= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=KwOmxEvy; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="KwOmxEvy" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-35da8d037a5so644857a91.0 for ; Thu, 30 Apr 2026 13:49:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1777582168; x=1778186968; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Hkx4tLK7DpveuSLFftKdSSEC4NdhOfO2fjr8Ook6ULw=; b=KwOmxEvyte+LfcgxCDtgju2fh4pEy7DpIrfWtiOGatxhi1TtjaAt3XTnoyphzTEBqA dCXvIzynMUlUtkclGVZLEH5epWtYMOsJUk2eNyxt1/clLRt3m5u+KppV/2dOA7QAFmRL Fo6nhKlogVZ6EBwaeu5A/dencdStoutFY9vdRbgKUKu4WHs8oPcfR0s73ZKXdLE93LTn YSK7mMVJI6sSu0J20d1HPZ06QlkjkdvjYosbxSqHcGE2b9VxBYhxc4fV3sAMvzjVOHqA yQjlamIpe1yreuVx33K9TopCBJ2E9L/42tN7vnnuv92Pe2k5GLTsNLEfyaaN0GbHGMKR N/Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777582168; x=1778186968; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Hkx4tLK7DpveuSLFftKdSSEC4NdhOfO2fjr8Ook6ULw=; b=FQf+F26VFoAhXSAvFs4uw01NZHFqIIY14vCMmUDceexspD8l5/G0UzwSBKze+wzEyh k3uR4p6ZXbewPvQDuiOerdgB0wm0IsNu4DtvQ7ywFGwEVmAl8mGtuXiDTmd4qDmaJ9NY o5d739jiUpmJogweLXtmu8K+Tiwtja3u7kzQUYp+Sy2Mu1+jbe1/0F82bdMfAXSozNUk UNmc3Dq0NNEFS3/3994GO+YvvAPb3ktquGLNJASsm/cz1w3QXhoSFJzbADEb4dwmwrQK 6w1gV8e4GK8NyjNz5h6QwGxsQSzHz1BjIm73AUXmoTwZcr3eQqdIjJu3yJpBQw4S3klr ARRw== X-Forwarded-Encrypted: i=1; AFNElJ/SoFDpOmKTVZD1qDL6gf6rh5jhtN7JD34vCrKakHi5+xx+P+KydjBF/+TxfuEMO5t1YobY7NkEbEVlfsk=@vger.kernel.org X-Gm-Message-State: AOJu0YwtCUFU3dh+km1hDQsle9H8l+NeVTFUXAcvG+a5foSmgpK3we5S W3LXr34sHCug5dun9gKweV4kS9mqhj3q5cZMGur2vSMxtqm1Y3gEBeoFy5p2+qGcEw== X-Gm-Gg: AeBDiesGlTSxS+O5dYL1WKDQf7SmUxxvNoMNSONnI1oXrjtdBJArQPYbobq1cyOKVeK KkhnynN3eepIuxBoF6Gg3eUQavcWvfH0jApvt8gDrV8tDG9zoDLwlP9t1o/XZh4N6p2gCLJO6b9 CWwMWzDCKbGNi6AVD/++KbRFcpw+MkkWBc6YkC6E2P0ju6/hNVp1wCz386+dwlK/VIzVdei2N+Q 6CK0y8qf4D768TvpM3FKlM+S6le/MQmocKqCc7zkSYrEGKAxJgT7R+Isie3WzFPHnULqWi2kZ6t B5/0CFak3+dP7cTp2MuySN8R+fmaldOO3lmMXcC/9s9xQwDHDlmkHuVpcYRClp2Ky/6nSh7MDVd cRCg9U6bO83qvnDJxxm/6QuyE9Bvtzn3nQ1bX+Uf4xzmjqtdPQ1eZQ1C5TGlZ/sIKBojbimrcYf dJBLgqiC4efNDKSkqQ0Ia+EztWtQMEib8T/e5cGFr3ibP57N3+ztkfbp8GYzOZ3gFsmAsKZRsD3 pkV7A== X-Received: by 2002:a17:90b:3e4f:b0:35f:b288:8e4c with SMTP id 98e67ed59e1d1-364c30cb4f7mr4328476a91.15.1777582167388; Thu, 30 Apr 2026 13:49:27 -0700 (PDT) Received: from google.com (76.9.127.34.bc.googleusercontent.com. [34.127.9.76]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-364ec00b094sm307888a91.9.2026.04.30.13.49.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2026 13:49:26 -0700 (PDT) Date: Thu, 30 Apr 2026 20:49:22 +0000 From: David Matlack To: Jacob Pan Cc: iommu@lists.linux.dev, kexec@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-pci@vger.kernel.org, Adithya Jayachandran , Alexander Graf , Alex Williamson , Bjorn Helgaas , Chris Li , David Rientjes , Jason Gunthorpe , Joerg Roedel , Jonathan Corbet , Josh Hilke , Leon Romanovsky , Lukas Wunner , Mike Rapoport , Parav Pandit , Pasha Tatashin , Pranjal Shrivastava , Pratyush Yadav , Robin Murphy , Saeed Mahameed , Samiullah Khawaja , Shuah Khan , Will Deacon , William Tu , Yi Liu Subject: Re: [PATCH v4 08/11] PCI: liveupdate: Require preserved devices are in immutable singleton IOMMU groups Message-ID: References: <20260423212316.3431746-1-dmatlack@google.com> <20260423212316.3431746-9-dmatlack@google.com> <20260427135625.0000413e@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260427135625.0000413e@linux.microsoft.com> On 2026-04-27 01:56 PM, Jacob Pan wrote: > On Thu, 23 Apr 2026 21:23:12 +0000 > David Matlack wrote: > > +bool pci_device_group_immutable_singleton(struct pci_dev *dev) > > +{ > > + struct iommu_group *group; > > + struct group_device *d; > > + struct pci_bus *bus; > > + int nr_devices = 0; > > + > > + group = iommu_group_get(&dev->dev); > > + if (!group) > > + return false; > This may not work for noiommu mode where we could have a null group. > Maybe I can add special case later? Yeah depending which series goes in first. But based on the other thread I am going to drop this patch from v5.