From: Sean Christopherson <seanjc@google.com>
To: Ackerley Tng <ackerleytng@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
David Hildenbrand <david@kernel.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Yosry Ahmed <yosry@kernel.org>, Marc Zyngier <maz@kernel.org>,
Oliver Upton <oupton@kernel.org>,
Tianrui Zhao <zhaotianrui@loongson.cn>,
Bibo Mao <maobibo@loongson.cn>,
Huacai Chen <chenhuacai@kernel.org>,
Anup Patel <anup@brainfault.org>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>
Subject: Re: [RFC PATCH 3/5] MAINTAINERS: Add an entry for KVM's guest_memfd
Date: Thu, 30 Apr 2026 14:33:54 -0700 [thread overview]
Message-ID: <afPKwv1OLXL8gYZp@google.com> (raw)
In-Reply-To: <CAEvNRgEL32Jc_FfKGqYvYJ3WZGz=PnGwwmxviCOHWaDXm6KX-A@mail.gmail.com>
On Thu, Apr 30, 2026, Ackerley Tng wrote:
> Sean Christopherson <seanjc@google.com> writes:
>
> > To better reflect how guest_memfd has been maintained for the last few
> > years, and to prepare for significant upcoming growth and expansion, add a
> > dedicated MAINTAINERS entry for KVM's guest_memfd, with Paolo and myself
> > (Sean) as co-maintainers.
> >
> > List both the KVM and KVM x86 git trees as authoritative repositories, as
> > any given guest_memfd change has a equal odds of hitting KVM x86 or not.
> >
> > Signed-off-by: Sean Christopherson <seanjc@google.com>
> > ---
> > MAINTAINERS | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 89b470db22de..9eceeb6f699d 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -14396,6 +14396,15 @@ S: Maintained
> > F: Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
> > F: drivers/video/backlight/ktz8866.c
> >
> > +KVM GUEST_MEMFD
> > +M: Sean Christopherson <seanjc@google.com>
> > +M: Paolo Bonzini <pbonzini@redhat.com>
> > +L: kvm@vger.kernel.org
> > +S: Supported
> > +T: git git://git.kernel.org/pub/scm/virt/kvm/kvm.git
> > +T: git https://github.com/kvm-x86/linux.git
> > +F: virt/kvm/guest_memfd.*
>
> Should selftests for guest_memfd be added here too?
Hmm, no? I don't think I want to go to that level of granularity for selftests,
at least not at this time. Maybe if we end up with a large collection of
guest_memfd specific, arch-agnostic tests, then we could extend the entry? But
even then, I don't think I want to go that route.
Much of the guest_memfd functionality and testing is in common files and/or
arch-specific code, e.g. a lot of the truly core functionality is in lib/kvm_util.c,
and set_memory_region_test.c and x86/private_mem_conversions_test.c have about as
much guest_memfd testing as guest_memfd_test.c. I worry that adding a selftests
clause to KVM GUEST_MEMFD would do more harm than good, e.g. create expectations
that guest_memfd testing should be isolated and/or be reviewed differently or
something, without actually making it easier to maintain the tests.
next prev parent reply other threads:[~2026-04-30 21:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 17:15 [RFC PATCH 0/5] MAINTAINERS: KVM tweaks and additions Sean Christopherson
2026-04-28 17:15 ` [RFC PATCH 1/5] MAINTAINERS: Add kvm-x86 tree to KVM x86 entries Sean Christopherson
2026-04-28 17:15 ` [RFC PATCH 2/5] KVM: guest_memfd: Move gmem function declarations to dedicated guest_memfd.h Sean Christopherson
2026-04-28 19:26 ` David Hildenbrand (Arm)
2026-04-30 19:07 ` Ackerley Tng
2026-04-30 21:38 ` Sean Christopherson
2026-04-28 17:15 ` [RFC PATCH 3/5] MAINTAINERS: Add an entry for KVM's guest_memfd Sean Christopherson
2026-04-28 19:27 ` David Hildenbrand (Arm)
2026-04-30 19:08 ` Ackerley Tng
2026-04-30 21:33 ` Sean Christopherson [this message]
2026-04-28 17:15 ` [RFC PATCH 4/5] MAINTAINERS: Add David H. as a KVM guest_memfd reviewer Sean Christopherson
2026-04-28 19:27 ` David Hildenbrand (Arm)
2026-04-30 19:08 ` Ackerley Tng
2026-04-28 17:15 ` [RFC PATCH 5/5] MAINTAINERS: Add myself (Sean) as a reviewer in the main KVM entry Sean Christopherson
2026-04-28 19:30 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afPKwv1OLXL8gYZp@google.com \
--to=seanjc@google.com \
--cc=ackerleytng@google.com \
--cc=anup@brainfault.org \
--cc=borntraeger@linux.ibm.com \
--cc=chenhuacai@kernel.org \
--cc=david@kernel.org \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maobibo@loongson.cn \
--cc=maz@kernel.org \
--cc=oupton@kernel.org \
--cc=pbonzini@redhat.com \
--cc=yosry@kernel.org \
--cc=zhaotianrui@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox