public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Yury Norov <ynorov@nvidia.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, Yury Norov <yury.norov@gmail.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-arch@vger.kernel.org
Subject: Re: [PATCH v2] bitops: use correct parameter names in kernel-doc
Date: Thu, 30 Apr 2026 20:11:26 -0400	[thread overview]
Message-ID: <afPvrowTHUHGdtle@yury> (raw)
In-Reply-To: <20260430233934.2620065-1-rdunlap@infradead.org>

On Thu, Apr 30, 2026 at 04:39:34PM -0700, Randy Dunlap wrote:
> Fix the kernel-doc comments to use the correct parameter names to
> avoid kernel-doc warnings:
> 
> Warning: include/asm-generic/bitops/lock.h:19 function parameter 'p'
>  not described in 'arch_test_and_set_bit_lock'
> Warning: include/asm-generic/bitops/lock.h:41 function parameter 'p'
>  not described in 'arch_clear_bit_unlock'
> Warning: include/asm-generic/bitops/lock.h:59 function parameter 'p'
>  not described in 'arch___clear_bit_unlock'
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

Hi Randy,

Thanks for the patch!

The arches implementing those functions use 'addr', not 'p'. In
generic version originally it was 'addr, but then the functions
were re-implemented in 84c6591103dbe, thus this 'p' appeared. 

Maybe just restore this 'addr' instead of fixing comments?

Thanks,
Yury

  reply	other threads:[~2026-05-01  0:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-30 23:39 [PATCH v2] bitops: use correct parameter names in kernel-doc Randy Dunlap
2026-05-01  0:11 ` Yury Norov [this message]
2026-05-01  5:02   ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afPvrowTHUHGdtle@yury \
    --to=ynorov@nvidia.com \
    --cc=arnd@arndb.de \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=rdunlap@infradead.org \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox