[PATCH 1/4] tools/nolibc: split implicit open flags into a macro

Thomas Weißschuh
2026-04-29T14:45:26Z

This logic is duplicated and its current form will be in the way of some
upcoming simplificiations.

Move it into a macro to avoid the duplication and enable some cleanups.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
tools/include/nolibc/fcntl.h | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/tools/include/nolibc/fcntl.h b/tools/include/nolibc/fcntl.h
index 014910a8e928..46f591cf82fd 100644
--- a/tools/include/nolibc/fcntl.h
+++ b/tools/include/nolibc/fcntl.h
@@ -14,6 +14,8 @@
#include "types.h"
#include "sys.h"

+#define __nolibc_open_flags(_flags) ((_flags) | O_LARGEFILE)
+
/*
* int openat(int dirfd, const char *path, int flags[, mode_t mode]);
*/
@@ -29,8 +31,6 @@ int openat(int dirfd, const char *path, int flags, ...)
{
mode_t mode = 0;

- flags |= O_LARGEFILE;
-
if (flags & O_CREAT) {
va_list args;

@@ -39,7 +39,7 @@ int openat(int dirfd, const char *path, int flags, ...)
va_end(args);
}

- return __sysret(_sys_openat(dirfd, path, flags, mode));
+ return __sysret(_sys_openat(dirfd, path, __nolibc_open_flags(flags), mode));
}

/*
@@ -57,8 +57,6 @@ int open(const char *path, int flags, ...)
{
mode_t mode = 0;

- flags |= O_LARGEFILE;
-
if (flags & O_CREAT) {
va_list args;

@@ -67,7 +65,7 @@ int open(const char *path, int flags, ...)
va_end(args);
}

- return __sysret(_sys_open(path, flags, mode));
+ return __sysret(_sys_open(path, __nolibc_open_flags(flags), mode));
}

/*

--
2.54.0