Re: [PATCH v4 06/15] remoteproc: qcom_q6v5_mss: Switch to generic PAS TZ APIs

Sumit Garg
2026-05-01T13:59:05Z

On Wed, Apr 29, 2026 at 07:01:57PM +0530, Mukesh Ojha wrote:
> On Mon, Apr 27, 2026 at 03:25:54PM +0530, Sumit Garg wrote:
> > From: Sumit Garg <sumit.garg@oss.qualcomm.com>
> >
> > Switch qcom_q6v5_mss client driver over to generic PAS TZ APIs. Generic PAS
> > TZ service allows to support multiple TZ implementation backends like QTEE
> > based SCM PAS service, OP-TEE based PAS service and any further future TZ
> > backend service.
> >
> > Signed-off-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
> > ---
> > drivers/remoteproc/qcom_q6v5_mss.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
> > index ae78f5c7c1b6..96888007faa8 100644
> > --- a/drivers/remoteproc/qcom_q6v5_mss.c
> > +++ b/drivers/remoteproc/qcom_q6v5_mss.c
> > @@ -34,6 +34,7 @@
> > #include "qcom_pil_info.h"
> > #include "qcom_q6v5.h"
> >
> > +#include <linux/firmware/qcom/qcom_pas.h>
> > #include <linux/firmware/qcom/qcom_scm.h>
>
> same here., whether it is needed now ?

Ditto, needed for qcom_scm_assign_mem().

>
> >
> > #define MPSS_CRASH_REASON_SMEM 421
> > @@ -1480,7 +1481,7 @@ static int q6v5_mpss_load(struct q6v5 *qproc)
> > }
> >
> > if (qproc->need_pas_mem_setup) {
> > - ret = qcom_scm_pas_mem_setup(MPSS_PAS_ID, qproc->mpss_phys, qproc->mpss_size);
> > + ret = qcom_pas_mem_setup(MPSS_PAS_ID, qproc->mpss_phys, qproc->mpss_size);
> > if (ret) {
> > dev_err(qproc->dev,
> > "setting up mpss memory failed: %d\n", ret);
> > @@ -2077,7 +2078,7 @@ static int q6v5_probe(struct platform_device *pdev)
> > if (!desc)
> > return -EINVAL;
> >
> > - if (desc->need_mem_protection && !qcom_scm_is_available())
> > + if (desc->need_mem_protection && !qcom_pas_is_available())
> > return -EPROBE_DEFER;
> >
> > mba_image = desc->hexagon_mba_image;
>
> Reviewed-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>

Thanks.

-Sumit