From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5644239EF38 for ; Fri, 1 May 2026 12:55:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777640153; cv=none; b=bl5EKrnHO9b0QzCaJjU5Sz7ToiNWUIptdN/oqZoVniDubmVFYxx9D170yocpk1cW5mPP0iewbRhzogu2wrFKOBETr3T+qWEiyQ2Id5ktsGGEM7/nCGx/kFz1USUNtEpiMbACv5ay1FQU1vYx2FCd1kqXD28zJ8B9VKB6eok5Lf8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777640153; c=relaxed/simple; bh=XhFDyZV6Ay3pnkqMe6UT+REa3lOAJYvzygmpMynHdAY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CaPRp+2XOY/zOav+P9Dt2TD+hflkZZpLD5XEG9zltgFRcPhfypMajg/zhcFVELNGz8mwjROQid7W+t79FwFLBp8lyZfawvQYl2hvWofMYuIyDgg+uUEadOAwSlHZgCvr2vpsRtd8U+QGEcsAj9Crwe9JatyerBdZSJ1nBpu7nx0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=SSPugyvF; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="SSPugyvF" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 07737176B; Fri, 1 May 2026 05:55:44 -0700 (PDT) Received: from e129823.arm.com (e129823.arm.com [10.1.197.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4E1C43F7B4; Fri, 1 May 2026 05:55:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1777640149; bh=XhFDyZV6Ay3pnkqMe6UT+REa3lOAJYvzygmpMynHdAY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SSPugyvFhnUwigXLMRpnu1hFkGs0AhJsRMHOO8/QcIAjPyUIAnjilQ7X1B+RCsnX3 TENFXCgNp1zGtKA1SrI7sbWqLsfRzDh5fpEINVAyUCWahlpYT0uCjWGBdAtJa0y4Ru W7wHy/ZqV0R8zW5lUdsZh69M4bI+YnXkVlYFGlJY= Date: Fri, 1 May 2026 13:55:46 +0100 From: Yeoreum Yun To: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: suzuki.poulose@arm.com, mike.leach@arm.com, james.clark@linaro.org, alexander.shishkin@linux.intel.com, leo.yan@arm.com, jie.gan@oss.qualcomm.com Subject: Re: [PATCH v6 00/13] fix several inconsistencies with sysfs configuration in etmX Message-ID: References: <20260422132203.977549-1-yeoreum.yun@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260422132203.977549-1-yeoreum.yun@arm.com> Gentle ping in case of forgotten. > The current ETMx configuration via sysfs can lead to the following > inconsistencies: > > - If a configuration is modified via sysfs while a perf session is > active, the running configuration may differ between before > a sched-out and after a subsequent sched-in. > > - If a perf session and sysfs session tries to enable concurrently, > configuration from configfs could be corrupted (etm4). > > - There is chance to corrupt drvdata->config if perf session tries > to enabled among handling cscfg_csdev_disable_active_config() > in etm4_disable_sysfs() (etm4). > > To resolve these inconsistencies, the configuration should be separated into: > > - active_config, which is applied configuration for the current session > - config, which stores the settings configured via sysfs. > > and apply configuration from configfs after taking a mode. > > Also, This patch set includes some small fixes: > - missing trace id release in etm4x. > - underflow issue for nrseqstate. > - wrong check in etm4x_sspcicrn_present(). > - missing call of cscfg_csdev_disable_active_config() > > This patch based on v7.0 > > Patch History > ============= > from v5 to v6: > - fix missing of calling cscfg_csdev_disable_active_config() > - add rb & fixes tags. > - add ss_status field in etm4x_drvdata to expose STATUS and PENDING bits. > - https://lore.kernel.org/all/20260415165528.3369607-1-yeoreum.yun@arm.com/ > > from v4 to v5: > - add rb-tag. > - fix underflow issue for nrseqstate. > - fix wrong check in etm4_sspcicrn_present(). > - remove redundant fields on etmv4_save_state. > - rename caps->ss_status to ss_cmp. > - fix wrong location of etm4_release_trace_id. > - https://lore.kernel.org/all/20260413142003.3549310-1-yeoreum.yun@arm.com/ > > from v3 to v4: > - change etm_drvdata->spinlock type to raw_spin_lock_t > - remove redundant call etmX_enable_hw() with starting_cpu() callsback. > - fix missing trace id release. > - add missing docs. > - https://lore.kernel.org/all/20260412175506.412301-1-yeoreum.yun@arm.com/ > > from v2 to v3: > - fix build error for etm3x. > - fix checkpatch warning. > - https://lore.kernel.org/all/20260410074310.2693385-1-yeoreum.yun@arm.com/ > > from v1 to v2 > - rebased to v7.0-rc7. > - introduce etmX_caps structure to save etmX's capabilities. > - remove ss_status from etmv4_config. > - modify active_config after taking a mode (perf/sysfs). > - https://lore.kernel.org/all/20260317181705.2456271-1-yeoreum.yun@arm.com/ > > Yeoreum Yun (13): > coresight: etm4x: fix wrong check of etm4x_sspcicrn_present() > coresight: etm4x: fix underflow for nrseqstate > coresight: etm4x: introduce struct etm4_caps > coresight: etm4x: exclude ss_status from drvdata->config > coresight: etm4x: remove redundant fields in etmv4_save_state > coresight: etm4x: fix leaked trace id > coresight: etm4x: fix inconsistencies with sysfs configuration > coresight: etm4x: remove redundant call etm4_enable_hw() with hotplug > coresight: etm4x: missing cscfg_csdev_disable_active_config() in perf > enable > coresight: etm3x: change drvdata->spinlock type to raw_spin_lock_t > coresight: etm3x: introduce struct etm_caps > coresight: etm3x: fix inconsistencies with sysfs configuration > coresight: etm3x: remove redundant call etm_enable_hw() with hotplug > > drivers/hwtracing/coresight/coresight-etm.h | 46 ++- > .../coresight/coresight-etm3x-core.c | 101 ++--- > .../coresight/coresight-etm3x-sysfs.c | 159 +++---- > .../hwtracing/coresight/coresight-etm4x-cfg.c | 3 +- > .../coresight/coresight-etm4x-core.c | 388 ++++++++++-------- > .../coresight/coresight-etm4x-sysfs.c | 202 +++++---- > drivers/hwtracing/coresight/coresight-etm4x.h | 190 +++++---- > 7 files changed, 606 insertions(+), 483 deletions(-) > > > base-commit: 028ef9c96e96197026887c0f092424679298aae8 > -- > LEVI:{C3F47F37-75D8-414A-A8BA-3980EC8A46D7} > -- Sincerely, Yeoreum Yun