From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AB783F23D4 for ; Fri, 1 May 2026 16:10:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777651824; cv=none; b=UG9PWK32vKeQSG+XXEGZWwbGTUIhbxaaWpdMIKNCzCStAYjvSPybkIIRqyW4ckgfcVVe9uCmHqB0KjcK9W2oTR+bafw6BFCRfi2J1sHR1GLwnhhwe/UccLznlHcTLTsxMKRjYgvZDqGkb/Ua/aCRay4kDzAPDkoEkYXharkenQw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777651824; c=relaxed/simple; bh=siKandvWvtiBR5e9UWqOOQecDwlnZ0hGS4SYBGCu8Os=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Uu97ShG+94Bk1V4nGIbF1IGz8rqOmZq9oI/gAlOX7SAMiD6oerH+idETWFK0uPheYbJQ3MmW+37/5G+WIs4YZ2LRBqMzOK5ffVwGQaOSJoUStdi5NzaRwklTM1xESGngRX2Lgy9pNs6HA7uDMIa6PN0cNucEZKdBJMq5NIona7w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=s/qTNQTA; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="s/qTNQTA" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-488af96f6b2so26369035e9.0 for ; Fri, 01 May 2026 09:10:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777651818; x=1778256618; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=h6xC7JfImrJgetVlvK/72zwn9HkupN9sZhP69nFLTWo=; b=s/qTNQTAtXGDDDqnPPFKkwyLH8kyEFuHegr98Z8JcuTVO1HfVOMGIvTREILtW1y1mX Sr489AyWZbFzHn792mVgULfBA4p/ryW1YtT6s2aLoZYw/J4UHRdzQhMNAFoOHHmcaWvS o6IUb1+BOBIPnrwV6a46wkcc8kxRP/9XWtnytFXJKCuoMs9Gyo5GvbDSUZiiU0wVZmkU dcvKQBHpQW/5Mlo0OaShyEK3kyTb8NgRMJ+KTFLcGsEGiLCLnRYaaktZ1gULRXQVINEK owIjbfNOw3N6I4aBjyAhB3H6w/JGzcItbmLlQx+UKMO+CkXHcEbG32aVDDSGBH+c8rgl kLzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777651818; x=1778256618; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h6xC7JfImrJgetVlvK/72zwn9HkupN9sZhP69nFLTWo=; b=mgboN4Pecu3ywKQRS9QRPlLjcT1b2G7K02GxAI/75ABE/CHHg7GRbLKhIx7b9egRo6 s92mwTenTiY/IYN0JkDud7MDn8iJAv5pFb1hSYJ2plEUmyrx1CswqNkCsSfDm3eJ71X8 OPd13iuWylXAsq3/z/mEVi3snM9MakhXR4jvN1KszyIFykoAK0X3R/+HsiT46cr0Zfsm mCBz0R/tN6BLIR+kIBdXhmhBl2Jo3qr4kiHk2Y3EJAkQPxtG9rpXVUkv3H9xscgZPJDJ QnkKYGv5LUvSfzgT6buiH5Pu3cvEod7eWFjL9fizIkLPzbZUT/fTn4RGSfZTVO8vgWbD d1iA== X-Forwarded-Encrypted: i=1; AFNElJ8eRL5zLSfypEYA4c+WXojaUz4FGnoigk7wzWg43bkhWyGuXV6G6Oxoe7UQnwuSP3TZndMrvZcWQIq6Lv8=@vger.kernel.org X-Gm-Message-State: AOJu0YwO3FTeD9xug0Pu55cBmd8V2tSFqr2xw1ulDZGJIV9JC51xNMTJ RVg1aVHZkZcWwvKC9VTx0Zu9vksloDje4DZuosD8ixo8n6zRL930rY60 X-Gm-Gg: AeBDieuD14NQ1S3OwMxF3RL87VGa/lTseyJZby00d+O6cILW4JvoDoktlhxh5U62GHE qqX9iVNCs8iERmfCYkjuORGQcBQOuT/emNIEgJXcBkRFkSy5WUBcCIlFx15o1cZxH04tBKsqgR5 K+nzvThMySt2hwCaEWYG9idiUO8l949/Sa0VG5zIgS0mNYeYavclB0EJ2rDVgf/2xdJHBK28KMB knLjKCLKUzjattjGXjW79jQHoYDKqyIeRiHBcy1mhZa6sCIHQOnrFCuZ/UMhZEWo6XFqFiJXdeA 5X+nZaIRzEL2kRbNYBHLeUKzlK6Ev4/gUuJJEBuK00rqdhajL6zMrtfuBmz3yHGqeyejkZhduOS OQL7jTm5LF1EZqMcLQhqZI49zRT7G28x5gEKXOofzZJOebKtIsB8DH6LZAlWkb3hkOkoJY7R5zn HO2LhgNQnn1gPf3tvdrk4L/UKMHjMLRQ== X-Received: by 2002:a05:600c:4f42:b0:48a:568f:ae6d with SMTP id 5b1f17b1804b1-48a8eb6b7d5mr56259835e9.8.1777651818277; Fri, 01 May 2026 09:10:18 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a820c8556sm136482475e9.4.2026.05.01.09.10.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2026 09:10:17 -0700 (PDT) Date: Fri, 1 May 2026 19:10:12 +0300 From: Dan Carpenter To: Shyam Sunder Reddy Padira Cc: vaibhav.sr@gmail.com, mgreer@animalcreek.com, johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: greybus:add missing newline in sysfs show() output Message-ID: References: <20260501144207.25211-2-shyamsunderreddypadira@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260501144207.25211-2-shyamsunderreddypadira@gmail.com> On Fri, May 01, 2026 at 08:12:08PM +0530, Shyam Sunder Reddy Padira wrote: > Sysfs show() functions should return newline-terminated > strings.Add missing newline to sysfs_emit() format string. > > Signed-off-by: Shyam Sunder Reddy Padira > ---- > v2: > -Remove "no functional changes" from the description as per > Greg's feedback. How do you know this doesn't break anything? regards, dan carpenter