From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C7901A9F8D for ; Fri, 1 May 2026 19:34:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777664070; cv=none; b=LnNw7yx2svhgY6+O9c1YR5VnTs7/kzkIGTwKh4jpaJfm1i8H59Mh1ktP/1slMoCta+XEBEtYOl3TLrvjRTkmQRQvogJbE0/1jEZlJsql3qp4kB/azbqChNcJcqsBacIbb3nWj0Hrm/VAUw3Mv+U7Sl1eoo7zcP8dzUHBDVT4oLw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777664070; c=relaxed/simple; bh=Dytkl2SUAeIxpkAUClP5BV/NPeaw+WqHLNSvgwCdMJY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=O93hy1hWGeoXTq/qkgVc+yY+Er96fSdVFEF6QSLqo7tsV7qP8lZ1iybppu8HKWg6cmCvrMH5j5oA25CbKVe6dQfRrT27V2lCtBztH4VRTRMiFCW2bCr25UfOshL/NoZMGUnpWoBjpGuq3QbhKkib0OMfUcibrhUYBQ8D5H2U6qQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com; spf=pass smtp.mailfrom=soleen.com; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b=izNqrGOL; arc=none smtp.client-ip=209.85.160.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=soleen.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="izNqrGOL" Received: by mail-qt1-f173.google.com with SMTP id d75a77b69052e-50e97863425so21461221cf.0 for ; Fri, 01 May 2026 12:34:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1777664068; x=1778268868; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=W8gPN7kNDbm8qtyNa0nO5GiXBN5vG7cPKkydh+QrL3Q=; b=izNqrGOLDLwv0xiJJocT1vsyG+SaottYn7iiIC2lzF2teK5sTwZmzA0kfD+tPSML3o wIrulfvkOKEi/KERSYtTunIdjBk6XTZPl785Zjkg4PrIChA3Br6yzlzKFbK7hxQUxzf6 wNqL2Q3hmZHa9pry7pcMsfPa0aQiKzCr0SF905SxomlflUjyaq/sjcEsU9JEZwgPyBn+ pVQjgkhq6NR/tOz2QHF9/6Itp5SNDNIgVrYzURRP1GK5lzVhnVOG8mka9iZoFuwgJp8G n6TbYQCVYHrXkNL8Hzd1jSuB3XFY0rsytVs48nHGB1Y0JSR2ngqFkoYgxqE1rHB/s00T NjQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777664068; x=1778268868; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W8gPN7kNDbm8qtyNa0nO5GiXBN5vG7cPKkydh+QrL3Q=; b=kOE/zcR5PvHQOK6G83m6gQpNXQOE6PVZA+a98t6b94gcbTPIRxnNtf4zfBGsw/jjwB 7oE3/RwQAMOCGdOAJIZo76gD2hBAjzI0Rcy+jrgm1WV8VvEnD5DWBreeYbq2errpL0Rh XVApbEGUMWfmUUdh8oybVH7OWPK1n0H+v/+hX9HKFbpPUP8vHuTgDQhe7RTAhyuXUV9e 6xKv7mUkrShgqlEHr+N6c7nCU9GWwwMglEribA3bs4rkCIlS7cyfxm0dah3cTvfbAuvR xbKEv8lMd1eTQSMeQBD4p0igjZbaRA64i+/EzdxhsU2PXsqzjkaw1g3hGAa6/krtd/TL vluQ== X-Forwarded-Encrypted: i=1; AFNElJ+gQ9melICPS0BXvhajvFrWcmebKyQHPWWY2MHZcko/1PCTRbT8USsp123FzeW1IrQvJe3ygLBy1YMS6AU=@vger.kernel.org X-Gm-Message-State: AOJu0YxKXqO1SF2uXC7TTt3cFXbbLL8mJCzGsk/RQS3I7dLdKApUJOF6 SK2FPq5toLsiYM7ZKKgThzzmQBbn1i7g5Yz5K4ZCvN3Q6cN7c6fx9zsX12m+K80lu1uADijyQNQ SnMCJWto= X-Gm-Gg: AeBDieuY77LDpcCVS1uAN37YWMFnP44hMZaxyib7llHZe/fD7gqPhHJNJqHBUPW1qLk M7uhYgWqFReROjVaoBFt8z3UM1LMHkwWa7hkjtDg62vHLa9hR/ZNEdcLjcouKCbuTxVE4xGbUqf RB3tMdD2Z7o0utNmBBcV1vIhJNIwooPE5gt83oFqv3IA9ifZAsFEA1Ss2XKf8qvWpF2zLJZfSVc FhMEth2sIlKmNpG7UAW6hw4fLqfubXNK91ZlbyhcyrVRMn3UppoGAoX8eSltrpIuFnPAd1spKN5 Ltq/eg/eFyS/pGvBNH2WQNVUTnoMd0a64jXOZzHgp5OLc9k/W6Aw7Hcu6f410ANHQk5L2cod/tX qNFfefnGNEBmjd22dr5NYqyUcTk5y0O3G6t+xSIbxG08yEfqFIAkwTSGOMqAspNMf5NW+n2odeX ywp/jphhGjEkVK08H24yI+QeAQOBhblKx1dW64AiNm6kwvDff+O9GPbrNWPa4h5w== X-Received: by 2002:a05:622a:3d3:b0:50f:b1ca:6eb4 with SMTP id d75a77b69052e-5104bdf33b7mr9482351cf.3.1777664068181; Fri, 01 May 2026 12:34:28 -0700 (PDT) Received: from plex ([71.181.43.54]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51040b5d1f8sm22318571cf.22.2026.05.01.12.34.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2026 12:34:27 -0700 (PDT) Date: Fri, 1 May 2026 19:34:25 +0000 From: Pasha Tatashin To: Cris Jacob Maamor Cc: Mike Rapoport , Pasha Tatashin , Pratyush Yadav , Alexander Graf , Andrew Morton , Greg Kroah-Hartman , kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/5] liveupdate: validate restored LUO metadata Message-ID: References: <20260501094637.38650-1-crisjacobmaamor@gmail.com> <20260501173053.73116-1-crisjacobmaamor@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260501173053.73116-1-crisjacobmaamor@gmail.com> On 05-02 01:30, Cris Jacob Maamor wrote: > LUO restores metadata from KHO/FDT during liveupdate. The restored > metadata contains physical addresses and count fields used to access and > walk preserved session, file set, and FLB arrays. > > This series adds a non-consuming KHO preserved-range check and uses it > before phys_to_virt() on restored metadata addresses. It also rejects > restored counts above LUO_SESSION_MAX, LUO_FILE_MAX, and LUO_FLB_MAX > before traversal. > > As far as I can tell, this is root/admin-only; I do not have evidence > that a normal unprivileged user can trigger it directly. > > Changes since v1: > - Dropped RFC marking. > - Added changelog text to each patch. > - No code changes. > > Cris Jacob Maamor (5): > kexec: handover: add helper to check preserved page ranges > liveupdate: validate LUO FDT physical address before mapping > liveupdate: validate restored LUO session metadata > liveupdate: validate restored LUO file set metadata > liveupdate: validate restored LUO FLB metadata I have replied separately in the security report to clarify that this is not a bug. The behavior follows the ABI specification exactly: we use the PA addresses and ranges provided by the KHO FDT tree. NAK > > include/linux/kexec_handover.h | 6 +++++ > kernel/liveupdate/kexec_handover.c | 35 ++++++++++++++++++++++++++++++ > kernel/liveupdate/luo_core.c | 10 ++++++++- > kernel/liveupdate/luo_file.c | 14 ++++++++++-- > kernel/liveupdate/luo_flb.c | 23 +++++++++++++++++++- > kernel/liveupdate/luo_session.c | 22 +++++++++++++++++-- > 6 files changed, 104 insertions(+), 6 deletions(-) > > -- > 2.53.0 >