From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E74E3EB7FB for ; Fri, 1 May 2026 16:53:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777654409; cv=none; b=Y6W8onjTbsMh53e9oEnnk1J8OLYataNdWVKhC5+oADZhwXg5s0U2s5XJXkSNs1K8oqBREfZLb0b4ZzT0Iolf/iKtriE9efUPeZiBx9EZkcKXMUP+BxyNR3Y4sDV/3gD6BXAk/RY1guWEXjlWZpnKMnGsEh7atCxZtJvEQnR4tac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777654409; c=relaxed/simple; bh=AG3HTci99ueTkSi7UJgy6fxos653LyFyBJNbYtXNsEs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=niKeMeNBVI320MbKS09UR9w3zzgF5v/gzin6IWR3UxRwjLounOKS8lllu76wL54bAmnCWej6oBQWwdk5fm1Nhzcmb2UAQodpg3is1cixctcMAbo87PFE5SOCUkbXw0nYltlRd7nFdnvX6DfHPCkXMKv9Mx2cGmBEjCZ76i0cdlU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bt3v1Nc6; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bt3v1Nc6" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-43d7badbd7dso1017634f8f.2 for ; Fri, 01 May 2026 09:53:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777654404; x=1778259204; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2y27sRo5ue8JWE2ijAh+vOWVcIL4DT+bsyPNoqe/DwM=; b=bt3v1Nc6HIromMClN8tVg4UH0JvUDmvxU8BxPk+PnsjN5iqc34g9por6R4/pUtKOc+ 5BRlax/00N8u0tSeT7vJfTFYkfrdhKyEqCvsjF0GlfISLFshOUm8CMSCPdVcXKdAHFEA eZz2I/QDKNjqELrW/O3gtJDgzolC3egebE9SrDZ50fnTfIKxrqQ99vNqamLtBp0kFtVo NRV9tqNP+NRBVXT31pzdPFKFuCCQpp76nI4uCBphUhQ0qpZqjDEYtk3AeTd5SlXtdMPq vTmD7kCfUc+g6Qat3bcABt6pUTqQch9o4+5w6sAceUlnwND7nBIP4aKpxSBVU09/EUhp gcRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777654404; x=1778259204; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2y27sRo5ue8JWE2ijAh+vOWVcIL4DT+bsyPNoqe/DwM=; b=kPYZmxEs7ITboZD+yM7KxkEbLP5d7wGhAsCovYZfrmUDRo/mW7HzEc8HXvyS1gxQri UVuRuw1CMPJZeyQiMpUJF6FbzEluvBGCUb4xsnqMC2IFp13cggljw4QuzDaLKpLT10wK 6aLxikFqRBZGyfWY+/1a7CgoJ8eNdNa5xey0kRHAr8UuK72Vp0kD3FeLY8his++H27KS 8cVUS2haE7nRgw52DMw6ufFdC30k6ftW4u5f4N2iatE2mLqfnSqfJzpzuO++JL6sFWh0 ZFtYnPpafx6hl44GJNGfJBBjL0pQlw3UmQqxyH5wpAs21ptAR44effDsoI7f6NtH/4Ih P0Og== X-Forwarded-Encrypted: i=1; AFNElJ9Q/Q+t+eX7/bDup8Cb4vL2GDw3mlq1VyI0v7zz71d9Itj/YAJkqHqiaNoI/FntqE0N3aJvb3vUF/5cYSM=@vger.kernel.org X-Gm-Message-State: AOJu0YyHvJtvIX2AFQbqL89KaAKRLZ9+4fJcrVysJR4ywwh/SWvSRxsO 5WI/tUnY5M+FQXG/KCoDJZuqXjC2fsvdEXAkZRvUFGyLs+9tzqD0kfqT X-Gm-Gg: AeBDiesFBgfjHjZsY1FUfTDgDwc6DJx7vi8DgkNva81Fijx4PypsVYcG59WHaPHkW80 xxAzYf5h3aBJG1DzKrbUQCHm8koFmYB7UV3iXs0cj2yMbteJVMXOwbmy1fgrp3Dy/G2fIVOClO5 GbXzseU8huH8Mn+GOH1NlVLN3l18aOwEW237FEVIQNGmeTw/IPm+l4IlebO46cJgk1T0+y4A8HI wL3kk2UuCjmda1sORezDq5NP1VuFlMJP+2crCHgeXX/JVtPujgOha3WEbxD/8AC5cGeaBTx0XEc NnU4rQSffU7mgwXtE8pbTssHy9fbttqp8QkdG5FUcQXnvNygexrLm91z5vfJFvieJUCJ+kiHHJE 22JoaWeiKlRvP4BTL9gqsHMimG1XqSuJ/VWxrsyXvgeevi6fr5MbdmHZGngJ6ZLz+BFeFM2jlBI /RH5CcbxP/tlgv4FhkC+WV9twskobD4Q== X-Received: by 2002:a05:600c:4e55:b0:48a:554d:b9a2 with SMTP id 5b1f17b1804b1-48a8eb616a7mr64863775e9.6.1777654404110; Fri, 01 May 2026 09:53:24 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a82301ad1sm228316225e9.9.2026.05.01.09.53.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2026 09:53:23 -0700 (PDT) Date: Fri, 1 May 2026 19:53:18 +0300 From: Dan Carpenter To: Shyam Sunder Reddy Padira Cc: Vaibhav Agarwal , mgreer@animalcreek.com, johan@kernel.org, elder@kernel.org, Greg KH , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: greybus:add missing newline in sysfs show() output Message-ID: References: <20260501144207.25211-2-shyamsunderreddypadira@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, May 01, 2026 at 10:15:57PM +0530, Shyam Sunder Reddy Padira wrote: > Hi Dan Carpenter > > I have not been able to test this on hardware. I based this change on > the standard sysfs formatting requirement as documented in > Documentation/filesystems/sysfs.rst. > If there is a concern that specific Greybus userspace tools are > sensitive to the trailing newline, I can withdraw the patch. However, > this change aligns the driver with the standard sysfs formatting used > across the kernel. You need to test it with the Greybus userspace tools, yes. regards, dan carpenter