From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f44.google.com (mail-dl1-f44.google.com [74.125.82.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCE5A39B964 for ; Fri, 1 May 2026 20:54:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777668847; cv=none; b=n6lNzfQnbUgnEaBjNio9lRBG6P4/ax1TPrXB+QMLHm+ZT0qpun1zSdzwvDblUNFsQg8hg5gaoVnXQxdEpBthBEKHQo0Z6+AZgMTj3bh5Ca8CFrWorWk/gi5Pta/QdaOigZTrl4mZcGCFpwgBfLHj006njEqwF+6le2xEKQID5Xo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777668847; c=relaxed/simple; bh=XjCUsVDc0dvJ5e0JCDT98nVHyx/Y1d6o9TlmjFvS9d0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YzaKX5ADxPBhGunSwGwMrcafb5ou3GM1YemRO7+5v5VH3Bu5LvZuY5pKH0wK2OrndeJd3u4+cVOpl1HkC1o0BBLkgdsGM3k46sETZ5PYTl21DbWRHoCRV7XRVmH4qqXFsm0ZfSPXPGDKT7mmd2azl9jfbxFwtOaOGToKiouiOQ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=EG+cVDcZ; arc=none smtp.client-ip=74.125.82.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="EG+cVDcZ" Received: by mail-dl1-f44.google.com with SMTP id a92af1059eb24-12c8cc7a77eso2431522c88.1 for ; Fri, 01 May 2026 13:54:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1777668845; x=1778273645; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zK8EJN8MJo0FeITuuiwPKvUN6W//LNatpxigx7Y+yV4=; b=EG+cVDcZPOZxjD50QYOw8stNzikKEA1X1gmDbk1v4xKMJHuPhUzMRx1QME64PmXbf7 BaNIc3elVmdeTWI4wypYK79tjX1vQOCsbhtJXAVUVviLSxYaYGmB3KO+gO7JFxPc58U2 AH+gCjMA3FDh4B9ZE5LivfT1z82Evfurxnvuw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777668845; x=1778273645; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zK8EJN8MJo0FeITuuiwPKvUN6W//LNatpxigx7Y+yV4=; b=tZENUzB61oUlENmJg63wMc5JLbRwMPr4dHW2j+vGO1ngiqDXuUQrh0PKgvKScLFnm5 gDSydBXX5eEistvnew522lW5g1A9+p8rPrTkpdwcoQPT64xwk24CGRNG4kgevkhTEqM4 SwSV7X2/lq6m8ZOlYnPko3C5Uoc9gL4lFC+URLc9d/s0YRpRsIPhO9Ky+/KdnRME0L5S D1sSK6TN9hK79AGptiO77v4IRxrw5F440FpJqwLrqIcP2ozWgtT981FVk/4HNd5JzBMn 4dnG00EXLCcHUUGAsv6b6vB1qKaVd+n5ULtOY/Q0BP3Iy0df+8yWhT/5d0NR5iDM9EaW F1+w== X-Forwarded-Encrypted: i=1; AFNElJ8FYgAm8Eioa9PlPPI3RyRq1jN1uPS10RKYef1Fz1rICRF/v2IKZ7J+Yd1mwUfvq3RN/zO8Vmx5gc1OVN0=@vger.kernel.org X-Gm-Message-State: AOJu0YzsgqVamIsCIvwuAV1I0xf85JGIjisEJtIp/OCfkjCYKSF7UVgk 4n6VYy7C3AC6lB+CrmjiL1s2sGS+hDRmCQvMdnJUyv6/0Nv2viBlD70VLkuaUame5ojlTLz9W1L omu8= X-Gm-Gg: AeBDietRUOGLY6LUP2+mVqIi+A5Hvq0yVcT3rQbZTvaez7iszWCkYCkUPM4Uba/Nng8 BSwn1XMp5f5BhRqbXEzw4IZKepmEfWRC/UGkAsoOnpWtYyOQaaoP5B1UKJQF93GJnNUjjN1b+8/ jj7zdsqb1fLR5ixbUqOqdWhYGsBiT0i7j6dJfwOuI4z2yq3mkNyCnuzuSy+XYpMrk89nYpb4n1v fA3L4xrbEhsETFtRGvfLksOmvOmVBpP19yOahEEjqv3khnq7Ai1ZeHqk5Il5bz6vedki3y9xv5u aQAbk3YuAWXvcznFUAEVyfecXOiBDArOaYbIgncedVn5yO0dtOuq6u6+64qrZkgJD8CPtTFZir/ 8u3MNLr08e+ceudJWU/ZiBj4UP0+w4oP75h1ofJ+v19lXtGOEmGFXgERrEdVCS1wAs7eJYdLgjc 4jDrqR1xd5eZDrGep0TdAJkMvSjZ6tJnE2Dh1VQEhAV9Dgzx9PQRxZJEujfoHiZDsObiEIUiLW X-Received: by 2002:a05:7022:6087:b0:12c:1288:ce63 with SMTP id a92af1059eb24-12decc27261mr3311492c88.13.1777668844792; Fri, 01 May 2026 13:54:04 -0700 (PDT) Received: from localhost ([2a00:79e0:2e7c:8:bd10:aaf2:c3fd:4086]) by smtp.gmail.com with UTF8SMTPSA id a92af1059eb24-12df8295552sm4178673c88.7.2026.05.01.13.54.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 May 2026 13:54:04 -0700 (PDT) Date: Fri, 1 May 2026 13:54:02 -0700 From: Brian Norris To: Titouan Ameline de Cadeville Cc: jwerner@chromium.org, tzungbi@kernel.org, chrome-platform@lists.linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] coreboot_table: skip failing entries instead of aborting populate Message-ID: References: <20260501094322.123160-1-titouan.ameline@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260501094322.123160-1-titouan.ameline@gmail.com> On Fri, May 01, 2026 at 11:43:22AM +0200, Titouan Ameline de Cadeville wrote: > coreboot_table_populate() registers devices one by one. If > device_register() fails for one entry, the current code returns > immediately, leaving previously registered devices orphaned on the > coreboot bus with no cleanup path. > > Since coreboot table entries are independent of each other, a failure > on one entry should not prevent the others from being registered. > This mirrors the strategy used by of_platform_populate(), which skips > individual failures rather than aborting. > > Move ptr_entry increment before device_register(), log a warning on > failure, and continue the loop rather than aborting. > > Signed-off-by: Titouan Ameline de Cadeville Acked-by: Brian Norris