From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65058285061 for ; Fri, 1 May 2026 22:08:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777673333; cv=none; b=bL4X0/4owzav8nV5KZWCoapc5uLhvkcXlhF0nlovIJJ6P082fLRrOTfKyRirB/sHxP3ap2j5yu0h2yhYkZMBNnx2GVyjAW4MEwZmtGDQsYogpx9ffw84b6Cl0PPOQUAoOoFpwBzesa3P+X8tJCTOJwyNOmAY6GmReeQ5AEAtnFw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777673333; c=relaxed/simple; bh=Gg8XwvR2iye8ftuUb9NqbqgTU1BVsr9N0mr1rcUra+M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LlT7j0XBNUZacBcY4ezdhDSgBxcSjrC2tx1lkQ/OwYsDsBHUb1z2yAbK3E/3bx59WzzbBZkdbMcu5fniYWyuBlZnqjIOi5bkbUEhF4ZQBHAJSwxIB6OGqBDutzFzzqGBaFSEQW7e8CaXdXn2mFR38/f+DZN6GFwLKwmczvCzZPQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=FB/UTE6y; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="FB/UTE6y" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2b2503753efso23247155ad.0 for ; Fri, 01 May 2026 15:08:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1777673332; x=1778278132; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rIaBOF6T3Igmnhw7WxYJufQz1JELLjrBCUgq2t+SNoU=; b=FB/UTE6yrxnLOfl/SWHG/JOdIUkdte5z/Va9gzKPiVkf+Yw/OwzoTopbUuIYGs5WGf 0ULgy3tiaZJdN1ExKkpvKOsCRE1fhdVrsBPayKfaZ7e63Sw5sulgKTxf1O6Nwfmso8xa Rg+jPPhHjpoyBnIj2gFilMZC1WRjQuwM+NlHTFr0n5biDIjKnbpE2CF/EMxWUeVTJUk3 Id+bVufmLLA22suG1BE/dOTWp2agYba/jD39teCzZsOENf5AiSNRbciImLmNFIoWdCN9 fArB2NI5pk1jqXZepvlozBNHfx6bH9pTbUu7wSHTESH/X8ds/evxf2kBzJ09SWFulZyN iSFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777673332; x=1778278132; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rIaBOF6T3Igmnhw7WxYJufQz1JELLjrBCUgq2t+SNoU=; b=nm2qKRkcFMpK7rU5EEe60tBwDWk9s0LpTqThWe7m9T0fLIWV4AVR7lxy+u7IX/MUqj TaIyoZL1Bq0mXQjXNKrwEBo79log4CzwLqsHxnFyWI/ZAzj0YZMBXlmr8d7NyOgJ6GxK gxcQJA5dqwNsVkmEYMH86EjpmCjOz7m7Q1Uonp8D5JqyAiPZdcin5B0dhZoXYPVdCVpX xinDcqV9u+sCRBFT1aY89aSN1kOr80o+7lplXlP2+X7p3UjTx+XGMl2Zku+fveHh5fiU yqSgk1+aNRBIeWzHWTJZN1y1atu8xEiyyv/pOJtr8XnLKMRgtSatm01PivLu9ipDKC5h +pLA== X-Forwarded-Encrypted: i=1; AFNElJ/Rsk8fJ47oF4VdA1ljfdJxUW16+B8GoA0JpT02sxRBjpKtcJVCIAXCzHiK2v6h3wjXcXs4ZC6QDI4kBXU=@vger.kernel.org X-Gm-Message-State: AOJu0YwER7+B+rjWFyas9kO9fz8ZMFFYakiQPlvw85IcE2EH9JX3zYsx 1+H7VEeeZHEnuoQ6zGc+fy1+4bLGtd9mfhIHbSuZxIIhUsTm0tHzPgfoLa5Ig/cOYg== X-Gm-Gg: AeBDieutTCofotT3xix4ulGE6W0w3kEisalwZG0ynl4PzIdp7WYi41twMiS3Bcl1DfF lBPLolheGs0yiMivQZGWUBrGWRrOApOGbBG7DEJ6+jJIncHonTK36ygFAg+S87ltSSPMdvGnaJU HJYTSf0R/0LrPeGnt+OPOPmcjOCqYYPjKm7bzJBXSlcffbD5DQ2zNvZtIKgHaV2n7JWPXsOMi/g jZwBKFbh4uoYk1x9OuZ6rsNVQEOz8jZ6qU65veId9Nr0qVKzBhlnslyMNf/daZvmU5jfngHoA+Y j16mTxiAZr0narwjQUbez9QMgs/7xwhXXFU41DspKMSYh8cxrK/9woc8RmLCoSQLtfwE/yXT3K4 7MrNzh2evnZR98dGs4DVeAmNi6aEgwvh1EK008tj5YZ4sIcTTDA1Q7N6ZNXZ3NDZKeUezSXRyTq PAMGy/BYEarvFKWBV4DeAHS6lOn5Vk2GZ7i5r3Wifz/VmWeOYzGq8xvkoEhmUkBs162IHeY01UM ilkNQ== X-Received: by 2002:a17:903:3c23:b0:2b2:41a9:8e10 with SMTP id d9443c01a7336-2b9f25e5495mr9622995ad.23.1777673331344; Fri, 01 May 2026 15:08:51 -0700 (PDT) Received: from google.com (76.9.127.34.bc.googleusercontent.com. [34.127.9.76]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b9cae6d123sm33770635ad.84.2026.05.01.15.08.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2026 15:08:50 -0700 (PDT) Date: Fri, 1 May 2026 22:08:47 +0000 From: David Matlack To: Samiullah Khawaja Cc: David Woodhouse , Lu Baolu , Joerg Roedel , Will Deacon , Jason Gunthorpe , Robin Murphy , Kevin Tian , Alex Williamson , Shuah Khan , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Saeed Mahameed , Adithya Jayachandran , Parav Pandit , Leon Romanovsky , William Tu , Pratyush Yadav , Pasha Tatashin , Andrew Morton , Chris Li , Pranjal Shrivastava , Vipin Sharma , YiFei Zhu Subject: Re: [PATCH v2 03/16] iommu: Implement IOMMU domain preservation Message-ID: References: <20260427175633.1978233-1-skhawaja@google.com> <20260427175633.1978233-4-skhawaja@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260427175633.1978233-4-skhawaja@google.com> On 2026-04-27 05:56 PM, Samiullah Khawaja wrote: > Add IOMMU domain ops that can be implemented by the IOMMU drivers if > they support IOMMU domain preservation across liveupdate. The new IOMMU > domain preserve, unpreserve and restore APIs call these ops to perform > respective live update operations. > > Signed-off-by: Samiullah Khawaja > +static int alloc_object_ser(struct iommu_array_hdr_ser **curr_array_ptr, u64 max_objs) > +{ > + struct iommu_array_hdr_ser *curr_array = *curr_array_ptr; > + struct iommu_array_hdr_ser *next_array; > + There's a trade-off being made in this function to leak deleted array elements instead of trying to reuse them that warrants a comment. > + if (curr_array->nr_objects >= max_objs) { > + next_array = kho_alloc_preserve(PAGE_SIZE); > + if (IS_ERR(next_array)) > + return PTR_ERR(next_array); > + > + curr_array->next_array_phys = virt_to_phys(next_array); > + *curr_array_ptr = next_array; > + curr_array = next_array; > + } > + > + return curr_array->nr_objects++; > +}