From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.formilux.org (mta1.formilux.org [51.159.59.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8D7B2236FD for ; Sat, 2 May 2026 03:05:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=51.159.59.229 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777691115; cv=none; b=jZuFhuI2RlgozxvP7uKJanU5u0dkNKMeJn2vCEeKWhxCPlg2BSZXj89dyDgRi80RStn6rv/wa4T9r6gVSZn17sQNPwAOl9K1RVl5NEUeM5AlMPqKyl3rzNA5oKaDx0fICEla5WAReswr6k8ph4Y+0DBM7MGovrOmV/p4ijueS1s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777691115; c=relaxed/simple; bh=ThkqzDY5iUx1UUjV0ZR6cNNDNa/t5uI7m+dHpMjazfs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DWPretoGiGWUkl2Neu4ZI5QiVktiVVKht3tsUXk6iB5j7ow1TjaltJikZHVcBD7ebSf0Xij+PLJ4WbyUcROPfKt+gXmSMt1sq8A/ZOseHfiqsykOA+Zd+/D1pwZUatvRGW88p19v5hOx+COA4wSXZHEVMi/3/shREZ8i+6VC+kc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=1wt.eu; spf=pass smtp.mailfrom=1wt.eu; dkim=pass (1024-bit key) header.d=1wt.eu header.i=@1wt.eu header.b=e6zOcsjf; arc=none smtp.client-ip=51.159.59.229 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=1wt.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=1wt.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=1wt.eu header.i=@1wt.eu header.b="e6zOcsjf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1wt.eu; s=mail; t=1777691112; bh=7lmTxYvlriq+m3TI1hS+gFD1F4xT7dmIiCykuPs421I=; h=From:Message-ID:From; b=e6zOcsjfkKplYDnSx9FV6wkD9+DupfWQCkwolqAePTqtcQs8dgVLFu7Jq8zOVful+ gkBSp9mQFu+sDQOtNp2ueRXB7Y8WVlRORST6UxAQ7pUSX+NH8U6v1/L4gCYWV+1WCS s5Xl+8uKKowPNQCa/B4wIzSWkneYzkXRDNpoYb0o= Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by mta1.formilux.org (Postfix) with ESMTP id 14EEAC0AB2; Sat, 02 May 2026 05:05:12 +0200 (CEST) Date: Sat, 2 May 2026 05:05:11 +0200 From: Willy Tarreau To: Daniel Palmer Cc: linux@weissschuh.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/2] nolibc: Add fallocate() Message-ID: References: <20260430164125.1106350-1-daniel@thingy.jp> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260430164125.1106350-1-daniel@thingy.jp> On Fri, May 01, 2026 at 01:41:23AM +0900, Daniel Palmer wrote: > While poking around with my "static PIE for nommu" series I found > I needed fallocate(). Implementing it turned out a bit more > interesting than I thought it would be due to how the offset and > size need to be passed on 32bit machines. > > v3: > - Reworked the test a bit, ran it on all the targets I could get > to run (s390, loongarch and sh currently don't work for me). > sparc32 doesn't seem to support fallocate() so made it skip > the test. > - Rebase on nolibc/for-next with the large file support bits. > > v2: > - Addressed Thomas' comments > - Trial and error'd a test for the arguments being passed correctly. > Hopefully someone smarter than I am can tell if it actually works. The series looks good to me, I don't have any particular comment, but let's wait for Thomas since he's been reviewing it from day one. Acked-by: Willy Tarreau Thanks, Willy