From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Shirin Kaul <shirin.kaul11@gmail.com>
Cc: linux-staging@lists.linux.dev, gregkh@linuxfoundation.org,
hansg@kernel.org, mchehab@kernel.org,
sakari.ailus@linux.intel.com, andy@kernel.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: atomisp: isp: xnr 3.0 fix whitespace issue
Date: Sat, 2 May 2026 11:33:42 +0300 [thread overview]
Message-ID: <afW25ktg74Xfae-B@ashevche-desk.local> (raw)
In-Reply-To: <20260502082516.16302-1-shirin.kaul11@gmail.com>
On Sat, May 02, 2026 at 08:25:16AM +0000, Shirin Kaul wrote:
> Fix spaces by replacing them with tabs in function calls to comply
> with kernel coding style.
...
> static const s16 a[XNR3_LOOK_UP_TABLE_POINTS] = {
> -7213, -5580, -4371, -3421, -2722, -2159, -6950, -5585,
> - -4529, -3697, -3010, -2485, -2070, -1727, -1428, 0
> - };
> + -4529, -3697, -3010, -2485, -2070, -1727, -1428, 0
Leave trailing comma, as it's not a sign that this array has a terminator.
> + };
Wrong indentation.
...
> void
> ia_css_xnr3_encode(
> - struct sh_css_isp_xnr3_params *to,
> - const struct ia_css_xnr3_config *from,
> - unsigned int size)
> + struct sh_css_isp_xnr3_params *to,
> + const struct ia_css_xnr3_config *from,
> + unsigned int size)
It's half-baked solution. Moreover there were handful of patches (better than
this one) to address the same, please, study preexisting work (linux-media
mailing list archives is for your help).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-05-02 8:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-02 8:25 [PATCH] staging: atomisp: isp: xnr 3.0 fix whitespace issue Shirin Kaul
2026-05-02 8:33 ` Andy Shevchenko [this message]
2026-05-03 10:54 ` [PATCH v2] " Shirin Kaul
2026-05-04 8:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afW25ktg74Xfae-B@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=shirin.kaul11@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox