From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2179B1DF248; Sun, 10 May 2026 01:42:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778377373; cv=none; b=DBJdHb2FEiTr/4aZcywq+wpSzCzNainkzPJUK/63rdfFT7zfhnAp70DOcVaRsRLU5wn9LyrULkoAuAu9siQMOvYab9vtU2fUdsSR6rTDmvBE0FTQTcmSYSbxuwQkglLWGMwRUbXyTk36+hMG06UsFPrEz8tJ+EzHSSiUxXImUao= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778377373; c=relaxed/simple; bh=DU5v/vXKr+84UuY5LnqHDDe6y4ebm53ChAYJDhItcJY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=b62SYGKZutk7nzK4WRocPGZiphBFkoWbqpffSfwV6Po/0vFxjCOFVoTYqQ52nkc70sJaehGfoAxi5rnGxdh08Gi2JV56Wm9hps/lcvIHAG+mqSiZByaWvc7aXDrk/8nF3E5S2Qd2Xpx8OTpSOkkkygAamJ2hUCtSuvAvrEIPLdc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WqeIMfwp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WqeIMfwp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C27FC2BCB2; Sun, 10 May 2026 01:42:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778377372; bh=DU5v/vXKr+84UuY5LnqHDDe6y4ebm53ChAYJDhItcJY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WqeIMfwpa1uTQu4wzGLb030TRXnsW0NPIyN8zddagCznwnXsEZoPH2mttpzMqOH+y 0pzbA5jfSq7w04bPYsD/KLusI3Yerz3KKNIzFNxI1XffvEYRo2CDrya/naHMcqdcL7 z1tj6AytbwrzXwX8/ykfyf32/Vmvms8hgw3bRNRje6O+JkiInn9Z4u4c3yAh9dXnT3 VF7G3GI5gUfwkJhPTEXssSBhCUQKb881MlTjhb6WFvO8Z4XbcZlYnPz2lF9OykbsPW VSrVqcCL+fjcpXWst5oMpNf44Kl2r5Kct0e3BwlTRIsBCRoF/VV5+G1UuB+3s2szrt 1OmgtXlKEbV6w== Date: Sun, 10 May 2026 04:42:48 +0300 From: Jarkko Sakkinen To: Gunnar Kudrjavets Cc: jbouron@amazon.com, jgg@ziepe.ca, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, mhijaz@amazon.com, noodles@meta.com, peterhuewe@gmx.de Subject: Re: [PATCH v2] tpm: Fix uninitialized name_size_alg in tpm_buf_append_name() Message-ID: References: <20260509223500.4390-1-gunnarku@amazon.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260509223500.4390-1-gunnarku@amazon.com> On Sat, May 09, 2026 at 10:34:29PM +0000, Gunnar Kudrjavets wrote: > On Fri, May 09, 2026 at 07:35 PM Jarkko Sakkinen wrote: > > This is great observation but it is not a regression technically. > > > > Thus, this really should just state the issue and don't make it look > > like a bug report based on transcript that does not happen in the wild. > > Thank you for the feedback, Jarkko. That's a fair point. Since no > in-tree caller exercises this path today, framing it as a regression > is misleading. I'm happy to rework the commit description to present > it as a proactive hardening fix rather than a bug report, and drop the > Fixes tag accordingly. > > > I guess this is better than parameter removal since name caching would > > make sense [1] in future. > > Agreed. Keeeping the name parameter functional makes the API ready > for name caching without further changes. > > Would you prefer I resend with the adjusted description, or would you > like to suggest specific wording? Happy to go either way. Yeah so the point here is probably to prevent unmasking a bug in future, with the specific example of name caching. I.e., I see the change itself useful and important despite not being a bug fix per se. > > Gunnar BR, Jarkko