From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21E2A43B3FB; Tue, 4 Aug 2026 11:11:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785841873; cv=none; b=NsTYVFPio/OS2ih/lwAxV8VRb1UvdiIL1/BWumB8+Z+CYiDI0nT91Xv2I1FOBj6HUpvs86N2BDEUsbcFgFdePZOmKQWKv1imciz0n0nPZkRXsnTLsXP7umZAa7QTy8xg5YvPznj7NAE4BeVELXc9kW3tkE7vdwCoLfc5r12bQy0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785841873; c=relaxed/simple; bh=mDj6z2gP8LuJmmBVqmLdm+TebT+TQgsosgCkAdj6IjM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Wn81AQPfzfS0ePqsysw0IcH63zxFqb1WzGmes+KyE+IZQwvJlHGT4MAd+ErFUYW6jSBfswxqwGq91n5q2BIp9vvaQAsqvep1EnCER1mnBh9IivYT2yWsZyUj1W/Jtdof1k3z2VBLe9P8GfJGNlHUyNzRGZBGqsU06TXflfAPrRc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=G+5pAPYK; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="G+5pAPYK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43EDC1F000E9; Tue, 4 Aug 2026 11:11:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785841871; bh=x9WTrnnkHbtsN+MZWjYTlUGilo8WkuVoi8BtyG1CVyc=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=G+5pAPYK+UtORNM3sYcJFo94oS+gLZCs4XBiYmGGfFeHwS/SK9q2DYm7hyLcFvIU0 fraYmEKWxnutqgnwVh1FyxQapPubGQbF2nho9kc9lJ8+hCsAG+NRgG0PbruRaxXJoW vYdxWr6VVAvzIQ/gVw/PE92V6stO3/tHUi9/ZHDnDps9Cllxr1OkDaOcSoOe0eBy1Y ZsbRrbpXe18U+ACn+kxOkvEGCyVukK137ErQTUo7tvSK8r8K0pK2YR/qom3af91OHh tHhBfVQtF+VRkokF0L6eIHv/pqfyVPvBiTLQpAxbgTuLCLy5Y1/U3SarcPaWlwoexQ Vd1OigOBjaV0w== Message-ID: Date: Tue, 4 Aug 2026 13:11:04 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: add some missing includes to mm-local headers To: "Lorenzo Stoakes (ARM)" Cc: Andrew Morton , Muchun Song , Oscar Salvador , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Brendan Jackman , Zi Yan , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , Barry Song , Youngjun Park , Uladzislau Rezki , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org References: <20260804-fix-some-local-headers-v1-1-a7beb173c116@kernel.org> <8179be78-a35c-4d0f-8034-27f3154db0e7@kernel.org> <7e7c8e04-646f-4135-9ba5-e0c7fd6d8b41@kernel.org> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/4/26 13:05, Lorenzo Stoakes (ARM) wrote: > On Tue, Aug 04, 2026 at 12:51:40PM +0200, David Hildenbrand (Arm) wrote: >> On 8/4/26 12:45, David Hildenbrand (Arm) wrote: >>> >>> I'm curious, how did you identify these? The mm/vmalloc.h is rather easy, but I wonder about >>> e.g., mm/shuffle.h including mmzone.h. >>> >> >> To clarify, I have clangd running behind a vim plugin, and so far it just worked. >> >> I had to generate a weird XML at some point that does magical things for clangd. > > Well for me I get the kernel build to generate compiler_commands.json and use > that via: > > scripts/clang-tools/gen_compile_commands.py vmlinux.a arch/x86/boot/ > > In a build script. > > But maybe I need your weird XML... I do get frustrated that it limits things to > what I happened to compile. It'd be nice to get it to index literally everything > somehow. Nah, it was that magical json I had in mind. > >> >> So I'm curious how to invoke clangd manually to actually get these reports. > > See other reply, it's just that I noticed missing symbols. > > Actually this happened with vma.h (I sloppily got AI to figure out any other > cases) which _intentionally_ doesn't have includes. > > But clangd lets you work around that in .clangd: > > If: > PathMatch: mm/vma\.h > CompileFlags: > Add: [-include, mm/vma_internal.h] > > :) I was hoping for an easy-to-run script that complains, instead of people just randomly running into "missing symbols" and then having to fix it. But there doesn't seem to be a low hanging fruit. -- Cheers, David