From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Mark Brown <broonie@kernel.org>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org, thierry.reding@gmail.com,
boris.brezillon@free-electrons.com, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] regulator: pwm: suppress EPROBE_DEFER error message
Date: Wed, 23 Jan 2019 16:14:49 +0000 [thread overview]
Message-ID: <afa9ed378b7fa62e81662363fdaf7543@codethink.co.uk> (raw)
In-Reply-To: <20190123160405.GD7503@sirena.org.uk>
On 2019-01-23 16:04, Mark Brown wrote:
> On Mon, Jan 21, 2019 at 07:37:23PM +0100, Martin Blumenstingl wrote:
>> Suppress the "Failed to get PWM" error output if the actual error code
>> is EPROBE_DEFER. This makes the behavior of the pwm-regulator driver
>> consistent with what most other drivers do (which is: print all errors
>> except EPROBE_DEFER).
>>
>> An example where this cleans up the kernel log are the 32-bit Amlogic
>> Meson boards:
>> multi_v7_defconfig has CONFIG_REGULATOR_PWM=y and CONFIG_PWM_MESON=m.
>
> This also cleans up the kernel log in the case where you've not got a
> driver enabled that you need (or it's not loading for some reason)
> which
> isn't super helpful when you're trying to figure out why the driver
> won't probe. There's not even anything at debug level, that would
> probably be fine.
>
> The ideal thing here would be to work on setting up the dependency
> information based on DT and using that to try to sort initialization
> order so we try things in an order that minimizes the number of failed
> tries.
Hmm, would it be useful to have a devfs file which holds the last probe
code?
next prev parent reply other threads:[~2019-01-23 16:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 18:37 [PATCH 0/1] pwm-regulator: reduce noise on EPROBE_DEFER Martin Blumenstingl
2019-01-21 18:37 ` [PATCH 1/1] regulator: pwm: suppress EPROBE_DEFER error message Martin Blumenstingl
2019-01-23 15:27 ` Anand Moon
2019-01-23 16:04 ` Mark Brown
2019-01-23 16:14 ` Ben Dooks [this message]
2019-01-23 17:29 ` Mark Brown
2019-01-21 19:18 ` [PATCH 0/1] pwm-regulator: reduce noise on EPROBE_DEFER Mark Brown
2019-01-21 20:55 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afa9ed378b7fa62e81662363fdaf7543@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=boris.brezillon@free-electrons.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox