From: Damien Le Moal <dlemoal@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Antoine Tenart <atenart@kernel.org>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Palmer Dabbelt <palmerdabbelt@google.com>,
Vladimir Zapolskiy <vz@mleia.com>
Cc: linux-kernel@vger.kernel.org,
Damien Le Moal <damien.lemoal@wdc.com>,
linux-riscv@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/5] reset: k210: fix OF node leak in probe() error path
Date: Mon, 26 Aug 2024 13:11:39 +0900 [thread overview]
Message-ID: <afad6db5-e33c-4402-adec-d1948300191a@kernel.org> (raw)
In-Reply-To: <20240825-reset-cleanup-scoped-v1-2-03f6d834f8c0@linaro.org>
On 8/25/24 11:14 PM, Krzysztof Kozlowski wrote:
> Driver is leaking OF node reference on memory allocation failure.
> Acquire the OF node reference after memory allocation to fix this and
> keep it simple.
>
> Fixes: 5a2308da9f60 ("riscv: Add Canaan Kendryte K210 reset controller")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Looks good.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2024-08-26 4:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-25 14:14 [PATCH 0/5] reset: cleanup and simplify with devm and scoped Krzysztof Kozlowski
2024-08-25 14:14 ` [PATCH 1/5] reset: berlin: fix OF node leak in probe() error path Krzysztof Kozlowski
2024-08-26 4:13 ` Damien Le Moal
2024-08-25 14:14 ` [PATCH 2/5] reset: k210: " Krzysztof Kozlowski
2024-08-26 4:11 ` Damien Le Moal [this message]
2024-08-25 14:14 ` [PATCH 3/5] reset: simplify locking with guard() Krzysztof Kozlowski
2024-09-02 9:57 ` Philipp Zabel
2024-08-25 14:14 ` [PATCH 4/5] reset: lpc18xx: simplify with dev_err_probe() Krzysztof Kozlowski
2024-08-25 20:16 ` Vladimir Zapolskiy
2024-08-26 4:13 ` Damien Le Moal
2024-08-25 14:14 ` [PATCH 5/5] reset: lpc18xx: simplify with devm_clk_get_enabled() Krzysztof Kozlowski
2024-08-25 20:16 ` Vladimir Zapolskiy
2024-08-26 4:15 ` Damien Le Moal
2024-08-26 4:12 ` [PATCH 0/5] reset: cleanup and simplify with devm and scoped Damien Le Moal
2024-09-02 9:58 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afad6db5-e33c-4402-adec-d1948300191a@kernel.org \
--to=dlemoal@kernel.org \
--cc=atenart@kernel.org \
--cc=damien.lemoal@wdc.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=palmerdabbelt@google.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox