The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Siddharth Vadapalli <s-vadapalli@ti.com>
To: Hrushikesh Salunke <h-salunke@ti.com>
Cc: <nm@ti.com>, <vigneshr@ti.com>, <kristo@kernel.org>,
	<robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
	<s-vadapalli@ti.com>, <linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<danishanwar@ti.com>, <srk@ti.com>
Subject: Re: [PATCH] arm64: dts: ti: k3-am69-sk: Add idle-states for remaining SERDES instances
Date: Thu, 19 Jun 2025 11:35:20 +0530	[thread overview]
Message-ID: <afb54fe8-a271-4074-8249-669219954c4c@ti.com> (raw)
In-Reply-To: <ec2c7fab-6f4d-4163-90a9-16dddec80adb@ti.com>

On Wed, Jun 11, 2025 at 06:23:24PM +0530, Siddharth Vadapalli wrote:
> On Mon, Jun 09, 2025 at 05:29:21PM +0530, Hrushikesh Salunke wrote:
> > In AM69 SoC there are 4 instances of the 4 lane SERDES. So in
> > "serdes_ln_ctrl" node there are total 16 entries in "mux-reg-mask"
> > property. But "idle-states" is defined only for the lanes of first two
> > SERDES instances. For completeness, set the "idle-states" of lanes of
> > remaining SERDES instances to a default value of "unused".
> > 
> > Signed-off-by: Hrushikesh Salunke <h-salunke@ti.com>
> 
> Reviewed-by: Siddharth Vadapalli <s-vadapalli@ti.com>

I failed to notice that this change will introduce a regression on
AM69-SK for CPSW AND Display which rely on the SERDES Lane Mapping for
SERDES2 and SERDES4 being at their reset value of "zero". This patch
should be fixed by updating it to the following:

	<J784S4_SERDES2_LANE0_IP2_UNUSED>, <J784S4_SERDES2_LANE1_IP2_UNUSED>,
	<J784S4_SERDES2_LANE2_QSGMII_LANE1>, <J784S4_SERDES2_LANE3_QSGMII_LANE2>,
	<J784S4_SERDES4_LANE0_EDP_LANE0>, <J784S4_SERDES4_LANE1_EDP_LANE1>,
	<J784S4_SERDES4_LANE2_EDP_LANE2>, <J784S4_SERDES4_LANE3_EDP_LANE3>;


Regards,
Siddharth.

  reply	other threads:[~2025-06-19  6:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-09 11:59 [PATCH] arm64: dts: ti: k3-am69-sk: Add idle-states for remaining SERDES instances Hrushikesh Salunke
2025-06-11 12:53 ` Siddharth Vadapalli
2025-06-19  6:05   ` Siddharth Vadapalli [this message]
2025-06-19 10:39     ` Hrushikesh Salunke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afb54fe8-a271-4074-8249-669219954c4c@ti.com \
    --to=s-vadapalli@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=danishanwar@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=h-salunke@ti.com \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=srk@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox