From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 274761A6830 for ; Sun, 3 May 2026 09:58:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777802302; cv=none; b=CkVD06U49dEB3bHv99AVS59v0VfhYN+0U+Rma+uNv0O6SGM2pYRot5lRHGgTjfzyBmQvNJmTFfleaI5pwvQTfRVYO3pnILxQrxssWctXc7aaFk9AnLzFV58Q8StLa5GGf4tfjvpH3aDk+aNObKhWFon4epVwXa20yhVJdlNKst0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777802302; c=relaxed/simple; bh=wN7YJNialwwvaCvyEYZQX1g9WMoTRdqmlQMx4oFABfg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hzdLm8amvHNGtoP4SZZDa4QvhJ4+jtSoHYauvEEAaVJQDtOZyWwusj8IMlwWA1Z7+MbyiR3m9wLOXt2pXFzY99cxzsMjxfPLMN7T8xciinZb99C+lNq072gp1jrBs3nWYrnwrFp+vWxSD8WLfHtDFMyARVZmi3651NLA7CqsEBA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bCPo/fPY; arc=none smtp.client-ip=209.85.208.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bCPo/fPY" Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-3938d17d6c5so4715971fa.1 for ; Sun, 03 May 2026 02:58:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777802298; x=1778407098; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lSBf8CExY9jgudE78FG1uqiYWbeT+6xyXMQp2hwYd6M=; b=bCPo/fPYoWPWkHz1Gb8QW9PnmdLHSrjbpo83iXryYgi6TL3i1wDV1bvmxofG+iGa37 BVa27T65rjQsI5TAgyBFxdqZ5v5aQaIBDVVRLNdE3YwQsWVOhK2VfgARUdTrc02MINYv sViedfFE5miJx9nXbFtxLbctt970zfvcFzKqp0gfl+aqtR9ThrXuFlXdXru6tV5NNGn8 0mA9XDzXYT6HqXywC0s655Duz6bHQwm+ipR/NgkqoOAm2IqPZEUD0SQDcifNPi0DPKow JM4CQxh1Z/7WEVGm43+2sbfVkZyJrz8+ihtx9D7SmujclHI7wlMN8YD4I3j/AyjQ6Hwo p+Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777802298; x=1778407098; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lSBf8CExY9jgudE78FG1uqiYWbeT+6xyXMQp2hwYd6M=; b=qjtpgJPxZNNdd5QOhPUNMkEAu+PIRH4DH447+ISFI6MYC1P8c02duNMGYcqXI+Ujzw gQxJsxhvsINycWY10nMEbCPtMzMYLKRcQCSUX10rxEWbj/FAU73todtJMpQB1Kg1UAJV rV5Ta5kP719RXMTFcBgPZANZ+aP8T6MXX5OfVBe8W34I/W5oxbcl5kAsXez0u5j3hewd Z8OEmHnrT1KNOGeI5GAlOlZGQ2MX3lP0NFSQR0G8EdofetiQQ7hliiWP17yVyVLN97oe m9E+MHm7bQVKv39amJgf8p7GqLzZuAIi3PUueXMMzAYE/183N58JT2o4OICQKDx/E//y c2bg== X-Forwarded-Encrypted: i=1; AFNElJ8QHykYb4tbJu6+9cURAGTApa22WrHNaw4z8j3XCwaBjysTJ71kdRwh4Tc63pambkY9cC4i4SorZ0eq0ww=@vger.kernel.org X-Gm-Message-State: AOJu0YykIAY+GkXvUgEbOGzITjiCzloLpf4s7HUt17Ej3WGCQ19AmUBC S+nnpMQMH2wv4WK4DSrGvJD4LyN/9OBk+ghZFVJZO4vz/LtELupTPz6H X-Gm-Gg: AeBDieuvw7N8eF3DA+aSpR0v0eApsgsXVIpW7votF0Vjx+4BvQUZKcFeGVEzKr/9M9p 15V+DexreELdSdALS2LXg6we7suqoETQbSGc8ooAuOdjY6I1rs7Qv8BOzr3O6Xxvuqs5H9kkd2n TPU3VNZkN4fSti/gu7rZgtBQuRg4dJnso6rVBQGpLLtpiv4BDcIXpk74OmfYzykW45ta+Y71k0d Vky6wK6uIwYHQik4fbdh7U/GtmNgUddFYHzX5tJFRfMaZq8DxhT/1KJ7JItogWu8s/RtutkSp+f plgfVofwiJoh3FjdIg5OcDmOjonmdrxY9zXKjXtLe4emi8z1lCTw6tfdI+pd4ykYd3xAqUSa+C1 6og+lpoBnr53nMYoEm/E12MIM9hdTpc1rAtUgWyN9GZOctzASc6heTx1ww7TBCWaQEu/IXKqBui W7noogGFnH9xj7LdEGQbUnAZGZNWv4ZBhtU4k= X-Received: by 2002:a2e:ab19:0:b0:38e:22:c612 with SMTP id 38308e7fff4ca-393783c5d72mr17424511fa.6.1777802298032; Sun, 03 May 2026 02:58:18 -0700 (PDT) Received: from archlinux ([185.140.161.214]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3937a9aef4asm10448641fa.4.2026.05.03.02.58.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 May 2026 02:58:17 -0700 (PDT) Date: Sun, 3 May 2026 12:58:14 +0300 From: Nikolay Kulikov To: Francisco Maestre Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] staging: rtl8723bs: remove unnecessary braces in sdio_intf.c Message-ID: References: <20260503004144.66733-1-francisco@maestretorreblanca.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260503004144.66733-1-francisco@maestretorreblanca.com> On Sat, May 02, 2026 at 07:41:44PM -0500, Francisco Maestre wrote: > Remove braces around a single-statement block in the SDIO > disconnect path, as per kernel coding style guidelines. > > This fixes the following checkpatch.pl warning: > WARNING: braces {} are not necessary for single statement blocks > > Signed-off-by: Francisco Maestre > --- > drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > index d664e254912c..a86252ccac76 100644 > --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > @@ -146,9 +146,8 @@ static void sdio_deinit(struct dvobj_priv *dvobj) > sdio_claim_host(func); > sdio_disable_func(func); > > - if (dvobj->irq_alloc) { > + if (dvobj->irq_alloc) > sdio_release_irq(func); > - } > > sdio_release_host(func); > } > -- > 2.50.1 (Apple Git-155) > > This is already fixed in staging-next. Thanks, Nikolay