From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 657801448E0 for ; Mon, 17 Nov 2025 05:47:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=35.89.44.33 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763358463; cv=none; b=GznWYiLvitU5Jj/f0CrHEqU4QZw12Ft9DfyD8Rm+GF8O5aR/SczGLvEeoG3ddd3oigS04GJ/HBcIxR8H+5UP2itPMcy9muhAMJ1FTd7qbo7y/kgH/vyLhG63Sm8HcvEQOgYRe+KgpCEbv8X1IYayE8C8y+lHSID76IyiZIPkLas= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763358463; c=relaxed/simple; bh=lRuMMAQFfKtE9Hjz37VG/Ob85XUqc4TnBdjxVRw97ww=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jwQ3KY1rTvD3tiMZ3DPrvC+eeHPUVaGKt2fa8k8PcOnZXAnykoBOhgvrLG5/WMLY0+63gHWwqej1lV7VxsQEvQ9RINqxkWDEXRDCVqr8gCp1ZGmFGgGvGGLzPqHxCKxDLgpUi0ygKiU5Qxncz7MH5JbO93IkiljFRJAg6AYieH4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com; spf=pass smtp.mailfrom=embeddedor.com; dkim=pass (2048-bit key) header.d=embeddedor.com header.i=@embeddedor.com header.b=ZiVrcGBf; arc=none smtp.client-ip=35.89.44.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=embeddedor.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=embeddedor.com header.i=@embeddedor.com header.b="ZiVrcGBf" Received: from eig-obgw-6005b.ext.cloudfilter.net ([10.0.30.162]) by cmsmtp with ESMTPS id KltFvCFzxZx2iKs5OvRdWQ; Mon, 17 Nov 2025 05:47:34 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id Ks5OvH1OYXtP2Ks5Ovo4Xy; Mon, 17 Nov 2025 05:47:34 +0000 X-Authority-Analysis: v=2.4 cv=W7Q4VQWk c=1 sm=1 tr=0 ts=691ab6f6 a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=4DtsFWJC70/ZxGj2xnZlig==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=7T7KSl7uo7wA:10 a=VwQbUJbxAAAA:8 a=iox4zFpeAAAA:8 a=XhWbaVAy7xEXXl44f-sA:9 a=QEXdDO2ut3YA:10 a=WzC6qhA0u3u7Ye7llzcV:22 a=xYX6OU9JNrHFPr8prv8u:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=89x8whf2MOkQOTUoYg65n709kE93HhhjOZ/hCJbnnoE=; b=ZiVrcGBf7SX1mi8OH36yZsRghq uKQ/LBBp/ZzVs4rPcTWNX6Vp4HyWvehZQXJH+w0YiHxtXcJ+6mKZ/jK5K2AQD7XXSOnL/t9vqhjpX AydAFjXHuJeRAbwPBICWvu3q8sRzDAgc7PtC1a+JQIdqkfvG3IiaSlIgyVlVSEu7MJC+t4mqt5YoJ 0tTgsvEfYf8WcZwh356Mbf3MP8kdUFIaSSNHVlXuoJOf+JejPZX1NN+RJpad+nEefKRwAgj24L+No kslT1ok3H+X7xOgyoS6/1FxYrs0KKx5ba70XrQbJ1lQE0tKPsGAGuw7yAWFLivfhAO5G6vzaKdy7z yiAzg9Gg==; Received: from softbank126126126075.bbtec.net ([126.126.126.75]:36702 helo=[10.221.86.44]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.1) (envelope-from ) id 1vKs5N-000000003ZG-2b5r; Sun, 16 Nov 2025 23:47:33 -0600 Message-ID: Date: Mon, 17 Nov 2025 14:47:22 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH][next] ocfs2: Avoid -Wflex-array-member-not-at-end warning To: Heming Zhao , "Gustavo A. R. Silva" Cc: Mark Fasheh , Joel Becker , Joseph Qi , ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <7vsq3tvjuv3ppiot3lgithyp76r4jbbssoiiuni6zvj5pajsov@nketwax66jss> Content-Language: en-US From: "Gustavo A. R. Silva" In-Reply-To: <7vsq3tvjuv3ppiot3lgithyp76r4jbbssoiiuni6zvj5pajsov@nketwax66jss> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 126.126.126.75 X-Source-L: No X-Exim-ID: 1vKs5N-000000003ZG-2b5r X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: softbank126126126075.bbtec.net ([10.221.86.44]) [126.126.126.75]:36702 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 2 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfHI/Rkk1hAU1YYdxwjocCRJWMyQBru0E7cWqu5GQBGMRrRfWCwQNfJbSdQkioUaqdXw4OLzRMtdYpEK7637X/X5mWJJy6rMYFYBvMOFoXlD8IssaMOa/ GpZk1GBY5OjdAPQ3bjoSI3+Qf08dcQUuDCdYCa6z3XEfYz15OxNV78tXhZF57eMb3l/lBpYFB9RS683eDDRcAowvzKolVCW4Usdr9mxLj6ImJ3HZgVj7PtFT On 11/17/25 14:32, Heming Zhao wrote: > On Tue, Nov 11, 2025 at 12:01:19PM +0900, Gustavo A. R. Silva wrote: >> -Wflex-array-member-not-at-end was introduced in GCC-14, and we are >> getting ready to enable it, globally. >> >> Use the new TRAILING_OVERLAP() helper to fix the following warning: >> >> fs/ocfs2/xattr.c:52:41: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end] >> >> This helper creates a union between a flexible-array member (FAM) and a >> set of MEMBERS that would otherwise follow it. >> >> This overlays the trailing MEMBER struct ocfs2_extent_rec er; onto the >> FAM struct ocfs2_xattr_value_root::xr_list.l_recs[], while keeping the >> FAM and the start of MEMBER aligned. >> >> The static_assert() ensures this alignment remains, and it's >> intentionally placed inmediately after the related structure --no >> blank line in between. >> >> Signed-off-by: Gustavo A. R. Silva > > LGTM. > Reviewed-by: Heming Zhao Thanks, Heming. -Gustavo