From: Nick Chan <towinchenmi@gmail.com>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: devicetree@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
Sven Peter <sven@svenpeter.dev>,
Thomas Gleixner <tglx@linutronix.de>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Hector Martin <marcan@marcan.st>,
linux-kernel@vger.kernel.org,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
asahi@lists.linux.dev
Subject: Re: [PATCH 1/3] dt-bindings: apple,aic: Document A7-A11 compatibles
Date: Thu, 29 Aug 2024 19:09:31 +0800 [thread overview]
Message-ID: <afd79f6c-89b4-4229-aa16-f130a35d78b0@gmail.com> (raw)
In-Reply-To: <172492705116.3333643.6993934329983052782.robh@kernel.org>
On 29/8/2024 18:24, Rob Herring (Arm) wrote:
>
> On Thu, 29 Aug 2024 17:03:11 +0800, Nick Chan wrote:
>> Document the compatibles for Apple A7-A11 SoCs.
>>
>> There are three feature levels:
>> - A7-A10: No fast IPI
>> - A11: fast IPI, global only
>> - M1: fast IPI with local and global support
>>
>> Each feature level is an extension of the previous. For example, M1 will
>> also work with the A7 feature level.
>>
>> Signed-off-by: Nick Chan <towinchenmi@gmail.com>
>> ---
>> .../bindings/interrupt-controller/apple,aic.yaml | 15 ++++++++++++---
>> 1 file changed, 12 insertions(+), 3 deletions(-)
>>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/interrupt-controller/apple,aic.example.dtb: interrupt-controller@23b100000: compatible: 'oneOf' conditional failed, one must be fixed:
> ['apple,t8103-aic', 'apple,aic'] is too long
> ['apple,t8103-aic', 'apple,aic'] is too short
> 'apple,s5l8960x-aic' was expected
> 'apple,t8103-aic' is not one of ['apple,s8000-aic', 'apple,t7000-aic', 'apple,t8010-aic']
> 'apple,t8015-aic' was expected
> from schema $id: http://devicetree.org/schemas/interrupt-controller/apple,aic.yaml#
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240829092610.89731-2-towinchenmi@gmail.com
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
Acked. yamllint was not installed on my system.
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>
Nick Chan
next prev parent reply other threads:[~2024-08-29 11:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 9:03 [PATCH 0/3] Add AIC support for A7-A11 SoCs Nick Chan
2024-08-29 9:03 ` [PATCH 1/3] dt-bindings: apple,aic: Document A7-A11 compatibles Nick Chan
2024-08-29 10:24 ` Rob Herring (Arm)
2024-08-29 11:09 ` Nick Chan [this message]
2024-08-29 11:43 ` Krzysztof Kozlowski
2024-08-29 11:44 ` Krzysztof Kozlowski
2024-08-29 12:42 ` Nick Chan
2024-08-29 9:03 ` [PATCH 2/3] irqchip/apple-aic: Only access IPI sysregs when use_fast_ipi is true Nick Chan
2024-08-29 9:03 ` [PATCH 3/3] irqchip/apple-aic: Add a new "Global fast IPIs only" feature level Nick Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afd79f6c-89b4-4229-aa16-f130a35d78b0@gmail.com \
--to=towinchenmi@gmail.com \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=robh@kernel.org \
--cc=sven@svenpeter.dev \
--cc=tglx@linutronix.de \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox