From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AF753B4EB3 for ; Sun, 3 May 2026 14:22:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777818179; cv=none; b=XfO70IClmRRLFmYOZDKeKByjVgF9rxwGoO2GTAPwZRidijL9i6ZOkMHehA3VRt+BkHL7h+Q5CDVvRCDgYkkFh9ipwAylAyXWZ+Gbdm9sS9tON+F/6HgWj4FR62NM+US4ISvqISIhO7Y5dPDdZF0gPA79MiX3jCPzeMlklFTMRrM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777818179; c=relaxed/simple; bh=U7pwhyXBMDtWvkMIs7VuTEmpG9+lGG+wV56eRoTfp48=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HTXE0A2/P39XV3jtQMfZTHJhRcR6OCenAyON0HDRL/smjDCMqMODKFJgwh51X7uvIhAxa3Rq/C9JFzGpZVvK0RS0kWRsUrYjtyWcADPbPR4mVums1ZVa1+DkoWdxZ0rkwy4KIJKtkD/+QNViZeCQheo6yJMIGmzdGpo4ickge/M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OJJmOLdt; arc=none smtp.client-ip=209.85.208.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OJJmOLdt" Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-3878de20527so25761011fa.3 for ; Sun, 03 May 2026 07:22:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777818176; x=1778422976; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=q65oEaXt2ePAiS+XY6Tj0z2vpKPplbzs5MIN/+Z0Bf4=; b=OJJmOLdtfvk7SpMVHsFZp80ima+57FRgdUcFr8LlURxkGLH/yj37/yVOx+DdBYO6H3 X7H1n4W/t35os8jmfhgjlIqWQjN1bf0wT300q/K5hqlyp6WJLSpk6H/ksaAJsbUGmTQC DUEWVJuiib4pLXqL8mR1xmQ1VrqaUsoFks7faPeJBpJIg4Aen4saXWEOpKgpwBpsM9hq sGc/gKk8sm0GGZLORpGbCYIA7TUvGw2tZyHjbVGpAHyvEGAVd/abkVrRLwbvpVmIk3DF UEZV8/Zn7K+8C1tN27oziP/geCFL098j8viHCOb+Gr3OWunMfOxS7kpp1Tv6yGdSKhp7 dCxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777818176; x=1778422976; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q65oEaXt2ePAiS+XY6Tj0z2vpKPplbzs5MIN/+Z0Bf4=; b=POHxWDx8xXZAC4Az9j4BiLkOheMr+uS9+6GAtGrAvYiplGdnnQwTxHWfNzIzCaYBQe yRVrwHgVORdd4RJ9C3bs+9Nxo5z6nFNMGwNaKWhddFC1OBEBtCo1oF2jN99TxNHcoMMn +N8XgcGSsPkhIu1e/bxhr4LRA5brKx4IiEEJ+eHzxKL3f8jBzdpYBozQdJetl8Zhk32j lre3OGKqjlqxIWt2U2kbJ3Omtkg9PKf6p77vcR1P5slmyztghWGxECzc/LevqwLWSnBj 2ub5iwADpZXwVEUvJ7YL57vf1QbH7itjSGunhxMOyhgKZEyejxrI8Ts/ARGJBUcNzzKq puKQ== X-Forwarded-Encrypted: i=1; AFNElJ+CLrNHskJ2HsQb6mQaORhAuiERbubp73OarYQ27LOPt8DoSBT6lyzSHuYp2DBCb6UxVtPpgNVDPATo1nc=@vger.kernel.org X-Gm-Message-State: AOJu0YzyctFAa69R4lXrF50o7WQ+LDqbGMC8EAL1Chu43STLhxEre2b/ 9cf3S3NC29vGnU6hD1RADcnZ9lp8LJjrCoeWDmYl/cT+6aa28p3rdWtSQsbhXA== X-Gm-Gg: AeBDievPWfZoXgGusb/hlLN39VClK2kG3AaW/fFgcZ3ZqZvUf7IVsabyftPQRSelqUw dn2cEPkMlx9GYS00zTq+742A6LQzwp19DZJD8OvpK1hO+xQa25z2965MhhYnGgnkEXGYsPCtxSe dGDac2ofWpPdM/GrbJQMdScP4vErDuAgp8VprQQ1M1l/elOqgCrM91c9UaicsF6HOebV/jOUtjK ScQS+fKSLPPG0QXQCXd6+nrNcE87EKM9vt6xg0CuStnwm4xhqzDoFBkpIHKScOJhmr/T1+XEjcX zm/aNiXzkCOS1q+3CrG4lpOJfMnJcspDVu+bwur1oHvyVnpYvpKeG6BgHnHXoYAW/CiO3PL7vQ5 h1yZJbY22CLLSF0zSDNB165tO6dZPq02jWChrGT0c0Qy7v/1NYaJj31Qb1QxF2+Hcr2nOe+8/Yp UrW5dsFREuKSccr3dwk98lmJqcy2R3y60a6pE= X-Received: by 2002:a05:651c:1602:b0:393:93c1:b7d8 with SMTP id 38308e7fff4ca-39393c1b8ddmr7860961fa.28.1777818176057; Sun, 03 May 2026 07:22:56 -0700 (PDT) Received: from archlinux ([185.140.161.214]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-39361300984sm22026751fa.21.2026.05.03.07.22.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 May 2026 07:22:55 -0700 (PDT) Date: Sun, 3 May 2026 17:22:52 +0300 From: Nikolay Kulikov To: Ashwin Gundarapu Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: remove unnecessary comparison to true Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sun, May 03, 2026 at 06:40:53PM +0530, Ashwin Gundarapu wrote: > Remove unnecessary comparison to true in conditional statement. > Found by checkpatch. > > Signed-off-by: Ashwin Gundarapu > --- > From b49d621579be96ef71e3206b888f3ab39c297491 Mon Sep 17 00:00:00 2001 > From: Ashwin Gundarapu > Date: Sat, 2 May 2026 17:19:48 +0530 > Subject: [PATCH] staging: rtl8723bs: remove unnecessary comparison to true > > Remove explicit comparison to true in check_fwstate() call and > add spacing around the bitwise OR operator to improve code style. > > Signed-off-by: Ashwin Gundarapu > --- > drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c > index c70541f95a73..c100a0d70fe2 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c > +++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c > @@ -151,7 +151,8 @@ u8 rtw_set_802_11_ssid(struct adapter *padapter, struct ndis_802_11_ssid *ssid) > else if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING) == true) > goto release_mlme_lock; > > - if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) == true) { > + if (check_fwstate(pmlmepriv, > + _FW_LINKED | WIFI_ADHOC_MASTER_STATE)) { > if ((pmlmepriv->assoc_ssid.ssid_length == ssid->ssid_length) && > (!memcmp(&pmlmepriv->assoc_ssid.ssid, ssid->ssid, ssid->ssid_length))) { > if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) == false) { > -- > 2.43.0 > Hello, Your patch arrived as an attachment, not in the body of the email. The kernel development process requires patches to be in the body of the email so they can be viewed and quoted in replies. Please resend it using "git send-email'. See Documentation/process/submitting-patches.rst and [1] for more information. [1] https://kernelnewbies.org/FirstKernelPatch Thanks, Nikolay