From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C506E39DBD9 for ; Sun, 3 May 2026 20:59:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777841944; cv=none; b=hrJm4WxfVRGfhpbFb2KYijpgw6zePQH74l1LulDHX/Lru+Z59NxHazlZMh+dUpgnEfi4AnyvO+IusyxiYQVYzyh6HalKLQ6cBm49EjsdRMS1O9EfKtaylXAO6rJPRnos22bVJrVJqkVRadLIMncPG/ShcRtiXOp82qpX6Kn96A0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777841944; c=relaxed/simple; bh=bIlSEVzdKNhDMrKfR5acabbN/otCFveKcVn/mu5ECtk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F7X+IKtbfkyMMXP+6PkiJRcQR8q4LWpwrxDGu/UoVtkM61SVjCpQTSVOK+HKqp9Zrc0qPQIQriPhA/udosK4cSNTU9dZbArbna62SDG+B/ppL4esiD243o84qSrDYIS1rc+vn6e2TI/oNwF/2CupBBHfb8PQSi9e9gr37D7jZV4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=1Xgup3U+; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=zmUgIm6m; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=qKuTWOay; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=FMOcnVxS; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="1Xgup3U+"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="zmUgIm6m"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="qKuTWOay"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="FMOcnVxS" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EC2DB6AA93; Sun, 3 May 2026 20:58:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777841941; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6jUR1uxvaSLZyWIoihP/wMTwTZLYZuSSduV3/xUI8fI=; b=1Xgup3U+L3WGHHzjDE44YWjLVEvHFE8HyjQf0n+wQhvavTo5Kxvq9hR1sYdR7Xk6uZYY2A tBVPWEBoIcV8C4BcnFkh2I04dQHZjHXcxq8M9jqS96bNn9uNev3+AVHYgOafhhD4fmLzXN zBdudaxNdPkv81sW57AgbnkobIQTAOo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777841941; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6jUR1uxvaSLZyWIoihP/wMTwTZLYZuSSduV3/xUI8fI=; b=zmUgIm6mGUodhQcP01MGDrQkkjyxZRvXpbwKNXsrrqN1+SVe3peVm1MGOWVzH9eGo60jz/ hVeXQAkDWm6u71AQ== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777841939; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6jUR1uxvaSLZyWIoihP/wMTwTZLYZuSSduV3/xUI8fI=; b=qKuTWOayyNixedJNQn7ODoi/QDBMwDvcrXceC07F19iNCiXEjjrwM0VOpKcM7gFxjwnLbl /VPjNE5TwMeKodjX3LuuGhu3/tZ5Du/9Bi1IeeR0I5cD9Ew79vJwhjaHl9PAPqRHGL3/vm Vunvin1Svkpyxf1LKrd8lKzRG4IXqXs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777841939; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6jUR1uxvaSLZyWIoihP/wMTwTZLYZuSSduV3/xUI8fI=; b=FMOcnVxS9TytqwIJ3XWkpFUqBhpTwC/obhmXtI37EBVjz00gJTuNHETA/KU/mm/GLFmrFa cYuJOLGsvptK2wCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9AC43593A3; Sun, 3 May 2026 20:58:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id zbnhHhO392nGKgAAD6G6ig (envelope-from ); Sun, 03 May 2026 20:58:59 +0000 Date: Sun, 3 May 2026 21:58:57 +0100 From: Pedro Falcato To: Thorsten Blum Cc: Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/mseal: use min/max in mseal_apply Message-ID: References: <20260503115915.18680-3-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260503115915.18680-3-thorsten.blum@linux.dev> X-Spamd-Result: default: False [-3.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; MISSING_XM_UA(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCPT_COUNT_SEVEN(0.00)[8]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:email] X-Spam-Flag: NO X-Spam-Score: -3.80 X-Spam-Level: On Sun, May 03, 2026 at 01:59:16PM +0200, Thorsten Blum wrote: > Use the type-checked min()/max() macros instead of MIN()/MAX(), which > are supposed to be used "for obvious constants only". Gotta love these macros... FYI this isn't the only wrong usage in the kernel. > > Signed-off-by: Thorsten Blum Reviewed-by: Pedro Falcato -- Pedro