* [PATCH] tty: serial: Prepare cleanup of powerpc's asm/prom.h
@ 2022-04-02 10:20 Christophe Leroy
2022-04-06 8:29 ` Jiri Slaby
0 siblings, 1 reply; 2+ messages in thread
From: Christophe Leroy @ 2022-04-02 10:20 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby
Cc: Christophe Leroy, linux-kernel, linuxppc-dev, linux-serial
powerpc's asm/prom.h brings some headers that it doesn't
need itself.
In order to clean it up, first add missing headers in
users of asm/prom.h
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
---
drivers/tty/serial/cpm_uart/cpm_uart_cpm2.c | 1 -
drivers/tty/serial/mpc52xx_uart.c | 2 ++
drivers/tty/serial/pmac_zilog.c | 1 -
3 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/cpm_uart/cpm_uart_cpm2.c b/drivers/tty/serial/cpm_uart/cpm_uart_cpm2.c
index 6a1cd03bfe39..108af254e8f3 100644
--- a/drivers/tty/serial/cpm_uart/cpm_uart_cpm2.c
+++ b/drivers/tty/serial/cpm_uart/cpm_uart_cpm2.c
@@ -25,7 +25,6 @@
#include <asm/io.h>
#include <asm/irq.h>
#include <asm/fs_pd.h>
-#include <asm/prom.h>
#include <linux/serial_core.h>
#include <linux/kernel.h>
diff --git a/drivers/tty/serial/mpc52xx_uart.c b/drivers/tty/serial/mpc52xx_uart.c
index 8a6958377764..4ec785e4f9b1 100644
--- a/drivers/tty/serial/mpc52xx_uart.c
+++ b/drivers/tty/serial/mpc52xx_uart.c
@@ -38,6 +38,8 @@
#include <linux/delay.h>
#include <linux/io.h>
#include <linux/of.h>
+#include <linux/of_address.h>
+#include <linux/of_irq.h>
#include <linux/of_platform.h>
#include <linux/clk.h>
diff --git a/drivers/tty/serial/pmac_zilog.c b/drivers/tty/serial/pmac_zilog.c
index 5d97c201ad88..c903085acb8d 100644
--- a/drivers/tty/serial/pmac_zilog.c
+++ b/drivers/tty/serial/pmac_zilog.c
@@ -51,7 +51,6 @@
#include <asm/irq.h>
#ifdef CONFIG_PPC_PMAC
-#include <asm/prom.h>
#include <asm/machdep.h>
#include <asm/pmac_feature.h>
#include <asm/dbdma.h>
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tty: serial: Prepare cleanup of powerpc's asm/prom.h
2022-04-02 10:20 [PATCH] tty: serial: Prepare cleanup of powerpc's asm/prom.h Christophe Leroy
@ 2022-04-06 8:29 ` Jiri Slaby
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Slaby @ 2022-04-06 8:29 UTC (permalink / raw)
To: Christophe Leroy, Greg Kroah-Hartman
Cc: linux-kernel, linuxppc-dev, linux-serial
On 02. 04. 22, 12:20, Christophe Leroy wrote:
> powerpc's asm/prom.h brings some headers that it doesn't
> need itself.
>
> In order to clean it up, first add missing headers in
> users of asm/prom.h
>
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> ---
> drivers/tty/serial/cpm_uart/cpm_uart_cpm2.c | 1 -
> drivers/tty/serial/mpc52xx_uart.c | 2 ++
> drivers/tty/serial/pmac_zilog.c | 1 -
> 3 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/cpm_uart/cpm_uart_cpm2.c b/drivers/tty/serial/cpm_uart/cpm_uart_cpm2.c
> index 6a1cd03bfe39..108af254e8f3 100644
> --- a/drivers/tty/serial/cpm_uart/cpm_uart_cpm2.c
> +++ b/drivers/tty/serial/cpm_uart/cpm_uart_cpm2.c
> @@ -25,7 +25,6 @@
> #include <asm/io.h>
> #include <asm/irq.h>
> #include <asm/fs_pd.h>
> -#include <asm/prom.h>
>
> #include <linux/serial_core.h>
> #include <linux/kernel.h>
> diff --git a/drivers/tty/serial/mpc52xx_uart.c b/drivers/tty/serial/mpc52xx_uart.c
> index 8a6958377764..4ec785e4f9b1 100644
> --- a/drivers/tty/serial/mpc52xx_uart.c
> +++ b/drivers/tty/serial/mpc52xx_uart.c
> @@ -38,6 +38,8 @@
> #include <linux/delay.h>
> #include <linux/io.h>
> #include <linux/of.h>
> +#include <linux/of_address.h>
> +#include <linux/of_irq.h>
> #include <linux/of_platform.h>
> #include <linux/clk.h>
>
> diff --git a/drivers/tty/serial/pmac_zilog.c b/drivers/tty/serial/pmac_zilog.c
> index 5d97c201ad88..c903085acb8d 100644
> --- a/drivers/tty/serial/pmac_zilog.c
> +++ b/drivers/tty/serial/pmac_zilog.c
> @@ -51,7 +51,6 @@
> #include <asm/irq.h>
>
> #ifdef CONFIG_PPC_PMAC
> -#include <asm/prom.h>
> #include <asm/machdep.h>
> #include <asm/pmac_feature.h>
> #include <asm/dbdma.h>
--
js
suse labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-06 11:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-02 10:20 [PATCH] tty: serial: Prepare cleanup of powerpc's asm/prom.h Christophe Leroy
2022-04-06 8:29 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox