From: Alexey Dobriyan <adobriyan@gmail.com>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: akpm@linux-foundation.org, mhiramat@kernel.org, arnd@kernel.org,
ndesaulniers@google.com, sfr@canb.auug.org.au,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com
Subject: Re: [PATCH RFC bootconfig] 2/2] fs/proc: Add /proc/cmdline_image for embedded arguments
Date: Fri, 4 Aug 2023 20:28:08 +0300 [thread overview]
Message-ID: <aff81f30-e20d-40a0-adb3-893781459475@p183> (raw)
In-Reply-To: <20230728033701.817094-2-paulmck@kernel.org>
On Thu, Jul 27, 2023 at 08:37:01PM -0700, Paul E. McKenney wrote:
> In kernels built with CONFIG_BOOT_CONFIG_FORCE=y, /proc/cmdline will show
> all kernel boot parameters, both those supplied by the boot loader and
> those embedded in the kernel image. This works well for those who just
> want to see all of the kernel boot parameters, but is not helpful to those
> who need to see only those parameters that were embedded into the kernel
> image. This is especially important in situations where there are many
> kernel images for different kernel versions and kernel configurations,
> all of which opens the door to a great deal of human error.
>
> Therefore, provide a /proc/cmdline_image file that shows only those kernel
> boot parameters that were embedded in the kernel image. The output
> is in boot-image format, which allows easy reconcilation against the
> boot-config source file.
>
> Why put this in /proc? Because it is quite similar to /proc/cmdline, so
> it makes sense to put it in the same place that /proc/cmdline is located.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Alexey Dobriyan <adobriyan@gmail.com>
> Cc: Masami Hiramatsu <mhiramat@kernel.org>
> Cc: <linux-fsdevel@vger.kernel.org>
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> ---
> fs/proc/cmdline.c | 12 ++++++++++++
> include/linux/init.h | 11 ++++++-----
> init/main.c | 9 +++++++++
Same thing,
Please if possible put /proc/x into fs/proc/x.c so that it is easier to
find source. Not all /proc follows this convention but still.
I don't like this name too (but less than the other one).
Is it Boot Image Format (BIF). If yes, maybe add it as /proc/cmdline.bif ?
I don't know what's the good name.
next prev parent reply other threads:[~2023-08-04 17:28 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 3:35 [PATCH RFC bootconfig 0/2] Distinguish bootloader and embedded kernel parameters Paul E. McKenney
2023-07-28 3:37 ` [PATCH RFC bootconfig] 1/2] fs/proc: Add /proc/cmdline_load for boot loader arguments Paul E. McKenney
2023-07-28 4:06 ` Stephen Rothwell
2023-07-28 20:52 ` Paul E. McKenney
2023-07-29 14:29 ` Masami Hiramatsu
2023-07-29 16:16 ` Paul E. McKenney
2023-07-30 1:58 ` Masami Hiramatsu
2023-07-30 18:17 ` Paul E. McKenney
2023-08-04 17:23 ` Alexey Dobriyan
2023-08-04 17:36 ` Paul E. McKenney
2023-08-04 18:43 ` Paul E. McKenney
2023-08-07 2:44 ` Masami Hiramatsu
2023-08-07 4:39 ` Paul E. McKenney
2023-08-12 23:30 ` Paul E. McKenney
2023-08-14 23:08 ` Paul E. McKenney
2023-08-16 9:40 ` Masami Hiramatsu
2023-08-16 15:17 ` Masami Hiramatsu
2023-08-16 16:13 ` Paul E. McKenney
2023-08-20 14:14 ` Masami Hiramatsu
2023-08-20 15:40 ` Paul E. McKenney
2023-07-28 3:37 ` [PATCH RFC bootconfig] 2/2] fs/proc: Add /proc/cmdline_image for embedded arguments Paul E. McKenney
2023-07-29 14:23 ` Masami Hiramatsu
2023-07-29 15:41 ` Paul E. McKenney
2023-07-30 1:55 ` Masami Hiramatsu
2023-08-04 17:28 ` Alexey Dobriyan [this message]
2023-08-04 17:33 ` Paul E. McKenney
2023-07-28 4:25 ` [PATCH RFC bootconfig 0/2] Distinguish bootloader and embedded kernel parameters Randy Dunlap
2023-07-28 21:05 ` Paul E. McKenney
2023-07-31 23:30 ` [PATCH RFC v2 bootconfig 0/3] " Paul E. McKenney
2023-07-31 23:31 ` [PATCH RFC v2 bootconfig 1/3] doc: Update /proc/cmdline documentation to include boot config Paul E. McKenney
2023-08-01 1:02 ` Masami Hiramatsu
2023-08-01 2:00 ` Randy Dunlap
2023-08-01 4:00 ` Paul E. McKenney
2023-07-31 23:31 ` [PATCH RFC v2 bootconfig 2/3] fs/proc: Add /proc/cmdline_load for boot loader arguments Paul E. McKenney
2023-07-31 23:31 ` [PATCH RFC v2 bootconfig 3/3] doc: Add /proc/bootconfig to proc.rst Paul E. McKenney
2023-08-01 1:04 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aff81f30-e20d-40a0-adb3-893781459475@p183 \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@kernel.org \
--cc=kernel-team@meta.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=ndesaulniers@google.com \
--cc=paulmck@kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox