From: Alice Ryhl <aliceryhl@google.com>
To: "Onur Özkan" <work@onurozkan.dev>
Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
ojeda@kernel.org, boqun@kernel.org, gary@garyguo.net,
bjorn3_gh@protonmail.com, lossin@kernel.org,
a.hindborg@kernel.org, tmgross@umich.edu, dakr@kernel.org,
tamird@kernel.org, daniel.almeida@collabora.com
Subject: Re: [PATCH v2 0/1] rust: add Work::disable_sync
Date: Mon, 4 May 2026 07:55:35 +0000 [thread overview]
Message-ID: <afhQ9zN9IH3skby6@google.com> (raw)
In-Reply-To: <20260501191122.64311-1-work@onurozkan.dev>
On Fri, May 01, 2026 at 10:11:21PM +0300, Onur Özkan wrote:
> The immediate motivation is the Tyr reset infrastructure [1] which needs
> to stop queued or running reset work during teardown before dropping the
> resources used by that work. The reset series started to require too many
> independent dependencies, so this is split out as a standalone change to
> keep the reset series focused on the reset logic and easier to review,
> rebase and land.
>
> [1]: https://lore.kernel.org/all/20260416171728.205141-1-work@onurozkan.dev
The fact that it's motivated by Tyr could be in the commit message
itself.
> Changes since v1:
> - Fixed a soundness issue where Work::disable_sync() could make a later
> Pin<KBox<T>> enqueue fail and hit unreachable_unchecked().
> - Removed the WorkItemPointer::cancel() helper and explicitly call drop()
> in disable_sync() after C has already canceled the work.
>
> v1: https://lore.kernel.org/all/20260428104459.174602-1-work@onurozkan.dev
>
> Onur Özkan (1):
> rust: add Work::disable_sync
>
> rust/kernel/workqueue.rs | 121 ++++++++++++++++++++++++++-------------
> 1 file changed, 81 insertions(+), 40 deletions(-)
>
> --
> 2.51.2
>
prev parent reply other threads:[~2026-05-04 7:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-01 19:11 [PATCH v2 0/1] rust: add Work::disable_sync Onur Özkan
2026-05-01 19:11 ` [PATCH v2 1/1] " Onur Özkan
2026-05-04 7:54 ` Alice Ryhl
2026-05-05 6:07 ` Onur Özkan
2026-05-05 8:47 ` Alice Ryhl
2026-05-05 9:16 ` Onur Özkan
2026-05-05 9:50 ` Boris Brezillon
2026-05-05 10:10 ` Onur Özkan
2026-05-05 11:20 ` Boris Brezillon
2026-05-04 7:55 ` Alice Ryhl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afhQ9zN9IH3skby6@google.com \
--to=aliceryhl@google.com \
--cc=a.hindborg@kernel.org \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox