From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54D6C364923 for ; Mon, 4 May 2026 09:27:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777886845; cv=none; b=WtPL0BvdKyZjPsuS+HK341YveLm8d2Do61Krm0HTloZOYnktVtp9h/yK+9G4eGDoH+8VbDB6VR/UJthlAb9V3fRJI4+PLVpxcyN66QjHDQwqa2FPuLPVFsyokBe79WtTPvJGspKbKc/htnYTeai3Q/gSPk3rLWaYpLL90Q59nBU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777886845; c=relaxed/simple; bh=SsFjufCbM40Vhq3eYyg8Kp9HolYdhJc1KvNNS4T9DGY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qvNEgSX3pYHSzFx46eneKrtj1VI/Qi+r7e1+apQ0s5MxkccuCZ+6g/UMMM50FQvsDpkb6gw0j70qKH+JEkohLi0lfKhdyauo4LILLeLo5UlaQei5PouTYU9ONlWgLSeMP1Yr+hPqUFra3kvRKXT0um0V0hvscdS32QcKM0NWwdY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=clSpwJVM; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="clSpwJVM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777886843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SsFjufCbM40Vhq3eYyg8Kp9HolYdhJc1KvNNS4T9DGY=; b=clSpwJVMo7c3Gz8RZf50RWXHXkSiDR9MDtbm9SzaJ/D9GxWkE25i41jdpWJQ6TNMPHCmD3 j8iEulUBmv+AJk04DC9zzbdGWo7XkHKbBEsMOOzZbQVjlmY0CcNgXfRZ2vhGyNEUg9Eygm vZM91EXN7PWcUOTAQoyCLF/5uoFEq6o= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-9-6m-QQoMVMIqt0Y2g0-JWaQ-1; Mon, 04 May 2026 05:27:17 -0400 X-MC-Unique: 6m-QQoMVMIqt0Y2g0-JWaQ-1 X-Mimecast-MFC-AGG-ID: 6m-QQoMVMIqt0Y2g0-JWaQ_1777886836 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7CB671800370; Mon, 4 May 2026 09:27:15 +0000 (UTC) Received: from fedora (unknown [10.44.33.157]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 0243E180045E; Mon, 4 May 2026 09:27:10 +0000 (UTC) Received: by fedora (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Mon, 4 May 2026 11:27:15 +0200 (CEST) Date: Mon, 4 May 2026 11:27:08 +0200 From: Oleg Nesterov To: Andrew Morton Cc: Andy Lutomirski , Kees Cook , Kusaram Devineni , Peter Zijlstra , Thomas Gleixner , Will Drewry , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] signal: change force_sig_info_to_task() to call __send_signal_locked() Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 On 05/02, Oleg Nesterov wrote: > > force_sig_info_to_task() calls send_signal_locked() but this is pointless; > info is always valid and has_si_pid_and_uid(info) should never be true. > Forced signals do not carry si_pid/si_uid, not to mention that info.si_pid > overlaps with .si_addr/si_call_addr/etc. https://sashiko.dev/#/patchset/afYGeHSWkLzXDlvC%40redhat.com Sorry I could not reply earlier... Oh, I didn't know people use force_sig() to send SIGKILL. I'd say they should not, but this doesn't matter - they do. So this needs yet another version. And I will read man grep 3 times. Thanks again Sashiko. Oleg.