From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9888A3B9600 for ; Mon, 4 May 2026 12:13:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777896792; cv=none; b=FqmngHQArUwSmYf0zaI1eK9zbtLdaZTfmC6J2WUcnkK5NmW4em3RKR+k0sZgncC3R4C7d0YjtZQH92RquDE7yKGRSLqGNXz/6BvesT91HbuytUAGjjheIlonjgOnt3jLILDzX5QfNqY3wAimIrHP+hsSvaoWIFHhatMZYeR5qfg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777896792; c=relaxed/simple; bh=bX2UkMsTl6OcCaUjBf88U30d1MFR4spQoSasIx4OSUM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SnQ76Re5c5OeTreMtSUEFkUR8cz6OysTl/j9AQK06OuogFjuNTZIbx+JNDAMO70zAkwPfPvv3z7mg1O/QRqNMgWRgoEp8HfyqhyGM0ymGFetGBH9clbDTNiY1D3Qh3j4FISEdtwwUVAF/CH2SwPV2w4AJTboKkkS5TU287WPKjQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=io5zT/KF; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="io5zT/KF" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4891ad5c074so202445e9.0 for ; Mon, 04 May 2026 05:13:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1777896789; x=1778501589; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=7MdnKaX0TB6YagnPneZAL0SbiGRfNhnRbVRU61aMvP8=; b=io5zT/KF4HbiUuuhI/it6iGUrdh0HneBtLceHkmnecBIao882AD6r1S/gLf1AJF0NF iCoyOsKMVO4qCJ49VeIg7SBu3+SUJTA1Yr/Aw0h6v1+2gBTQQALMQqq1a8JW9sQ7iO19 LrLJabLp8iyvxjTiAjxZdp1yQr5Fnf1eAUMIek0hb8mQzv69N735TQ76qCnkbmhQ+IM6 IEfGxJkCSkgXxX4VI8Y6ESeGOZKFwNdxFxEWDgCYYus1pgh9llkA521AHCvjcSySDb0C CkrXqgcd0mzuAyeYh1IY10uFU08n+cLkub5A8OTnBSFP5L0BKmAuNdHQBhrBdUpM8H1i VzqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777896789; x=1778501589; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7MdnKaX0TB6YagnPneZAL0SbiGRfNhnRbVRU61aMvP8=; b=RWd517HWhpGS6I1LoCa2pnBOqfM06D1H1LR0gFp86Hgvx3Ly0r21ElnJzuWKlB5MwP 1Dd5bN9cqv9uv4oFWeZpe3tSz/8SxQm4XzXdEhunvdB6EPw6CozDYioMdnbTAwj3pcOP a0TjaZiEzFbE2z2MC/AlX/rseiioJ5W5JJmxsBGbEvsTXIXlt/4NUBjwOjcjqKK/A1H5 qze/TaClR9ptSBQ8e42vHvu9mVlIrGAcCfiKLwDyc4TktwN+ChtRicAGdQqkBYM7/nC6 3tpkvyGvlpI2voam0+2uynyEKCgfFoaSO8SWgQvPz4NBJXZTNyfvuYOnQtm28+kJPsmL WGrQ== X-Forwarded-Encrypted: i=1; AFNElJ9xVbkZne640kc84GAVB35nFpgkRRrdSo8+507Vyx67DsAoOo9NdCZMyMpDPgcT5gK+4LVzpisO3He26Nc=@vger.kernel.org X-Gm-Message-State: AOJu0YxWINR5k/6q7r45DCRtH30fw3XYR7ZI3YcdT4tDonXwrEYPtd07 Bxh96zEx6tLNf7LSIWE5ekJKClJ20Q6N21M1acvMsXh7Omnyfh/8rj1OAqaZxKeByw== X-Gm-Gg: AeBDieugTNT/imi3uVM19JgdkTtC6ObB62xwoUKW5LA/w9rInT0RVcsuLSKT+d8qFTa 1+RMPoqKzT441DCo8xSR7F2Hbyr8W4ruMnCOcQ4jtqzDWVB6KI1B18GMU6PPSe08V8TOEvaawd4 4B2eNp8GamDpbNfTcQiCURiorYplKpBqd8KBDlgs6GjUGOE2mympapXbLf9qgDeVAN6dBHB3b37 tnECoGRdp0NUAS41yR3T9oSE6GtHtx0bmGmGmH/0BfPCdbLElBsz9P+wPasYiwXq2d4N6bH1myU ZcxU2GKeeCHvo5RHUIoOG7Ux8jG4KRYyoLrLG2Nr3zrvC3fp/KKU61EDzGIn0V0QNdubgsK3jlE UM3a3CTHyVsTg6gEmenOQ9uNlFZl4R53zkYg41640ZGB4nuBYKvE6kGsXiwPN9t5yqNKE8xDisT nlFcwEKPOUzPuN2bZ3a/5Fyf7NQ4p2NsBnkKpkmybJ3Z6JlZDd7s8ijmt5wZZ2KeHRv8vlTCHMx yrb4g== X-Received: by 2002:a05:600c:c3cf:10b0:485:1a54:9407 with SMTP id 5b1f17b1804b1-48a97f9d4cbmr1615265e9.0.1777896788643; Mon, 04 May 2026 05:13:08 -0700 (PDT) Received: from google.com (8.181.38.34.bc.googleusercontent.com. [34.38.181.8]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-44a8bf18c9bsm25362412f8f.0.2026.05.04.05.13.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 05:13:07 -0700 (PDT) Date: Mon, 4 May 2026 12:13:04 +0000 From: Mostafa Saleh To: Jason Gunthorpe Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev, catalin.marinas@arm.com, will@kernel.org, maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, joro@8bytes.org, jean-philippe@linaro.org, mark.rutland@arm.com, qperret@google.com, tabba@google.com, vdonnefort@google.com, sebastianene@google.com, keirf@google.com Subject: Re: [PATCH v6 03/25] iommu/arm-smmu-v3: Split code with hyp Message-ID: References: <20260501111928.259252-1-smostafa@google.com> <20260501111928.259252-4-smostafa@google.com> <20260501124445.GC6912@ziepe.ca> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260501124445.GC6912@ziepe.ca> On Fri, May 01, 2026 at 09:44:45AM -0300, Jason Gunthorpe wrote: > On Fri, May 01, 2026 at 11:19:05AM +0000, Mostafa Saleh wrote: > > +int arm_smmu_cmdq_build_cmd(u64 *cmd, struct arm_smmu_cmdq_ent *ent) > > +{ > > + memset(cmd, 0, 1 << CMDQ_ENT_SZ_SHIFT); > > + cmd[0] |= FIELD_PREP(CMDQ_0_OP, ent->opcode); > > Hopefully I get to it today, but I am going to post a series that will > move this logic into the headers while deleting arm_smmu_cmdq_ent. It > should be directly usable for pkvm as well to achieve this same split > without having to shove a giant inline into a header file. > > https://github.com/jgunthorpe/linux/commits/iommu_pt_arm64/ > > cover-letter: Remove SMMUv3 struct arm_smmu_cmdq_ent I see it’s already posted, I will go through it and provide feedback there. Thanks, Mostafa > > Jason