From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A1263AB274 for ; Mon, 4 May 2026 12:26:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777897604; cv=none; b=ON4i+rDaLlOVgWOTyx/umzIQudJ5tTa8il1I/AB97X/guFJcIqku1yOk8mgtUSoE30jwNnpBnHhrzzwN9PpwxXneDp848Q2OsdO1h+nRhRLsnuwaKwDyroK1Xv/d8D0Icv2ovrPHuRKX15DlzxcxCz37ZD8niiJ3Qek82eEgwv4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777897604; c=relaxed/simple; bh=GuKduAnAifjM+KgXSrO9TSTQq1fQjT1dMuJSNnmK2KU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OtLDdSHgArITnr84YQ33WN+mQAki15PT+RGpUzuMRC7HmYSva5vLEEn64326rEzoJ1igX3H1kAALcFMIVlopNnyblgoDxOQt5CAtaoC+ZlTkNB1KNbstLemz2YhfMHCRyofRdsBImKiq9OPAe+JEJmVBYsX/CpSgjZ1IhzW26do= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20251104.gappssmtp.com header.i=@resnulli-us.20251104.gappssmtp.com header.b=FxZRCPzF; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20251104.gappssmtp.com header.i=@resnulli-us.20251104.gappssmtp.com header.b="FxZRCPzF" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-488ff90d6c7so38203545e9.2 for ; Mon, 04 May 2026 05:26:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20251104.gappssmtp.com; s=20251104; t=1777897599; x=1778502399; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=djsbXCX96LzcDVFKY3N8T8f6fULjj9Xl7NUY8EOdjGw=; b=FxZRCPzFYRv2+F+2okSUuhTlDvhfok8708y2yAhiSK/6qikCv2BPPK2beb7Du2qKfm 0Qri/7wtazK0S6qU4WpOGBqsSgG0nmkcTf8piFxbopGdzFSXuNC4N/n6VCttw8MWA2t2 5oJ7vY9EtKgehzdQRnhHWFwoa0pEDqxgPyMTbWydWhe4d5Va587TWR6kkZQsy5zsZKv1 3rnmsfMf69aqP0m+4z6h9NwQ5RoOBg0++bxncSL3SmdPrkpk1zkVk1bREXtm8+jYHev1 Aq0MZEoJFUSB304hWU4KZsRjNIa+AWbkJr/nc1Gq0XOocorpsfYyC1No5vc4P3lQfkgb Mxww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777897599; x=1778502399; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=djsbXCX96LzcDVFKY3N8T8f6fULjj9Xl7NUY8EOdjGw=; b=iqkLAvpPjzU4nQMySVE4hkNELMeHOntuY/Gpr4jzv+A2jhNuaylWGy2VD4WzMeqlAa h1ngg8eMMFnRzztrN/aSWTKVrz5lPKh5YIf2KhKicWEI/cAvFhHYi0rcsiR/WEj6h4OV /iTc/psG14RmqUQb4GDQtmSZj0g5RZkN+vqFRoc8u+ahVbX1nKCFQ71aq/lenm4ecbK1 O8ehNB1ZJzeQTpNC1kKHKWih9485SG+n0TDqqBaBZEsEod3xLlbjdU8vnIL5/XjPCelh 7Vb1pUsesmY2h8J+Km1qkdQ/hJHzMAlRSQ6oMLwxmrDajeJiPGbj3aQm3REn29Jn4DIR kBWA== X-Forwarded-Encrypted: i=1; AFNElJ9FY0fNsmtQk2MN2yjQe3bL+XqFAsJJDrL+fh/au8pEAuE7ObWrSMEqlZyngfYY9RSY31Qe/vgtF4bdNWU=@vger.kernel.org X-Gm-Message-State: AOJu0YwK9wXDRPVTs+Vb9/jUdnQff7SkbKEzv7wm5BH4s07HNWE6E/JC YeNDJuAMJpUmmhDzocBvkofjrkMo8GCBzlXKtMGUbotq07MjQszHmx1kokJJzb5hwsc= X-Gm-Gg: AeBDietMWNZBGvD9GUerwLlal0Y0/TN+Q1xRzMtkTaucxZMwA4Ai9Sn6oDDjvgRofk3 lqnVM8CeoaAXSxFhjhwNnIw6gpdrruMCbuadosIRIOz4yI2D7e6b5kB2o0DrBauaKuSodMxyWPk DAgP6YR8ZErpmii1uUDAjpT0g9eWcWSobAviHLf5K6iUhTIdxW6rBNDQ3D85oRfs6KbQwaQWPu3 nQrZQcHJNvFW4PC9J7bizsKVMi45FS1Yqez6tdYIaIIcXzTv3qFDKR1XMiMJ52P3psLQo0ZkDCF hCEhfgp6TIA4IkRrYAPCYpJDAShJ+bCN7AEINWXgptw8TMYj8CV6B9Qrt+8kMsWA/jml10tXgGs IF6Z49pThphagOSEf0CV3Ojqzm3UjNn6mEUzTWCv/eftEWn/sPM1fh86jHYMwHOUp2TsLXPbV5y x51RY9HciOJMXtTjyX3TyLEWJ17GgyKjrhMJkmUC1fRvhocA== X-Received: by 2002:a05:600c:c058:b0:487:2671:fb8f with SMTP id 5b1f17b1804b1-48a98874de2mr121990565e9.8.1777897598760; Mon, 04 May 2026 05:26:38 -0700 (PDT) Received: from FV6GYCPJ69 ([140.209.217.211]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a82307f7csm334623445e9.12.2026.05.04.05.26.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 05:26:38 -0700 (PDT) Date: Mon, 4 May 2026 14:26:34 +0200 From: Jiri Pirko To: Ivan Vecera Cc: netdev@vger.kernel.org, Andrew Lunn , Arkadiusz Kubalewski , "David S. Miller" , Donald Hunter , Eric Dumazet , Jakub Kicinski , Jonathan Corbet , Leon Romanovsky , Mark Bloch , Michal Schmidt , Paolo Abeni , Pasi Vaananen , Petr Oros , Prathosh Satish , Saeed Mahameed , Shuah Khan , Simon Horman , Tariq Toukan , Vadim Fedorenko , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org Subject: Re: [PATCH net-next v2 1/2] dpll: move fractional-frequency-offset-ppt under pin-parent-device Message-ID: References: <20260430173611.3312596-1-ivecera@redhat.com> <20260430173611.3312596-2-ivecera@redhat.com> <290673a1-fb5b-4586-b44a-e109cc1a4629@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <290673a1-fb5b-4586-b44a-e109cc1a4629@redhat.com> Mon, May 04, 2026 at 11:36:19AM +0200, ivecera@redhat.com wrote: >Hi Jiri, > >On 5/4/26 10:48 AM, Jiri Pirko wrote: >> Thu, Apr 30, 2026 at 07:36:10PM +0200, ivecera@redhat.com wrote: >> > Move the fractional-frequency-offset-ppt attribute from the top-level >> > pin attributes into the pin-parent-device nested attribute set. This >> > makes it consistent with phase-offset which is already per-parent and >> > clarifies that FFO PPT represents the frequency difference between >> > a pin and its parent DPLL device. >> > >> > The top-level fractional-frequency-offset attribute (in PPM) remains >> > unchanged for backward compatibility. >> >> That is odd. The ppt one was added just for higher precision but was >> semantically the same. Now you change it. Could you still treat both the >> same? >> >WDYM? > >Keep fractional-frequency-offset-ppt at the top-level and add both >fractional-frequency-offset and fractional-frequency-offset-ppt into >pin-parent-device nested attribute set? Since both are the same, only different unit, it would make sense to treat them both the same. That prevents from user confusion, hopefully. > >Thanks, >Ivan >