From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FE473C063F for ; Mon, 4 May 2026 12:30:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777897842; cv=none; b=XOGWI0wYfuDWnXgLltIvAyGCQzuwwAheKG4ENRHf/JMAFQBkgOqa2JSt/yhWdesxkK6vkTtfY1fw5iUdE9ssV/cLDjq2/ID5b4m0TUHWjDtRf4Pp0wdIxNBwIe2JCekzHEvfzdo2Hr61VyuZyIucTnRThIxCvwXNsTSpTa35nzY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777897842; c=relaxed/simple; bh=4ZOBMscc1HOs7kCpJsHpKzdFOrZP/gFzsttOdLIt+CQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tyASzhl37gU/t/SfbR8/LpaumUFP2K7jdbnaiQlmRIB840F8AfY3xERbcjTmcrpZvEU6or7gqrTm8ndAzcJZQIu/T8bK1zJanrA90fQOCZ7zOVsIRkuI3FDFxq88e4YUFgd+8sXMxFYwz4rhfuKO+RKE8lzpp7EZV/3Swvmn4I0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=TyHuRJ/M; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="TyHuRJ/M" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4891ad5c074so203455e9.0 for ; Mon, 04 May 2026 05:30:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1777897839; x=1778502639; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qOfQTG3NufNYyUm+WMPkXEQQNupQgi3c8ZHhQrRCx6U=; b=TyHuRJ/M3H13MI5TzU5m8t6IU4l+0K8EaXx9yifZSUX3/7x1hVLiyQITQv+Gkq4Ar/ spL9s2YKMa9IObs+O44zRHJUm/uUq7Iv2OrUxtBfmer3tqS8KslxGjl4z4+f+F8Sfjon qRP2I9HQRw2ssC+H8YuBDMlm1g5pyb0wPpox3ESr5H+mJE4Fj83D5MlLn9F4QHDMt1+0 n4AJsh9Zj+LWoHLuyMdUUiLaglHlE9G+lI3N5zONEuqc1F+zrUi/1JX2YDITytO7S7sE G90q6Ogo042YJl8QJlaXyFITzpRtWyRZq6d2T6CksKP3FvtQa8+toinp9oi0iRPI7YCw 2P2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777897839; x=1778502639; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qOfQTG3NufNYyUm+WMPkXEQQNupQgi3c8ZHhQrRCx6U=; b=XFNlBrSiU8kXNrNqGfW2fwoR95rlVOL48I203JVAyf7YrmYvmvTofr5truAyUF5VAI OLNIzlvxDwMHRIVJv+ynobKXJCau5+9LeMP3BHYCi2GgWvTMWCGWz9Q8kLNoCLHpgLEj gUgYqu5X2uiViSeRnnZw4iwEJHGzQ9oE4b+nc4M4itpFjFqGyZpBm34j3ldenVDDXsqt KSP/1nXGEOxRYp5edZaGv9a02O0j92ZZaEXy/tmWutp+JosY56EJnmIz3oixUNIp9Tzl k68uQVkqofHDXZm6pP2ceEJTzc1qiosiSl7T5/Y0SvursscDR/nmnJM5RfIZ+IEeRGWY zViQ== X-Forwarded-Encrypted: i=1; AFNElJ+CWZL2r6V5emMWZAK25NwgGpp9GMijUBg9PRs+EYv0O6WaHl/bycZSnw8jjXCrA7qRYk8EaZhB6YUW3AI=@vger.kernel.org X-Gm-Message-State: AOJu0YzZ4gJxOmxkJ31nJYQFTZGbF1ybDRxf9NbiCIPCQIGeA82oIYrL yQfqjLwZI60qLLdhjIwYy2xWLDDgMCf5068Eoqf9Px7y7Hxxf7gMhOe2QSOLSCUumA== X-Gm-Gg: AeBDiesMmyl0UTXmahWouKkedmaeG1nyPwR6OxQkH+aW1kQMmWCPcgOsDY7+hUmHUUi AYTqwOpXAFP0/CW9wbvqs8lYmhsFBYhFMPxfYXnfogb0JM2MnLri16cdwCRungAR8sqowtWvB4B CTOc4mg0Qswqfhy4DU+3ssO9buaoHoDzDn1nPAlyi3FosgNJNZrWnl8BTvjX90If+d5iCEo1Gw+ MLuEakfruGptkyGHqdw2/hZ76k6+aFJ8kKFMXF+wNfOIb1JDbLDGGX1LdZ7n8fkF5+COld9KRG7 zLeEHDAvyXRA8+dWNo2CAuE28BVFMeheOlgZh7PWEUa/Qy/pJEyXGIGQ8Gz223U6RaxGsR4HXWl eyGkdzP37trseALUc1GeAxycblmSJLa5Pf8+C0xpg5ZYWNYj1WB+ln24JF7o+0l+5DvuBEpxFeJ 6hpSKGlZyo4VKoYsoBAqKCJsH9MoEdLbqhNfDyRhaFfD0YFSxgRpfmI9bkWmoEkXqE4Gh0jWy2P +t3KA== X-Received: by 2002:a05:600c:63c4:b0:485:b6e4:9808 with SMTP id 5b1f17b1804b1-48ac315a359mr2185965e9.1.1777897838152; Mon, 04 May 2026 05:30:38 -0700 (PDT) Received: from google.com (8.181.38.34.bc.googleusercontent.com. [34.38.181.8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a8fee32fesm113417605e9.3.2026.05.04.05.30.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 05:30:37 -0700 (PDT) Date: Mon, 4 May 2026 12:30:33 +0000 From: Mostafa Saleh To: Jason Gunthorpe Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev, catalin.marinas@arm.com, will@kernel.org, maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, joro@8bytes.org, jean-philippe@linaro.org, mark.rutland@arm.com, qperret@google.com, tabba@google.com, vdonnefort@google.com, sebastianene@google.com, keirf@google.com Subject: Re: [PATCH v6 13/25] iommu/arm-smmu-v3-kvm: Probe SMMU HW Message-ID: References: <20260501111928.259252-1-smostafa@google.com> <20260501111928.259252-14-smostafa@google.com> <20260501125148.GE6912@ziepe.ca> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260501125148.GE6912@ziepe.ca> On Fri, May 01, 2026 at 09:51:48AM -0300, Jason Gunthorpe wrote: > On Fri, May 01, 2026 at 11:19:15AM +0000, Mostafa Saleh wrote: > > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > > index 61e6ab364086..157acde0436d 100644 > > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > > @@ -4738,12 +4738,6 @@ static int arm_smmu_device_reset(struct arm_smmu_device *smmu) > > return 0; > > } > > > > -#define IIDR_IMPLEMENTER_ARM 0x43b > > -#define IIDR_PRODUCTID_ARM_MMU_600 0x483 > > -#define IIDR_PRODUCTID_ARM_MMU_700 0x487 > > -#define IIDR_PRODUCTID_ARM_MMU_L1 0x48a > > -#define IIDR_PRODUCTID_ARM_MMU_S3 0x498 > > - > > static void arm_smmu_device_iidr_probe(struct arm_smmu_device *smmu) > > { > > u32 reg; > > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h > > index 64618299d03a..f904f4d19609 100644 > > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h > > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h > > @@ -84,6 +84,12 @@ struct arm_vsmmu; > > #define IIDR_REVISION GENMASK(15, 12) > > #define IIDR_IMPLEMENTER GENMASK(11, 0) > > > > +#define IIDR_IMPLEMENTER_ARM 0x43b > > +#define IIDR_PRODUCTID_ARM_MMU_600 0x483 > > +#define IIDR_PRODUCTID_ARM_MMU_700 0x487 > > +#define IIDR_PRODUCTID_ARM_MMU_L1 0x48a > > +#define IIDR_PRODUCTID_ARM_MMU_S3 0x498 > > + > > #define ARM_SMMU_AIDR 0x1C > > Lets put these hunks in some earlier patch to migrate out the > functions/etc > > I think all these pkvm/arm-smmu-v3.c should just be building up the > driver. Will do. > > > +static bool smmu_nesting_supported(struct hyp_arm_smmu_v3_device *smmu) > > +{ > > + unsigned int implementer, productid, variant, revision; > > + u32 reg; > > + > > + if (!(smmu->features & ARM_SMMU_FEAT_TRANS_S1) || > > + !(smmu->features & ARM_SMMU_FEAT_TRANS_S2)) > > + return false; > > + > > + reg = readl_relaxed(smmu->base + ARM_SMMU_IIDR); > > + implementer = FIELD_GET(IIDR_IMPLEMENTER, reg); > > + productid = FIELD_GET(IIDR_PRODUCTID, reg); > > + variant = FIELD_GET(IIDR_VARIANT, reg); > > + revision = FIELD_GET(IIDR_REVISION, reg); > > + > > + if (implementer != IIDR_IMPLEMENTER_ARM) > > + return true; > > + > > + if (productid == IIDR_PRODUCTID_ARM_MMU_600) > > + return variant >= 2; > > + else if (productid == IIDR_PRODUCTID_ARM_MMU_700) > > + return !(variant < 1 || revision < 1); > > + > > + return true; > > +} > > Why not share all this errata stuff with the idr parsing code too? > > We already have ARM_SMMU_FEAT_NESTING that has the above calculation. > > The two drivers use the same ARM_SMMU_FEAT system, I would expect one > chunk of shared code to compute the FEATs, who cares if pkvm doesn't > use all of them? > > Use the same errata logic and so on to get to the feat bitmap. Makes sense. Thanks, Mostafa > > Jason